Skip to main content
Revision b2688c91613566db1f42edd4b45f6e17146531b9 authored by Matt Caswell on 03 January 2015, 00:54:35 UTC, committed by Matt Caswell on 08 January 2015, 14:14:29 UTC
Follow on from CVE-2014-3571. This fixes the code that was the original source
of the crash due to p being NULL. Steve's fix prevents this situation from
occuring - however this is by no means obvious by looking at the code for
dtls1_get_record. This fix just makes things look a bit more sane.

Conflicts:
	ssl/d1_pkt.c

Reviewed-by: Dr Stephen Henson <steve@openssl.org>
1 parent bf6fa20
Raw File
asn1test.c
#include <openssl/x509.h>
#include <openssl/asn1_mac.h>

typedef struct X
    {
    STACK_OF(X509_EXTENSION) *ext;
    } X;

/* This isn't meant to run particularly, it's just to test type checking */
int main(int argc, char **argv)
    {
    X *x = NULL;
    unsigned char **pp = NULL;

    M_ASN1_I2D_vars(x);
    M_ASN1_I2D_len_SEQUENCE_opt_type(X509_EXTENSION, x->ext,
				     i2d_X509_EXTENSION);
    M_ASN1_I2D_seq_total();
    M_ASN1_I2D_put_SEQUENCE_opt_type(X509_EXTENSION, x->ext,
				     i2d_X509_EXTENSION);
    M_ASN1_I2D_finish();
    }
back to top