| b74cc07 | Geoff Thorpe | 01 December 2003, 23:11:45 UTC | Add missing bn_check_top()s to bn_kron.c, remove some miscellaneous white-space, and include extra headers to satisfy debugging builds. | 01 December 2003, 23:11:45 UTC |
| e7e5fe4 | Geoff Thorpe | 01 December 2003, 23:10:21 UTC | Add missing bn_check_top()s to bn_gf2m.c and remove some miscellaneous white-space. | 01 December 2003, 23:10:21 UTC |
| 998ae04 | Geoff Thorpe | 01 December 2003, 22:11:08 UTC | The bn_set_max() macro is only "used" by the bn_set_[low|high]() macros which, in turn, are used nowhere at all. This is a good thing because bn_set_max() would currently generate code that wouldn't compile (BIGNUM has no 'max' element). The only apparent use for bn_set_[low|high] would be for implementing windowing algorithms, and all of openssl's seem to use bn_***_words() helpers instead (including the BN_div() that Nils fixed recently, which had been using independently-coded versions of what these unused macros are intended for). I'm therefore consigning these macros to cvs oblivion in the name of readability. | 01 December 2003, 22:11:08 UTC |
| e65c2b9 | Geoff Thorpe | 01 December 2003, 21:59:40 UTC | bn_fix_top() exists for compatibility's sake and is mapped to bn_correct_top() or bn_check_top() depending on debug settings. For internal source, all bn_fix_top()s should be converted one way or the other depending on whether the use of bn_correct_top() is justified. For BN_div_recp(), these cases should not require correction if the other bignum functions are doing their jobs properly, so convert to bn_check_top(). | 01 December 2003, 21:59:40 UTC |
| 2fe9ab8 | Richard Levitte | 01 December 2003, 13:25:37 UTC | It was pointed out to me that if the requested size is 0, we shouldn't ty to allocate anything at all. This will allow eNULL to still work. PR: 751 Notified by: Lutz Jaenicke | 01 December 2003, 13:25:37 UTC |
| 1145e03 | Richard Levitte | 01 December 2003, 12:11:55 UTC | Check that OPENSSL_malloc() really returned some memory. PR: 751 Notified by: meder@mcs.anl.gov Reviewed by: Lutz Jaenicke, Richard Levitte | 01 December 2003, 12:11:55 UTC |
| 6781efb | Richard Levitte | 01 December 2003, 12:06:15 UTC | CRYPTO_malloc(), CRYPTO_realloc() and variants of them should return NULL if the give size is 0. This is a thought that came up in PR 751. | 01 December 2003, 12:06:15 UTC |
| 0bf1c1d | Lutz Jänicke | 01 December 2003, 08:12:47 UTC | Some more ASFLAGS settings required PR: #735 Submitted by: Tim Rice <tim@multitalents.net> | 01 December 2003, 08:12:47 UTC |
| 6ed474c | Geoff Thorpe | 30 November 2003, 23:29:27 UTC | Add more debugging to my Configure target, and "make update" to incorporate this and a few other changes. | 30 November 2003, 23:29:27 UTC |
| 46cb8d3 | Geoff Thorpe | 30 November 2003, 22:23:12 UTC | If BN_STRICT is defined, don't accept an ambiguous representation of zero (ie. where top may be zero, or it may be one if the corresponding word is set to zero). Note, this only affects the macros in bn.h, there are probably similar corrections required in some c files. Also, clarify the audit-related macros at the top of the header. Mental note: I must not forget to clean all this out before 0.9.8 is released ... | 30 November 2003, 22:23:12 UTC |
| 23fc5ac | Geoff Thorpe | 30 November 2003, 22:02:10 UTC | Improve a couple of the bignum macros. Note, this doesn't eliminate tolerance of ambiguous zero-representation, it just improves BN_abs_is_word() and simplifies other macros that depend on it. | 30 November 2003, 22:02:10 UTC |
| 5734beb | Geoff Thorpe | 30 November 2003, 21:21:30 UTC | Make BN_DEBUG_RAND less painfully slow by only consuming one byte of pseudo-random data for each bn_pollute(). | 30 November 2003, 21:21:30 UTC |
| 657a919 | Geoff Thorpe | 29 November 2003, 20:34:07 UTC | This improves the placement of check_top() macros in a couple of bn_lib functions. | 29 November 2003, 20:34:07 UTC |
| 6859bb1 | Richard Levitte | 29 November 2003, 10:33:25 UTC | Make sure the documentation matches reality. PR: 755 Notified by: Jakub Bogusz <qboosh@pld-linux.org> | 29 November 2003, 10:33:25 UTC |
| 3822740 | Richard Levitte | 29 November 2003, 10:25:37 UTC | We're getting a clash with C++ because it has a type called 'list'. Therefore, change all instances of the symbol 'list' to something else. PR: 758 Submitted by: Frédéric Giudicelli <groups@newpki.org> | 29 November 2003, 10:25:37 UTC |
| 0d78bc3 | Richard Levitte | 29 November 2003, 09:25:59 UTC | Add IPSec/IKE/Oakley curves. PR: 768 Submitted by: Vadim Fedukovich <vf@unity.net> | 29 November 2003, 09:25:59 UTC |
| d87b79b | Richard Levitte | 29 November 2003, 09:19:12 UTC | Damnit, I'm sick of having to do something special every time a module that gets built before objects barfs all over the place because it uses a new NID that hasn't had a chance of getting defined yet (in this case, it was about a couple of new EC curves, and therefore a couple of new corresponding NIDs). I'm placing objects first in SDIRS! There. | 29 November 2003, 09:19:12 UTC |
| 70ef9c5 | Richard Levitte | 28 November 2003, 23:03:14 UTC | RSA_size() and DH_size() return the amount of bytes in a key, and we compared it to the amount of bits required... PR: 770 Submitted by: c zhang <czhang2005@hotmail.com> | 28 November 2003, 23:03:14 UTC |
| b727907 | Richard Levitte | 28 November 2003, 22:39:19 UTC | 1024 is the export key bits limit according to current regulations, not 512. PR: 771 Submitted by: c zhang <czhang2005@hotmail.com> | 28 November 2003, 22:39:19 UTC |
| 444c3a8 | Geoff Thorpe | 28 November 2003, 16:39:16 UTC | Get rid of some signed/unsigned comparison warnings. | 28 November 2003, 16:39:16 UTC |
| 0b352c5 | Richard Levitte | 28 November 2003, 14:51:30 UTC | Make a number of changes to the OS/2 build. Submitter's comment below. PR: 732 Submitted by: Ilya Zakharevich <nospam-abuse@ilyaz.org> Submitter's comment: This patch: a) Introduces a new file os2/backwardify.pl. b) Introduces a new mk1mf.pl variable $preamble. As you can see, it may be used also to move some OS-specific code to VC-CE too (the the first chunk of the patch); c) The DESCRIPTION specifier of the .def file is made more informative: now it contains the version number too. On OS/2 it is made conformant to OS/2 conventions; in particular, when one runs the standard command BLDLEVEL this.DLL one can see: Vendor: www.openssl.org/ Revision: 0.9.7c Description: OpenSSL: implementation of Secure Socket Layer; DLL for library crypto. Build for EMX -Zmtd [I did not make Win32 descriptions as informative as this - I'm afraid to break something. Be welcome to fix this.] d) On OS/2 the generated DLL was hardly usable (it had a shared initialized data segment). e) On OS/2 the generated DLLs had names like ssl.dll. However, DLL names on OS/2 are "global data". It is hard to have several DLLs with the same name on the system. Thus this precluded coexistence of OpenSSL with DLLs for other SLL implementations - or other name clashes. I transparently changed the names of the DLLs to open_ssl.dll and cryptssl.dll. f) The file added in (a) is used to create "forwarder" DLLs, so the applications expecting the "old" DLL names may use the new DLLs transparently. (A presence of these DLLs on the system nullifies (e), but makes old applications work. This is a stopgap measure until the old applications are relinked. Systems with no old applications do not need these DLLs, so may enjoy all the benefits of (e).) The new DLLs are placed in os2/ and os2/noname subdirectories. g) The makefiles created with os2/OS2-EMX.cmd did not work (some mysterious meaningless failures). The change to util/pl/OS2-EMX.pl uses the variable introduced in (b) to switch the Makefiles to SHELL=sh syntax. All these backslashes are removed, and the generated Makefiles started to work. h) Running os2/OS2-EMX.cmd now prints out what to do next. | 28 November 2003, 14:51:30 UTC |
| 03ddbdd | Richard Levitte | 28 November 2003, 14:45:09 UTC | Move another common functionality (reproduced so far with cut'n'paste) to apps.c, and give it the hopefully descriptive name parse_yesno(). | 28 November 2003, 14:45:09 UTC |
| 5ebdb39 | Richard Levitte | 28 November 2003, 14:32:31 UTC | Let's use text/plain in the example instead of crapy HTML. PR: 777 Submitted by: Michael Shields <mshields@sunblocksystems.com> | 28 November 2003, 14:32:31 UTC |
| d45a098 | Richard Levitte | 28 November 2003, 14:18:05 UTC | Forgot to change the declaration of do_subject() to one of parse_name()... | 28 November 2003, 14:18:05 UTC |
| 6d5ffb5 | Richard Levitte | 28 November 2003, 14:07:14 UTC | Move do_subject() to apps.c and rename it to parse_name(). The rationale behind the move is that it's use by several applications. The rationale behind the name change is that it describes what the function does a bit better. | 28 November 2003, 14:07:14 UTC |
| 7ce9e42 | Richard Levitte | 28 November 2003, 14:04:09 UTC | Allow multi-valued rdns in subjects. This adds the -multivalue-rdn option to 'openssl req' and 'openssl ca'. PR: 779 Submitted by: Michael Bell <michael.bell@cms.hu-berlin.de> Reviewed by: Richard Levitte (there will be some follow-up changes) | 28 November 2003, 14:04:09 UTC |
| 4d8743f | Richard Levitte | 28 November 2003, 13:10:58 UTC | Netware-specific changes, PR: 780 Submitted by: Verdon Walker <VWalker@novell.com> Reviewed by: Richard Levitte | 28 November 2003, 13:10:58 UTC |
| 4c8b4f9 | Richard Levitte | 28 November 2003, 12:54:11 UTC | Change my debugging entries to do fierce BIGNUM debugging. | 28 November 2003, 12:54:11 UTC |
| 81ba5f6 | Geoff Thorpe | 25 November 2003, 21:07:59 UTC | Due to recent debugging bursts, openssl should be more or less solid against inconsistent BIGNUMs coming out of any of its API functions. So this change no longer "fixes" the bn_print.c functions, but it makes for cleaner code. This patch was a part of ticket 697. PR: 697 Submitted by: Otto Moerbeek Reviewed by: Geoff Thorpe | 25 November 2003, 21:07:59 UTC |
| 6defae0 | Geoff Thorpe | 25 November 2003, 20:39:19 UTC | Fix some handling in bn_word. This also resolves the issues observed in ticket 697 (though uses a different solution than the proposed one). This problem was initially raised by Otto Moerbeek. PR: 697 Submitted by: Nils Larsch Reviewed by: Geoff Thorpe | 25 November 2003, 20:39:19 UTC |
| e1064ad | Geoff Thorpe | 25 November 2003, 03:41:20 UTC | Some changes for bn_gf2m.c: better error checking plus some minor optimizations. Submitted by: Nils Larsch | 25 November 2003, 03:41:20 UTC |
| d7559f1 | Lutz Jänicke | 24 November 2003, 16:48:52 UTC | Free "engine" resource in case of failure to prevent memory leak PR: #778 Submitted by: George Mitchell <george@m5p.com> | 24 November 2003, 16:48:52 UTC |
| 9e98981 | Geoff Thorpe | 22 November 2003, 20:23:41 UTC | BN_div() cleanup: replace the use of BN_sub and BN_add with bn_sub_words and bn_add_words to avoid using fake bignums to window other bignums that can lead to corruption. This change allows all bignum tests to pass with BN_DEBUG and BN_DEBUG_RAND debugging and valgrind. NB: This should be tested on a few different architectures and configuration targets, as the bignum code this deals with is quite preprocessor (and assembly) sensitive. Submitted by: Nils Narsch Reviewed by: Geoff Thorpe, Ulf Moeller | 22 November 2003, 20:23:41 UTC |
| ec2179c | Geoff Thorpe | 21 November 2003, 21:42:35 UTC | Fix a small bug in str_copy: if more than one variable is replaced, make sure the current length is used to calculate the new buffer length instead of using the old length (prior to any variable substitution). Submitted by: Nils Larsch | 21 November 2003, 21:42:35 UTC |
| a8287a9 | Dr. Stephen Henson | 20 November 2003, 22:45:06 UTC | Give CRLDP its standard name. Max req -x509 use V1 if extensions section absent. | 20 November 2003, 22:45:06 UTC |
| ad5f0ed | Andy Polyakov | 20 November 2003, 19:10:36 UTC | hpux64-parisc2-gcc target added. Once it is verified, ./config should be modified to choose it instead of hpux64-parisc-gcc, which should then be removed. hpux64-parisc-cc is removed already now as redundant [in case you wonder, 64-bit HP-UX ABI *implies* PA-RISC2.0]. | 20 November 2003, 19:10:36 UTC |
| 0a4c8ba | Andy Polyakov | 20 November 2003, 18:33:20 UTC | ./config failed to correctly detect if gcc uses 64-bit ABI on HP-UX. PR: 772 | 20 November 2003, 18:33:20 UTC |
| 95de3d2 | Lutz Jänicke | 18 November 2003, 18:27:12 UTC | Make sure to initialize AES counters to obtain proper results. Submitted by: Kirill Kochetkov <kochet@ixbt.com> PR: #748 | 18 November 2003, 18:27:12 UTC |
| 31182ad | Ulf Möller | 16 November 2003, 19:33:31 UTC | re-enable the test, keeping the original method for RAND_pseudo_bytes which is used by BN_DEBUG_RAND Submitted by: Nils Larsch | 16 November 2003, 19:33:31 UTC |
| f35232e | Lutz Jänicke | 16 November 2003, 16:30:39 UTC | Catch error condition to prevent NULL pointer dereference. Submitted by: Goetz Babin-Ebell <babin-ebell@trustcenter.de> PR: #766 | 16 November 2003, 16:30:39 UTC |
| fda5e38 | Lutz Jänicke | 16 November 2003, 14:38:34 UTC | Provide ASFLAGS in the subdirectories handling assembler code. Submitted by: Tim Rice <tim@multitalents.net> PR: #735, #765 | 16 November 2003, 14:38:34 UTC |
| ac9c6e1 | Ulf Möller | 16 November 2003, 12:24:45 UTC | The x9.62 tests replace the PRNG with specific numbers, so don't run them if BN_DEBUG_RAND is defined. Also, fix another small bug. Submitted by: Nils Larsch | 16 November 2003, 12:24:45 UTC |
| 1a01733 | Ulf Möller | 15 November 2003, 08:37:50 UTC | BN_set_bit() etc should use "unsigned int". Keep it as is to avoid an API change, but check for negativ values. Submitted by: Nils Larsch | 15 November 2003, 08:37:50 UTC |
| d2cd461 | Richard Levitte | 14 November 2003, 14:06:40 UTC | Less restrictive debugging build. | 14 November 2003, 14:06:40 UTC |
| 9dde17e | Geoff Thorpe | 13 November 2003, 15:03:14 UTC | This rewrites two "for" loops in BN_rshift() - equality with zero is generally a more efficient comparison than comparing two integers, and the first of these two loops was off-by-one (copying one too many values). This change also removes a superfluous assignment that would set an unused word to zero (and potentially allow an overrun in some cases). Submitted by: Nils Larsch Reviewed by: Geoff Thorpe | 13 November 2003, 15:03:14 UTC |
| 37af03d | Geoff Thorpe | 10 November 2003, 18:09:18 UTC | General improvements to the ec_asn1.c code. This squashes at least one bug (where it was impossible to create an EC certificate with a compressed public key), and has some style improvements based on some comments from Steve Henson about use of the ASN1 macros. Submitted by: Nils Larsch Reviewed by: Geoff Thorpe | 10 November 2003, 18:09:18 UTC |
| f7a397c | Geoff Thorpe | 10 November 2003, 18:05:22 UTC | Avoid possible memory leaks in error-handling. Submitted by: Nils Larsch Reviewed by: Geoff Thorpe | 10 November 2003, 18:05:22 UTC |
| cd2e8a6 | Dr. Stephen Henson | 10 November 2003, 01:37:23 UTC | Print out GeneralizedTime and UTCTime in ASN1_STRING_print_ex(). | 10 November 2003, 01:37:23 UTC |
| d18b993 | Ulf Möller | 07 November 2003, 01:33:00 UTC | Geoff suggested a more succinct description for "top". | 07 November 2003, 01:33:00 UTC |
| e6e81c5 | Ulf Möller | 07 November 2003, 00:07:28 UTC | oops... the description of ->top was inaccurate (the example is correct though) | 07 November 2003, 00:07:28 UTC |
| f75abce | Geoff Thorpe | 06 November 2003, 23:24:44 UTC | This extends the debugging macros to use "pollution" during bn_correct_top(), previously only bn_check_top() did this. | 06 November 2003, 23:24:44 UTC |
| 18f62d4 | Geoff Thorpe | 06 November 2003, 23:13:04 UTC | Add debug-screening of input parameters to some functions I'd missed before. | 06 November 2003, 23:13:04 UTC |
| 5c0c228 | Geoff Thorpe | 06 November 2003, 23:11:07 UTC | Put more debug screening in BN_div() and correct a comment. | 06 November 2003, 23:11:07 UTC |
| 0ef85c7 | Geoff Thorpe | 05 November 2003, 19:30:29 UTC | This is a revert of my previous commit to "improve" the declaration of constant BIGNUMs. It turns out that this trips up different but equally useful compiler warnings to -Wcast-qual, and so wasn't worth the ugliness it created. (Thanks to Ulf for the forehead-slap.) | 05 November 2003, 19:30:29 UTC |
| 078dd1a | Ulf Möller | 05 November 2003, 17:28:59 UTC | typo in comment | 05 November 2003, 17:28:59 UTC |
| 2b96c95 | Ulf Möller | 05 November 2003, 17:28:25 UTC | cleanup as discussed with Geoff | 05 November 2003, 17:28:25 UTC |
| c5f1c7b | Ulf Möller | 05 November 2003, 17:27:13 UTC | Cygwin debugging | 05 November 2003, 17:27:13 UTC |
| d870740 | Geoff Thorpe | 04 November 2003, 22:54:49 UTC | Put the first stage of my bignum debugging adventures into CVS. This code is itself experimental, and in addition may cause execution to break on existing openssl "bugs" that previously were harmless or at least invisible. | 04 November 2003, 22:54:49 UTC |
| d8ec0dc | Geoff Thorpe | 04 November 2003, 00:51:32 UTC | Avoid some shadowed variable names. Submitted by: Nils Larsch | 04 November 2003, 00:51:32 UTC |
| c465e79 | Geoff Thorpe | 04 November 2003, 00:29:09 UTC | This is the least unacceptable way I've found for declaring the bignum data and structures as constant without having to cast away const at any point. There is still plenty of other code that makes gcc's "-Wcast-qual" unhappy, but crypto/bn/ is now ok. Purists are welcome to suggest alternatives. | 04 November 2003, 00:29:09 UTC |
| 933398f | Richard Levitte | 31 October 2003, 10:48:48 UTC | Engines are usually binary, and should therefore be in INSTALLTOP rather than OPENSSLDIR. | 31 October 2003, 10:48:48 UTC |
| cfd06a6 | Richard Levitte | 31 October 2003, 06:58:24 UTC | Let exit codes propagate from within for loops. | 31 October 2003, 06:58:24 UTC |
| a9fd78f | Geoff Thorpe | 31 October 2003, 01:35:16 UTC | bn_div() does some pretty nasty things with temporary variables, constructing BIGNUM structures with pointers offset into other bignums (among other things). This corrects some of it that is too plainly insane, and tries to ensure that bignums are normalised when passed to other functions. | 31 October 2003, 01:35:16 UTC |
| 5f747c7 | Geoff Thorpe | 30 October 2003, 01:07:56 UTC | When a BN_CTX is used for temporary workspace, the variables are sometimes left in an inconsistent state when they are released for later reuse. This change resets the BIGNUMs when they are released back to the context. | 30 October 2003, 01:07:56 UTC |
| c4db1a8 | Geoff Thorpe | 30 October 2003, 01:03:31 UTC | This fixes a couple of cases where an inconsistent BIGNUM could be passed as input to a function. | 30 October 2003, 01:03:31 UTC |
| f7939fc | Geoff Thorpe | 29 October 2003, 23:25:52 UTC | make update | 29 October 2003, 23:25:52 UTC |
| d531c90 | Geoff Thorpe | 29 October 2003, 23:25:34 UTC | Tighten up my compiler settings. | 29 October 2003, 23:25:34 UTC |
| aca95e0 | Geoff Thorpe | 29 October 2003, 22:55:19 UTC | Remove a line that was causing redundant declarations. Obtained from: Stephen Henson <steve@openssl.org> | 29 October 2003, 22:55:19 UTC |
| bc3c578 | Geoff Thorpe | 29 October 2003, 22:30:45 UTC | Copy-n-paste bug (don't mix variable declarations and code). This sets the callback structure just before it is needed. | 29 October 2003, 22:30:45 UTC |
| 06e4024 | Geoff Thorpe | 29 October 2003, 22:25:04 UTC | Oops, this file already had the "empty source file" workaround but it requires -DPEDANTIC and was hidden at the bottom of the file. This moves it to the top and removes the redundant declaration. | 29 October 2003, 22:25:04 UTC |
| 8087d8f | Geoff Thorpe | 29 October 2003, 20:55:03 UTC | Make md32_common.h friendlier to compiler warnings. Obtained from: Andy Polyakov <appro@openssl.org> | 29 October 2003, 20:55:03 UTC |
| 31166ec | Geoff Thorpe | 29 October 2003, 20:47:49 UTC | Some provisional bignum debugging has begun to detect inconsistent BIGNUM structures being passed in to or out of API functions, and this corrects a couple of cases found so far. Also, lop off a couple of bytes of white-space. | 29 October 2003, 20:47:49 UTC |
| 2754597 | Geoff Thorpe | 29 October 2003, 20:24:15 UTC | A general spring-cleaning (in autumn) to fix up signed/unsigned warnings. I have tried to convert 'len' type variable declarations to unsigned as a means to address these warnings when appropriate, but when in doubt I have used casts in the comparisons instead. The better solution (that would get us all lynched by API users) would be to go through and convert all the function prototypes and structure definitions to use unsigned variables except when signed is necessary. The proliferation of (signed) "int" for strictly non-negative uses is unfortunate. | 29 October 2003, 20:24:15 UTC |
| 2ce90b9 | Geoff Thorpe | 29 October 2003, 18:04:37 UTC | BN_CTX is opaque and the static initialiser BN_CTX_init() is not used except internally to the allocator BN_CTX_new(), as such this deprecates the use of BN_CTX_init() in the API. Moreover, the structure definition of BN_CTX is taken out of bn_lcl.h and moved into bn_ctx.c itself. NDEBUG should probably only be "forced" in the top-level configuration, but until it is I will avoid removing it from bn_ctx.c which might surprise people with massive slow-downs in their keygens. So I've left it in bn_ctx.c but tidied up the preprocessor logic a touch and made it more tolerant of debugging efforts. | 29 October 2003, 18:04:37 UTC |
| 4e952ae | Richard Levitte | 29 October 2003, 06:21:22 UTC | Removing those memcpy()s also took away the possibility for in and out to be the same. Therefore, the removed memcpy()s need to be restored. | 29 October 2003, 06:21:22 UTC |
| db59141 | Geoff Thorpe | 29 October 2003, 05:35:31 UTC | remove accidentally committed debugging cruft. | 29 October 2003, 05:35:31 UTC |
| 8a66d17 | Geoff Thorpe | 29 October 2003, 05:00:57 UTC | Remove an unnecessary cast that causes certain compilers (eg. mine) some confusion. Also silence a couple of signed/unsigned warnings. | 29 October 2003, 05:00:57 UTC |
| 2eeaa02 | Geoff Thorpe | 29 October 2003, 04:58:23 UTC | Remove redundant declaration. | 29 October 2003, 04:58:23 UTC |
| 8dc344c | Geoff Thorpe | 29 October 2003, 04:57:05 UTC | Relax some over-zealous constification that gave some lhash-based code no choice but to have to cast away "const" qualifiers from their prototypes. This does not remove constification restrictions from hash/compare callbacks, but allows destructor commands to be run over a tables' elements without bad casts. | 29 October 2003, 04:57:05 UTC |
| 6bcd3f9 | Geoff Thorpe | 29 October 2003, 04:42:29 UTC | Comments out some unimplemented functions instead of redeclaring them. | 29 October 2003, 04:42:29 UTC |
| 40f935f | Geoff Thorpe | 29 October 2003, 04:41:19 UTC | Avoid "empty source file" warnings. | 29 October 2003, 04:41:19 UTC |
| 0991f07 | Geoff Thorpe | 29 October 2003, 04:40:13 UTC | For whatever reason (compiler or header bugs), at least one commonly-used linux system (namely mine) chokes on our definitions and uses of the "HZ" symbol in crypto/tmdiff.[ch] and apps/speed.c as a "bad function cast" (when in fact there is no function casting involved at all). In both cases, it is easily worked around by not defining a cast into the macro and jiggling the expressions slightly. In addition - this highlights some cruft in openssl that needs sorting out. The tmdiff.h header is exported as part of the openssl API despite the fact that it is ugly as the driven sludge and not used anywhere in the library, applications, or utilities. More weird still, almost identical code exists in apps/speed.c though it looks to be slightly tweaked - so either tmdiff should be updated and used by speed.c, or it should be dumped because it's obviously not useful enough. Rather than removing it for now, I've changed the API for tmdiff to at least make sense. This involves taking the object type (MS_TM) from the implementation and using it in the header rather than using "char *" in the API and casting mercilessly in the code (ugh). If someone doesn't like "MS_TM" and the "ms_time_***" naming, by all means change it. This should be a harmless improvement, because the existing API is clearly not very useful (eg. we reimplement it rather than using it in our own utils). However, someone still needs to take a hack at consolidating speed.c and tmdiff.[ch] somehow. | 29 October 2003, 04:40:13 UTC |
| 2aaec9c | Geoff Thorpe | 29 October 2003, 04:14:08 UTC | Update any code that was using deprecated functions so that everything builds and links with OPENSSL_NO_DEPRECATED defined. | 29 October 2003, 04:14:08 UTC |
| 9d473aa | Geoff Thorpe | 29 October 2003, 04:06:50 UTC | When OPENSSL_NO_DEPRECATED is defined, deprecated functions are (or should be) precompiled out in the API headers. This change is to ensure that if it is defined when compiling openssl, the deprecated functions aren't implemented either. | 29 October 2003, 04:06:50 UTC |
| 6145b0b | Geoff Thorpe | 29 October 2003, 04:00:14 UTC | The "cryptodev" engine preprocessor logic used undefined symbols in comparisons. It's better not to allow this, because it gives false positives when using compiler warnings that detect mistyped symbols. | 29 October 2003, 04:00:14 UTC |
| 2a85f77 | Geoff Thorpe | 28 October 2003, 22:57:18 UTC | Add my own debug config target. | 28 October 2003, 22:57:18 UTC |
| 66b82f5 | Geoff Thorpe | 28 October 2003, 22:10:47 UTC | make update | 28 October 2003, 22:10:47 UTC |
| 12bdcea | Geoff Thorpe | 28 October 2003, 17:26:46 UTC | Ignore derived file. | 28 October 2003, 17:26:46 UTC |
| aea293e | Geoff Thorpe | 28 October 2003, 17:24:29 UTC | crypto/evp/evptests.txt is copied to tests/ rather than symlinked because of windows (see checkin 1.75 of crypto/evp/Makefile.ssl), so quiet cvs noise for the copied version. | 28 October 2003, 17:24:29 UTC |
| 8ad7e3a | Geoff Thorpe | 24 October 2003, 16:17:11 UTC | Remove duplicate prototypes have already been (correctly) added to rsa.h, as this is already included by x509.h anyway. | 24 October 2003, 16:17:11 UTC |
| 0b6956b | Richard Levitte | 15 October 2003, 09:00:14 UTC | Correct serious bug in AES-CBC decryption when the message length isn't a multiple of AES_BLOCK_SIZE. Optimize decryption of all complete blocks in AES-CBC by removing an unnecessary memcpy(). The error was notified by James Fernandes <jf210032@exchange.DAYTONOH.NCR.com>. The unnecessary memcpy() was found as an effect of investigating that error. | 15 October 2003, 09:00:14 UTC |
| 0bb6187 | Richard Levitte | 13 October 2003, 11:34:40 UTC | The object file is o_str.o, not o_str.c. Thanks to Peter Sylvester <Peter.Sylvester@EdelWeb.fr> for the notification. | 13 October 2003, 11:34:40 UTC |
| c5a5546 | Dr. Stephen Henson | 11 October 2003, 22:11:45 UTC | Add support for digested data PKCS#7 type. | 11 October 2003, 22:11:45 UTC |
| 77fe058 | Dr. Stephen Henson | 11 October 2003, 16:46:40 UTC | Simplify cipher and digest lookup in PKCS#7 code. | 11 October 2003, 16:46:40 UTC |
| 8d9086d | Dr. Stephen Henson | 10 October 2003, 23:40:47 UTC | New function to initialize a PKCS7 structure of type other. | 10 October 2003, 23:40:47 UTC |
| 0602abf | Dr. Stephen Henson | 10 October 2003, 23:31:53 UTC | Initialize digested data type in PKCS7_set_type(). | 10 October 2003, 23:31:53 UTC |
| caf044c | Dr. Stephen Henson | 10 October 2003, 23:25:43 UTC | Retrieve correct content to sign when the type is "other". | 10 October 2003, 23:25:43 UTC |
| a08ced7 | Dr. Stephen Henson | 10 October 2003, 23:07:24 UTC | Avoid warnings: add missing prototype, don't shadow. | 10 October 2003, 23:07:24 UTC |
| 83eb412 | Richard Levitte | 07 October 2003, 12:09:39 UTC | In realloc, don't destroy the old memory area if a new one couldn't be allocated. Notified by Daniel Lucq <daniel@lucq.org> | 07 October 2003, 12:09:39 UTC |
| 4d1c443 | Richard Levitte | 06 October 2003, 12:22:42 UTC | make update | 06 October 2003, 12:22:42 UTC |
