e711d13 | Richard Levitte | 16 March 2016, 17:21:17 UTC | Prepare for 1.1.0-pre4 release Reviewed-by: Emilia Käsper <emilia@openssl.org> | 16 March 2016, 17:21:17 UTC |
c521edc | Matt Caswell | 16 March 2016, 10:38:39 UTC | Some platforms provide getcontext() but it does not work Some platforms claim to be POSIX but their getcontext() implementation does not work. Therefore we update the ASYNC_is_capable() function to test for this. RT#4366 Reviewed-by: Richard Levitte <levitte@openssl.org> | 16 March 2016, 17:12:56 UTC |
685b6f2 | Richard Levitte | 16 March 2016, 15:50:18 UTC | When building DLLs, hack the library name in the .def file util/mkdef.pl assumes it knows what the resulting library name will be. Really, it shouldn't, but changing it will break classic native Windows builds, so we leave it for now and change the LIBRARY line externally when needed instead. Reviewed-by: Matt Caswell <matt@openssl.org> | 16 March 2016, 17:11:13 UTC |
8975fb6 | Richard Levitte | 16 March 2016, 14:32:44 UTC | DLL object files should not be built with /Zl" When building the DLLs, we depend on the correct default C RTL info. Reviewed-by: Matt Caswell <matt@openssl.org> | 16 March 2016, 17:11:01 UTC |
f527b6e | Richard Levitte | 16 March 2016, 13:58:17 UTC | Appveyor - make sure to actually build "shared" in the shared configuration Reviewed-by: Matt Caswell <matt@openssl.org> | 16 March 2016, 17:08:31 UTC |
8a0333c | Emilia Kasper | 16 March 2016, 14:06:01 UTC | Fix up CHANGES - Remove duplicate entry - Add author for SSL_CIPHER query functions - Note HKDF support in CHANGES and NEWS [ci skip] Reviewed-by: Richard Levitte <levitte@openssl.org> | 16 March 2016, 14:06:46 UTC |
c1ea997 | Matt Caswell | 16 March 2016, 11:16:11 UTC | We should use $SRCDIR in Makefiles Normally we always refer to source files relative to $SRCDIR in Makefiles. However the reference to unix-Makefile.tmpl was using a fully expanded absolute path. This can cause problems for Mingw. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> | 16 March 2016, 12:35:18 UTC |
68dc37c | Matt Caswell | 16 March 2016, 10:08:53 UTC | Disable AFALG when cross-compiling We don't currently support cross-compiling of the afalg engine. However we were failing to explicitly mark it as disabled during Configure leading to a failed build. Reviewed-by: Richard Levitte <levitte@openssl.org> | 16 March 2016, 10:08:53 UTC |
5427976 | Matt Caswell | 15 March 2016, 16:44:26 UTC | Fix a TLSProxy race condition TLSProxy starts s_server and specifies the number of client connects it should expect. After that s_server is supposed to close down automatically. However, if another test is then run then TLSProxy will start a new instance of s_server. If the previous instance hasn't closed down yet then the new instance can fail to bind to the socket. Reviewed-by: Richard Levitte <levitte@openssl.org> | 15 March 2016, 23:46:50 UTC |
2460c7f | Andy Polyakov | 15 March 2016, 22:39:07 UTC | poly1305/asm/poly1305-x86_64.pl: make it work with linux-x32. Reviewed-by: Richard Levitte <levitte@openssl.org> | 15 March 2016, 22:58:31 UTC |
0a86f66 | Emilia Kasper | 15 March 2016, 22:04:14 UTC | On Windows, page walking is known as __chkstk. Reviewed-by: Andy Polyakov <appro@openssl.org> | 15 March 2016, 22:56:23 UTC |
1bf80d9 | Emilia Kasper | 15 March 2016, 20:52:31 UTC | Explain *cough*-dows Reviewed-by: Andy Polyakov <appro@openssl.org> | 15 March 2016, 22:56:17 UTC |
4def90c | Richard Levitte | 15 March 2016, 21:16:35 UTC | Make the perl dependency post-processor into just one line Make doesn't always treat multiline quoted strings as nicely as one would wish. Reviewed-by: Andy Polyakov <appro@openssl.org> | 15 March 2016, 22:49:22 UTC |
29b28ee | Richard Levitte | 15 March 2016, 08:05:20 UTC | Not all shells understand ! In unix-Makefile.tmpl, this construction has been used a few times if ! something; then ... It seems, though, that some shells do not understand !, so these need to be changed. Reviewed-by: Rich Salz <rsalz@openssl.org> | 15 March 2016, 21:28:16 UTC |
08538fc | fbroda | 15 March 2016, 09:08:49 UTC | General verify options to openssl ts This commit adds the general verify options of ocsp, verify, cms, etc. to the openssl timestamping app as suggested by Stephen N. Henson in [openssl.org #4287]. The conflicting "-policy" option of "openssl ts" has been renamed to "-tspolicy". Documentation and tests have been updated. CAVE: This will break code, which currently uses the "-policy" option. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> | 15 March 2016, 17:42:53 UTC |
3ddd1d0 | Emilia Kasper | 15 March 2016, 14:37:51 UTC | Fix CRYPTO_THREAD_run_once return value checks Reviewed-by: Richard Levitte <levitte@openssl.org> | 15 March 2016, 16:59:09 UTC |
e58d910 | Richard Levitte | 15 March 2016, 14:30:43 UTC | Cygwin configs were missing thread_scheme settings, add them Reviewed-by: Matt Caswell <matt@openssl.org> | 15 March 2016, 14:38:11 UTC |
a4d8bcf | Richard Levitte | 15 March 2016, 13:06:34 UTC | Small typo OPENSSL_INIT_ONCE and OPENSSL_INIT_ONCE_STATIC_INIT are really CRYPTO_ONCE and CRYPTO_ONCE_STATIC_INIT. Reviewed-by: Rich Salz <rsalz@openssl.org> | 15 March 2016, 13:06:34 UTC |
3e19b07 | Richard Levitte | 15 March 2016, 13:05:35 UTC | static-engine is no longer an internal keyword, remove it from %disabled Reviewed-by: Rich Salz <rsalz@openssl.org> | 15 March 2016, 13:05:35 UTC |
ad83932 | Andy Polyakov | 14 March 2016, 17:04:21 UTC | Clarify NOTES.WIN. Reviewed-by: Richard Levitte <levitte@openssl.org> | 15 March 2016, 08:14:21 UTC |
580b557 | Dr. Stephen Henson | 14 March 2016, 16:45:51 UTC | Update and clarify ECDSA documentation. Reviewed-by: Richard Levitte <levitte@openssl.org> | 14 March 2016, 19:59:23 UTC |
c91a0a8 | Emilia Kasper | 14 March 2016, 11:21:44 UTC | Disable afalg when engine is disabled. Also make it possible to disable afalg separately. we still need to update config again Reviewed-by: Richard Levitte <levitte@openssl.org> | 14 March 2016, 16:03:53 UTC |
d1beebd | Richard Levitte | 14 March 2016, 15:52:54 UTC | Fix typo in manual, missing ending '>' Reviewed-by: Stephen Henson <steve@openssl.org> | 14 March 2016, 15:52:54 UTC |
d7a275e | Emilia Kasper | 14 March 2016, 11:47:47 UTC | Travis: build tests in BUILDONLY mode Reviewed-by: Richard Levitte <levitte@openssl.org> | 14 March 2016, 15:38:48 UTC |
74acf1c | Andy Polyakov | 14 March 2016, 12:42:48 UTC | config: fix HP-UX PA-RISC detection. Reviewed-by: Richard Levitte <levitte@openssl.org> | 14 March 2016, 13:41:35 UTC |
8d51db8 | Andy Polyakov | 11 March 2016, 15:47:02 UTC | s390x assembly pack: 32-bit fixups. Reviewed-by: Richard Levitte <levitte@openssl.org> | 14 March 2016, 12:52:34 UTC |
6bfb7db | Andy Polyakov | 13 March 2016, 20:54:49 UTC | build.info/Makefile.in: Itanium fixups. Reviewed-by: Richard Levitte <levitte@openssl.org> | 14 March 2016, 12:50:43 UTC |
d43a8fd | Andy Polyakov | 13 March 2016, 20:49:15 UTC | engines/Makefile.in: some [older] shell complain about 'for i ;', but not if there is reference to empty variable. Reviewed-by: Richard Levitte <levitte@openssl.org> | 14 March 2016, 12:50:43 UTC |
58a8fc2 | Matt Caswell | 14 March 2016, 10:34:59 UTC | Fix the init cleanup order There are internal dependencies between the various cleanup functions. This re-orders things to try and get that right. Reviewed-by: Richard Levitte <levitte@openssl.org> | 14 March 2016, 10:54:37 UTC |
b10cdcc | Matt Caswell | 14 March 2016, 10:26:28 UTC | Add some missing cleanup calls to de-init OBJ_cleanup() doesn't always get called from EVP_cleanup() so needs to be explicitly called in de-init. Also BIO_sock_cleanup() also needs to be called. Reviewed-by: Richard Levitte <levitte@openssl.org> | 14 March 2016, 10:54:37 UTC |
a87c159 | Richard Levitte | 13 March 2016, 10:31:04 UTC | Fix freeze in config's interrupt trap with some shells With bash and zsh, the trap on the 5 second read does respond, but doesn't break out of the read. What's worse is that it takes away the 5 second timer, and therefore has the read hang indefinitely and (almost) unbreakable. Having the trap do 'exit 0' after reseting the tty params has it break out of read and continue with the configuration. Other shells do not appear to have the issue described here, but neither does the extra 'exit 0' appear to harm them. Reviewed-by: Andy Polyakov <appro@openssl.org> | 14 March 2016, 10:24:55 UTC |
9f519ad | Richard Levitte | 14 March 2016, 09:03:14 UTC | Enforce the demand for Perl 5.10.0 as a minimum. Reviewed-by: Andy Polyakov <appro@openssl.org> | 14 March 2016, 10:21:35 UTC |
01d9997 | Richard Levitte | 14 March 2016, 09:02:13 UTC | Fix a few Configure errors Reviewed-by: Andy Polyakov <appro@openssl.org> | 14 March 2016, 10:21:35 UTC |
bae26b5 | Dr. Stephen Henson | 14 March 2016, 00:23:13 UTC | Document X509_get_serialNumber and X509_set_serialNumber. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Viktor Dukhovni <viktor@openssl.org> | 14 March 2016, 00:23:13 UTC |
b36a2ef | Dr. Stephen Henson | 13 March 2016, 15:49:09 UTC | Add EVP_PKEY documentation. Document EVP_PKEY_id() and EVP_PKEY_base_id(). Reviewed-by: Viktor Dukhovni <viktor@openssl.org> | 13 March 2016, 19:01:42 UTC |
e7c8caf | Richard Levitte | 13 March 2016, 13:54:51 UTC | Change an function macro for ERR match the function it's used in. Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 13 March 2016, 13:54:51 UTC |
6d505f2 | Richard Levitte | 13 March 2016, 10:07:12 UTC | Complete incomplete makefile variable referenses A couple of '$(PERLASM_SCHEM' had sneaked in. Reviewed-by: Tim Hudson <tjh@openssl.org> | 13 March 2016, 10:07:12 UTC |
4c1cf7e | Richard Levitte | 12 March 2016, 11:42:49 UTC | Collect the names of generated files and clean them away at target clean: Reviewed-by: Rich Salz <rsalz@openssl.org> | 12 March 2016, 23:03:48 UTC |
f425f9d | Richard Levitte | 12 March 2016, 08:46:28 UTC | Add $(LIB_CFLAGS) for any build.info generator that uses $(CFLAGS) The reason to do so is that some of the generators detect PIC flags like -fPIC and -KPIC, and those are normally delivered in LD_CFLAGS. Reviewed-by: Rich Salz <rsalz@openssl.org> | 12 March 2016, 23:02:55 UTC |
8a0a3d2 | Richard Levitte | 12 March 2016, 09:46:14 UTC | Use single quotes rather than double quotes when needed When passing down values to Makefile.shared, do so with single quotes as much as possible to avoid having the shell create a mess of quotes. Reviewed-by: Rich Salz <rsalz@openssl.org> | 12 March 2016, 23:02:55 UTC |
bbd9a50 | Richard Levitte | 12 March 2016, 08:38:20 UTC | Harmonize Unix Makefile template with Windows dito The variable SHARED_CFLAGS and SHARD_LDFLAGS were used in the Unix template because they normally contain options used when building "shared". The Windows template, on the other hand, uses LIB_CFLAGS, to express the intended use of those flags rather than their content. The Windows template still used SHARED_LDFLAGS, which seems inconsistent. To harmonize the two, any SHARED_CFLAGS gets renamed to LIB_CFLAGS and SHARED_LDFLAGS to LIB_LDFLAGS. That makes the intent consistent along with BIN_{C,LD}FLAGS and DSO_{C,LD}FLAGS. Finally, make sure to pass down $(LIB_CFLAGS) or $(DSO_CFLAGS) along with $(CFLAGS) when using Makefile.shared. Reviewed-by: Rich Salz <rsalz@openssl.org> | 12 March 2016, 23:02:55 UTC |
8cab4e9 | Emilia Kasper | 12 March 2016, 19:46:13 UTC | Fix memory leak in library deinit ENGINE_cleanup calls CRYPTO_free_ex_data and therefore, CRYPTO_cleanup_all_ex_data - which cleans up the method pointers - must run after ENGINE_cleanup. Additionally, don't needlessly initialize the EX_CALLBACKS stack during e.g. CRYPTO_free_ex_data. The only time this is actually needed is when reserving the first ex data index. Specifically, since sk_num returns -1 on NULL input, the rest of the code already handles a NULL method stack correctly. Reviewed-by: Rich Salz <rsalz@openssl.org> | 12 March 2016, 20:47:01 UTC |
36cc139 | Rich Salz | 10 March 2016, 15:37:31 UTC | Add doc on when to use SCT callback. With help from Viktor. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> | 12 March 2016, 18:02:34 UTC |
4b85744 | Emilia Kasper | 12 March 2016, 16:18:25 UTC | Workaround for false -Warray-bounds in Travis ccache + clang produces a false strcmp warning, see https://llvm.org/bugs/show_bug.cgi?id=20144 Since this only happens with ccache and --strict-warnings, and only with certain versions of glibc / clang, disabling ccache is a reasonable short-term workaround. Reviewed-by: Richard Levitte <levitte@openssl.org> | 12 March 2016, 16:57:01 UTC |
e4ad076 | Emilia Kasper | 11 March 2016, 20:13:19 UTC | Fix no-comp build Reviewed-by: Matt Caswell <matt@openssl.org> | 12 March 2016, 15:21:33 UTC |
6f58da8 | Rich Salz | 12 March 2016, 01:36:33 UTC | Fix build break; add function declaration Reviewed-by: Richard Levitte <levitte@openssl.org> | 12 March 2016, 01:36:33 UTC |
0a705ce | Richard Levitte | 12 March 2016, 01:06:55 UTC | When creating directory specs, use srctop_dir rather than srctop_file. While insignificant on Unix like systems, this is significant on systems like VMS. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> | 12 March 2016, 01:09:05 UTC |
ef75444 | Richard Levitte | 12 March 2016, 00:06:48 UTC | Avoid sed for dependency post-processing It turns out that different sed implementations treat -i differently to cause issues. make it simpler by avoiding it entirely and give perl the trust to be consistent enough. Reviewed-by: Rich Salz <rsalz@openssl.org> | 12 March 2016, 00:15:12 UTC |
239b84e | Richard Levitte | 11 March 2016, 18:22:58 UTC | Because bn_expand2 is declared non-static, it must not be static That doesn't change even to make a dummy to hide its unavailability. Reviewed-by: Rich Salz <rsalz@openssl.org> | 12 March 2016, 00:13:18 UTC |
c3caf76 | Matt Caswell | 11 March 2016, 21:05:02 UTC | Remove some dead code from 1999 Reviewed-by: Richard Levitte <levitte@openssl.org> | 11 March 2016, 21:32:13 UTC |
8116107 | Matt Caswell | 11 March 2016, 16:47:42 UTC | Don't clobber the last error On Windows we call WSAGetLastError() to find out the last error that happened on a socket operation. We use this to find out whether we can retry the operation or not. You are supposed to call this immediately however in a couple of places we logged an error first. This can end up making other Windows system calls to get the thread local error state. Sometimes that can clobber the error code, so if you call WSAGetLastError() later on you get a spurious response and the socket operation looks like a fatal error. Really we shouldn't be logging an error anyway if its a retryable issue. Otherwise we could end up with stale errors on the error queue. Reviewed-by: Richard Levitte <levitte@openssl.org> | 11 March 2016, 21:32:13 UTC |
642befa | Mat | 11 March 2016, 19:20:20 UTC | removed extra define verified that build succeeds without the extra define Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 19:34:26 UTC |
0a03652 | Mat | 11 March 2016, 17:26:57 UTC | Fix no-blake2 for Windows classic build Fix no-blake2 for Windows classic build Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 19:34:26 UTC |
bf8bdbc | Dr. Stephen Henson | 11 March 2016, 17:41:24 UTC | make update Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 17:41:24 UTC |
a6eb1ce | Dr. Stephen Henson | 10 March 2016, 15:04:46 UTC | Make X509_SIG opaque. Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 17:40:47 UTC |
bb26842 | Richard Levitte | 11 March 2016, 12:25:48 UTC | Some sed implementations are not greedy enough, use perl instead The issue is demonstrated as follows: On Linux: $ echo ': foo.h /usr/include/stddef.h bar.h' | sed -e 's/ \/\(\\.\|[^ ]\)*//g' : foo.h bar.h On MacOS X: $ echo ': foo.h /usr/include/stddef.h bar.h' | sed -e 's/ \/\(\\.\|[^ ]\)*//g' : foo.husr/include/stddef.h bar.h Perl is more consistent: On Linux: $ echo ': foo.h /usr/include/stddef.h bar.h' | perl -pe 's/ \/(\\.|[^ ])*//g;' : foo.h bar.h On MacOS X: $ echo ': foo.h /usr/include/stddef.h bar.h' | perl -pe 's/ \/(\\.|[^ ])*//g;' : foo.h bar.h Reviewed-by: Andy Polyakov <appro@openssl.org> | 11 March 2016, 16:41:43 UTC |
178da24 | Rich Salz | 11 March 2016, 15:38:45 UTC | Make update to catch function renames. Reviewed-by: Emilia Käsper <emilia@openssl.org> | 11 March 2016, 16:24:56 UTC |
53a5167 | Kurt Roeckx | 11 March 2016, 00:19:43 UTC | Use unsigned int instead of just unsigned. Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 15:39:10 UTC |
a574108 | Kurt Roeckx | 11 March 2016, 00:06:51 UTC | Save leaf_node and node_offset as character array They are not numbers in the machine byte order. Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 15:39:10 UTC |
208527a | Kurt Roeckx | 09 March 2016, 23:49:55 UTC | Review comments Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 15:39:10 UTC |
2d0b441 | Bill Cox | 09 March 2016, 22:08:31 UTC | Add blake2 support. Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 15:39:10 UTC |
40f43f8 | Dr. Stephen Henson | 10 March 2016, 14:24:39 UTC | move DSA_SIG definition into C source file Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 14:53:50 UTC |
ee61919 | Andy Polyakov | 11 March 2016, 12:44:46 UTC | crypto/*/build.info: make it work on ARM platforms. Reviewed-by: Richard Levitte <levitte@openssl.org> | 11 March 2016, 14:30:57 UTC |
12940f0 | Andy Polyakov | 11 March 2016, 11:04:15 UTC | crypto/*/build.info: SPARC-specific fixups. Reviewed-by: Richard Levitte <levitte@openssl.org> | 11 March 2016, 14:29:55 UTC |
0218fc3 | Andy Polyakov | 11 March 2016, 10:55:44 UTC | Configurations/unix-Makefile.tmpl: don't leave empty .s files behind. If pre-processor failed, an empty .s file could be left behind, which could get successfully compiled if one simply re-ran make and cause linking failures. Not anymore. Remove even intermediate .S in case of pre-processor failure. Reviewed-by: Richard Levitte <levitte@openssl.org> | 11 March 2016, 14:29:49 UTC |
d0db7ee | Andy Polyakov | 11 March 2016, 11:33:59 UTC | Configure: remove dependency on 'head'. Reviewed-by: Richard Levitte <levitte@openssl.org> | 11 March 2016, 14:26:55 UTC |
680ddc9 | Rob Percival | 10 March 2016, 23:26:41 UTC | constify CT_POLICY_EVAL_CTX getters Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 14:06:04 UTC |
b536958 | Rob Percival | 10 March 2016, 23:10:02 UTC | Surround ctx_set_ctlog_list_file() with #ifndef OPENSSL_NO_CT Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 14:05:46 UTC |
ad87a3d | Matt Caswell | 11 March 2016, 13:50:55 UTC | Suppress CT warnings in test_ssl Running test_ssl with HARNESS_VERBOSE results in lots of spurious warnings about an inability to load the CT config file. This fixes it. Reviewed-by: Richard Levitte <levitte@openssl.org> | 11 March 2016, 13:52:26 UTC |
39dbb99 | Richard Levitte | 11 March 2016, 10:38:14 UTC | Avoid getting unresolved referense to bn_expand2 in test/bntest.c Issue identified on Solaris by Erik Forsberg <erik@efca.com> Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 13:48:26 UTC |
773fd0b | Matt Caswell | 11 March 2016, 09:52:52 UTC | Call CONF_modules_free() before ENGINE_cleanup() in auto-deinit During auto de-init we were calling ENGINE_cleanup(), and then later CONF_modules_free(). However the latter function can end up calling engine code, which can lead to a use of the global_engine_lock after it has already been freed. Therefore we should swap the calling order of these two functions. Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 March 2016, 13:36:57 UTC |
7162742 | Mat | 11 March 2016, 03:52:32 UTC | Fix no-rmd160 classic Windows build no-ripemd was unified a while ago but the change was not done in mk1mf.pl. This commit changes the no-ripemd string to no-rmd160 which fixes the no-rmd160 classic build. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> | 11 March 2016, 13:27:15 UTC |
0069806 | Richard Levitte | 11 March 2016, 11:58:15 UTC | Don't build dynamic engines unless configured "shared" Experience has shown that dynamic engines with their own copy of libcrypto is problematic, so we disable that possibility. Reviewed-by: Matt Caswell <matt@openssl.org> | 11 March 2016, 11:58:15 UTC |
987dbc7 | Richard Levitte | 11 March 2016, 08:26:49 UTC | Harmonise the two methods to generate dependency files One of them didn't clean away .d.tmp files properly. The other would overwrite the .d files unconditionally, thereby causing a possibly unnecessary dependency rebuild, which touches the date of Makefile, which causes a possibly unnecessary rebuild of buildinf.h and everything that depends on that. Reviewed-by: Andy Polyakov <appro@openssl.org> | 11 March 2016, 10:19:50 UTC |
d595769 | Matt Caswell | 10 March 2016, 11:05:47 UTC | More tweaks to the installation instructions A few things were out of date and a few things were missing. Also some formatting updates. Reviewed-by: Richard Levitte <levitte@openssl.org> | 11 March 2016, 10:00:39 UTC |
a5aa63a | Richard Levitte | 10 March 2016, 23:49:47 UTC | Fix some assembler generating scripts for better unification Some of these scripts would recognise an output parameter if it looks like a file path. That works both in both the classic and new build schemes. Some fo these scripts would only recognise it if it's a basename (i.e. no directory component). Those need to be corrected, as the output parameter in the new build scheme is more likely to contain a directory component than not. Reviewed-by: Andy Polyakov <appro@openssl.org> | 10 March 2016, 23:54:31 UTC |
603358d | Richard Levitte | 10 March 2016, 20:55:12 UTC | Add include directory options for assembler files that include from crypto/ A few were missed in the previous commit. Closes RT#4412 Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 21:00:27 UTC |
0d4d5ab | Rob Percival | 10 March 2016, 19:49:34 UTC | check reviewer --reviewer=emilia Use SSL_get_SSL_CTX instead of passing SSL_CTX to s_client.c:print_stuff Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 19:53:04 UTC |
49e5db0 | Rob Percival | 10 March 2016, 18:21:40 UTC | check reviewer --reviewer=emilia Pass entire CTLOG_STORE to SCT_print, rather than just the SCT's CTLOG SCT_print now looks up the correct CT log for you. Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 19:53:04 UTC |
8359b57 | Rob Percival | 10 March 2016, 18:17:23 UTC | check reviewer --reviewer=emilia Remove 'log' field from SCT and related accessors In order to still have access to an SCT's CTLOG when calling SCT_print, SSL_CTX_get0_ctlog_store has been added. Improved documentation for some CT functions in openssl/ssl.h. Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 19:53:04 UTC |
f0667b1 | Richard Levitte | 10 March 2016, 19:05:52 UTC | Add include directory options for assembler files that include from crypto/ Closes RT#4406 Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 19:30:47 UTC |
fb04434 | Richard Levitte | 10 March 2016, 18:34:21 UTC | In the recipe using "makedepend", make sure the object file extension is there Reviewed-by: Stephen Henson <steve@openssl.org> | 10 March 2016, 19:13:01 UTC |
39affe1 | Richard Levitte | 10 March 2016, 18:33:11 UTC | Configure - don't trust $1 to stick around, save its value away Reviewed-by: Stephen Henson <steve@openssl.org> | 10 March 2016, 19:13:01 UTC |
256ed96 | Matt Caswell | 10 March 2016, 15:17:20 UTC | Fix a memory leak in the afalg engine The AFALG engine created a global EVP_CIPHER instance but was not freeing it up when the engine was destroyed. Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 15:17:20 UTC |
b33c5ff | Richard Levitte | 10 March 2016, 13:20:50 UTC | Harmonize the option processing in 'config' and 'config.com' The help text for -d in 'config' was aged, and the option processing in 'config.com' was just different. This harmonizes 'config.com' with the instructions in INSTALL and both current reality. Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 13:20:50 UTC |
3415c71 | Richard Levitte | 10 March 2016, 00:51:53 UTC | Add cleaning targets to Configurations/windows-makefile.tmpl Reviewed-by: Matt Caswell <matt@openssl.org> | 10 March 2016, 11:59:53 UTC |
03f880e | Richard Levitte | 10 March 2016, 10:29:08 UTC | The typedef ECPARAMETERS is already defined, don't define it anew Reviewed-by: Matt Caswell <matt@openssl.org> | 10 March 2016, 10:29:08 UTC |
ffbc5b5 | David Woodhouse | 20 February 2016, 15:07:32 UTC | Allow OPENSSL_NO_SOCK in e_os.h even for non-Windows/DOS platforms UEFI needs this too. Don't keep it only in the Windows/DOS ifdef block. This is a fixed version of what was originally commit 963bb62195 and subsequently reverted in commit 37b1f8bd62. Somewhere along the way, the Windows/DOS ifdef actually got removed, leaving it just broken. It should have been turned into an #elif, not removed. This one correctly changes the logic from # if WINDOWS|DOS # if OPENSSL_NO_SOCK ... no-sock ... # elif !DJGPP ... native windows ... to # if OPENSSL_NO_SOCK ... no-sock ... # elif WINDOWS|DOS # if !DJGPP ... native windows ... Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> | 10 March 2016, 09:56:23 UTC |
6a7de8e | Matt Caswell | 10 March 2016, 09:21:23 UTC | Remove a missed item from the old thread API A line from cryptlib.h was missed during the old Thread API removal. This breaks no-deprecated builds. Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 09:29:42 UTC |
1e45206 | Matt Caswell | 10 March 2016, 09:20:06 UTC | Mark SRP_VBASE_get_by_user() as deprecated The function SRP_VBASE_get_by_user() is declared as deprecated but the implementation was not. Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 09:29:42 UTC |
0f1d814 | Matt Caswell | 10 March 2016, 09:18:50 UTC | No need to call EVP_CIPHER_CTX_init after EVP_CIPHER_CTX_new The afalgtest was unnecessarily initing an EVP_CIPHER_CTX. It is not needed and is deprecated. Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 09:18:50 UTC |
d460572 | Richard Levitte | 10 March 2016, 08:04:09 UTC | Pass down inclusion directories to source file generators The source file generators sometimes use $(CC) to post-process generated source, and getting the inclusion directories may be necessary at times, so we pass them down. RT#4406 Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 09:02:29 UTC |
8cffddc | Richard Levitte | 10 March 2016, 07:36:57 UTC | Travis - add missing semi-colon Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 09:00:00 UTC |
3253927 | Todd Short | 05 March 2016, 12:29:10 UTC | Update .gitignore to ignore all cscope files Signed-off-by: Rich Salz <rsalz@akamai.com> Reviewed-by: Richard Levitte <levitte@openssl.org> | 10 March 2016, 01:59:21 UTC |
c54bae9 | Viktor Szakats | 09 March 2016, 14:38:06 UTC | remove ms/.rnd and add it to .gitignore Signed-off-by: Rich Salz <rsalz@akamai.com> Reviewed-by: Richard Levitte <levitte@openssl.org> | 10 March 2016, 01:58:32 UTC |
599eccf | Rich Salz | 10 March 2016, 01:56:43 UTC | RT3676 add: Export ASN.1 DHparams Reviewed-by: Dr. Stephen Henson <steve@openssl.org> | 10 March 2016, 01:58:08 UTC |
a70ca74 | Richard Levitte | 10 March 2016, 01:14:55 UTC | Travis - don't use ccache with cross compiles Although theoretically possible, Configure doesn't treat CC variable set like this very well: CC="ccache i686-w64-mingw32-gcc" Also, this Travis script doesn't recognise the possibility either. Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 01:53:41 UTC |
a1673e1 | Benjamin Kaduk | 08 March 2016, 22:44:57 UTC | Avoid negative array index in BIO_debug_callback() BIO_snprintf() can return -1 on truncation (and overflow as of commit 9cb177301fdab492e4cfef376b28339afe3ef663). Though neither can realistically occur while printing a pointer and short fixed string into a buffer of length 256, the analysis to confirm that this the case goes somewhat far up the call chain, and not all static analyzers can successfully follow the chain of logic. It's easy enough to clamp the returned length to be nonnegative before continuing, which appeases the static analyzer and does not harm the subsequent code. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 01:52:19 UTC |
80e8fdb | Benjamin Kaduk | 08 March 2016, 21:53:49 UTC | CT: check some GeneralizedTime return values Some of the ASN.1 routines for the GeneralizedTime type can return errors; check for these and do not continue past failure, so as to appease coverity. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 01:52:19 UTC |
b805b44 | Richard Levitte | 10 March 2016, 00:58:27 UTC | When configured "shared", don't build static libraries on Windows The reason for this is that the static libraries and the DLL import libraries are named the same on Windows. When configured "shared", the static libraries are unused anyway. Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 March 2016, 01:51:50 UTC |