Skip to main content
Revision e88dfd5ee50f9d934edd966369339ee5573c67d4 authored by erbsland-dev on 10 September 2024, 19:24:59 UTC, committed by Tomas Mraz on 13 September 2024, 08:13:32 UTC
Add Missing Error Messages for AES-OCB Tag Length Validation
Related to #8331
Addressing found issues by adding specific error messages to improve
feedback when tag length checks fail for the `EVP_CTRL_AEAD_SET_TAG`
parameter in the AES-OCB algorithm.

- Added PROV_R_INVALID_TAG_LENGTH error to indicate when the current tag
  length exceeds the maximum tag length of the algorithm.
- Added `PROV_R_INVALID_TAG_LENGTH` error to indicate when the current tag
  length in the context does not match a custom tag length provided as
  a parameter.
- Added `ERR_R_PASSED_INVALID_ARGUMENT` error to handle cases where an
  invalid pointer is passed in encryption mode.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25425)

(cherry picked from commit 645edf50f0274448174d9739543bf01b1708b2f5)
1 parent 1727cbb
Raw File
simpledynamic.c
/*
 * Copyright 2016-2021 The OpenSSL Project Authors. All Rights Reserved.
 *
 * Licensed under the Apache License 2.0 (the "License").  You may not use
 * this file except in compliance with the License.  You can obtain a copy
 * in the file LICENSE in the source distribution or at
 * https://www.openssl.org/source/license.html
 */

#include <string.h>
#include <stdlib.h>              /* For NULL */
#include <openssl/macros.h>      /* For NON_EMPTY_TRANSLATION_UNIT */
#include <openssl/e_os2.h>
#include "simpledynamic.h"

#if defined(DSO_DLFCN) || defined(DSO_VMS)

int sd_load(const char *filename, SD *lib, int type)
{
    int dl_flags = type;
#ifdef _AIX
    if (filename[strlen(filename) - 1] == ')')
        dl_flags |= RTLD_MEMBER;
#endif
    *lib = dlopen(filename, dl_flags);
    return *lib == NULL ? 0 : 1;
}

int sd_sym(SD lib, const char *symname, SD_SYM *sym)
{
    *sym = dlsym(lib, symname);
    return *sym != NULL;
}

int sd_close(SD lib)
{
    return dlclose(lib) != 0 ? 0 : 1;
}

const char *sd_error(void)
{
    return dlerror();
}

#elif defined(DSO_WIN32)

int sd_load(const char *filename, SD *lib, ossl_unused int type)
{
    *lib = LoadLibraryA(filename);
    return *lib == NULL ? 0 : 1;
}

int sd_sym(SD lib, const char *symname, SD_SYM *sym)
{
    *sym = (SD_SYM)GetProcAddress(lib, symname);
    return *sym != NULL;
}

int sd_close(SD lib)
{
    return FreeLibrary(lib) == 0 ? 0 : 1;
}

const char *sd_error(void)
{
    static char buffer[255];

    buffer[0] = '\0';
    FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM, NULL, GetLastError(), 0,
                   buffer, sizeof(buffer), NULL);
    return buffer;
}

#else

NON_EMPTY_TRANSLATION_UNIT

#endif
back to top