Skip to main content
Revision e88dfd5ee50f9d934edd966369339ee5573c67d4 authored by erbsland-dev on 10 September 2024, 19:24:59 UTC, committed by Tomas Mraz on 13 September 2024, 08:13:32 UTC
Add Missing Error Messages for AES-OCB Tag Length Validation
Related to #8331
Addressing found issues by adding specific error messages to improve
feedback when tag length checks fail for the `EVP_CTRL_AEAD_SET_TAG`
parameter in the AES-OCB algorithm.

- Added PROV_R_INVALID_TAG_LENGTH error to indicate when the current tag
  length exceeds the maximum tag length of the algorithm.
- Added `PROV_R_INVALID_TAG_LENGTH` error to indicate when the current tag
  length in the context does not match a custom tag length provided as
  a parameter.
- Added `ERR_R_PASSED_INVALID_ARGUMENT` error to handle cases where an
  invalid pointer is passed in encryption mode.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25425)

(cherry picked from commit 645edf50f0274448174d9739543bf01b1708b2f5)
1 parent 1727cbb
Raw File
threadstest_fips.c
/*
 * Copyright 2021 The OpenSSL Project Authors. All Rights Reserved.
 *
 * Licensed under the Apache License 2.0 (the "License").  You may not use
 * this file except in compliance with the License.  You can obtain a copy
 * in the file LICENSE in the source distribution or at
 * https://www.openssl.org/source/license.html
 */

#if defined(_WIN32)
# include <windows.h>
#endif

#include "testutil.h"
#include "threadstest.h"

static int success;

static void thread_fips_rand_fetch(void)
{
    EVP_MD *md;

    if (!TEST_true(md = EVP_MD_fetch(NULL, "SHA2-256", NULL)))
        success = 0;
    EVP_MD_free(md);
}

static int test_fips_rand_leak(void)
{
    thread_t thread;

    success = 1;

    if (!TEST_true(run_thread(&thread, thread_fips_rand_fetch)))
        return 0;
    if (!TEST_true(wait_for_thread(thread)))
        return 0;
    return TEST_true(success);
}

int setup_tests(void)
{
    /*
     * This test MUST be run first.  Once the default library context is set
     * up, this test will always pass.
     */
    ADD_TEST(test_fips_rand_leak);
    return 1;
}
back to top