Revision eba8bf485a81541ad25a685f13f00a862cc371a8 authored by Hanno Böck on 11 May 2015, 10:33:37 UTC, committed by Matt Caswell on 13 May 2015, 14:28:48 UTC
The function obj_cmp() (file crypto/objects/obj_dat.c) can in some situations call memcmp() with a null pointer and a zero length. This is invalid behaviour. When compiling openssl with undefined behaviour sanitizer (add -fsanitize=undefined to compile flags) this can be seen. One example that triggers this behaviour is the pkcs7 command (but there are others, e.g. I've seen it with the timestamp function): apps/openssl pkcs7 -in test/testp7.pem What happens is that obj_cmp takes objects of the type ASN1_OBJECT and passes their ->data pointer to memcmp. Zero-sized ASN1_OBJECT structures can have a null pointer as data. RT#3816 Signed-off-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 2b8dc08b74fc3c6d4c2fc855cc23bac691d985be)
1 parent 464774d
| File | Mode | Size |
|---|---|---|
| MacOS | ||
| Netware | ||
| VMS | ||
| apps | ||
| bugs | ||
| certs | ||
| crypto | ||
| demos | ||
| doc | ||
| engines | ||
| include | ||
| ms | ||
| os2 | ||
| perl | ||
| shlib | ||
| ssl | ||
| test | ||
| times | ||
| tools | ||
| util | ||
| .cvsignore | -rw-r--r-- | 193 bytes |
| .gitignore | -rw-r--r-- | 1.7 KB |
| ACKNOWLEDGMENTS | -rw-r--r-- | 1.0 KB |
| CHANGES | -rw-r--r-- | 455.6 KB |
| CHANGES.SSLeay | -rw-r--r-- | 41.7 KB |
| Configure | -rwxr-xr-x | 108.7 KB |
| FAQ | -rw-r--r-- | 45.7 KB |
| GitConfigure | -rwxr-xr-x | 207 bytes |
| GitMake | -rwxr-xr-x | 81 bytes |
| INSTALL | -rw-r--r-- | 14.3 KB |
| INSTALL.DJGPP | -rw-r--r-- | 2.0 KB |
| INSTALL.MacOS | -rw-r--r-- | 3.2 KB |
| INSTALL.NW | -rw-r--r-- | 18.4 KB |
| INSTALL.OS2 | -rw-r--r-- | 744 bytes |
| INSTALL.VMS | -rw-r--r-- | 10.7 KB |
| INSTALL.W32 | -rw-r--r-- | 11.6 KB |
| INSTALL.W64 | -rw-r--r-- | 2.1 KB |
| INSTALL.WCE | -rw-r--r-- | 3.2 KB |
| LICENSE | -rw-r--r-- | 6.1 KB |
| Makefile.org | -rw-r--r-- | 23.6 KB |
| Makefile.shared | -rw-r--r-- | 21.4 KB |
| NEWS | -rw-r--r-- | 30.1 KB |
| PROBLEMS | -rw-r--r-- | 8.5 KB |
| README | -rw-r--r-- | 7.7 KB |
| README.ASN1 | -rw-r--r-- | 7.5 KB |
| README.ENGINE | -rw-r--r-- | 15.7 KB |
| TABLE | -rw-r--r-- | 171.9 KB |
| config | -rwxr-xr-x | 28.4 KB |
| e_os.h | -rw-r--r-- | 24.7 KB |
| e_os2.h | -rw-r--r-- | 10.5 KB |
| install.com | -rw-r--r-- | 3.6 KB |
| makevms.com | -rwxr-xr-x | 39.2 KB |
| openssl.doxy | -rw-r--r-- | 137 bytes |
| openssl.spec | -rw-r--r-- | 7.7 KB |
Computing file changes ...
