| f5c7f5d | Matt Caswell | 30 June 2016, 12:17:08 UTC | Fix DTLS buffered message DoS attack DTLS can handle out of order record delivery. Additionally since handshake messages can be bigger than will fit into a single packet, the messages can be fragmented across multiple records (as with normal TLS). That means that the messages can arrive mixed up, and we have to reassemble them. We keep a queue of buffered messages that are "from the future", i.e. messages we're not ready to deal with yet but have arrived early. The messages held there may not be full yet - they could be one or more fragments that are still in the process of being reassembled. The code assumes that we will eventually complete the reassembly and when that occurs the complete message is removed from the queue at the point that we need to use it. However, DTLS is also tolerant of packet loss. To get around that DTLS messages can be retransmitted. If we receive a full (non-fragmented) message from the peer after previously having received a fragment of that message, then we ignore the message in the queue and just use the non-fragmented version. At that point the queued message will never get removed. Additionally the peer could send "future" messages that we never get to in order to complete the handshake. Each message has a sequence number (starting from 0). We will accept a message fragment for the current message sequence number, or for any sequence up to 10 into the future. However if the Finished message has a sequence number of 2, anything greater than that in the queue is just left there. So, in those two ways we can end up with "orphaned" data in the queue that will never get removed - except when the connection is closed. At that point all the queues are flushed. An attacker could seek to exploit this by filling up the queues with lots of large messages that are never going to be used in order to attempt a DoS by memory exhaustion. I will assume that we are only concerned with servers here. It does not seem reasonable to be concerned about a memory exhaustion attack on a client. They are unlikely to process enough connections for this to be an issue. A "long" handshake with many messages might be 5 messages long (in the incoming direction), e.g. ClientHello, Certificate, ClientKeyExchange, CertificateVerify, Finished. So this would be message sequence numbers 0 to 4. Additionally we can buffer up to 10 messages in the future. Therefore the maximum number of messages that an attacker could send that could get orphaned would typically be 15. The maximum size that a DTLS message is allowed to be is defined by max_cert_list, which by default is 100k. Therefore the maximum amount of "orphaned" memory per connection is 1500k. Message sequence numbers get reset after the Finished message, so renegotiation will not extend the maximum number of messages that can be orphaned per connection. As noted above, the queues do get cleared when the connection is closed. Therefore in order to mount an effective attack, an attacker would have to open many simultaneous connections. Issue reported by Quan Luo. CVE-2016-2179 Reviewed-by: Richard Levitte <levitte@openssl.org> | 22 August 2016, 09:53:55 UTC |
| 5dfd038 | Matt Caswell | 19 August 2016, 23:12:16 UTC | Fix enable-zlib The enable-zlib option was broken by the recent "const" changes. Reviewed-by: Stephen Henson <steve@openssl.org> | 22 August 2016, 08:43:13 UTC |
| 68a3996 | Richard Levitte | 21 August 2016, 21:36:49 UTC | VMS: Use strict refdef extern model when building library object files Most of the time, this isn't strictly needed. However, in the default extern model (called relaxed refdef), symbols are treated as weak common objects unless they are initialised. The librarian doesn't include weak symbols in the (static) libraries, which renders them invisible when linking a program with said those libraries, which is a problem at times. Using the strict refdef model is much more like standard C on all other platforms, and thereby avoid the issues that come with the relaxed refdef model. Reviewed-by: Rich Salz <rsalz@openssl.org> | 22 August 2016, 08:10:59 UTC |
| e6ed2b9 | Andy Polyakov | 21 August 2016, 21:31:21 UTC | Add test/bio_enc_test.c. RT#4628 Reviewed-by: Rich Salz <rsalz@openssl.org> | 21 August 2016, 21:34:26 UTC |
| c1a7dcb | Andy Polyakov | 21 August 2016, 21:30:37 UTC | evp/bio_enc.c: refine non-overlapping logic. RT#4628 Reviewed-by: Rich Salz <rsalz@openssl.org> | 21 August 2016, 21:34:12 UTC |
| 2e929e5 | Andy Polyakov | 18 August 2016, 11:33:13 UTC | ecp_nistz256.c: get is_one on 32-bit platforms right. Thanks to Brian Smith for reporting this. Reviewed-by: Rich Salz <rsalz@openssl.org> | 21 August 2016, 20:16:48 UTC |
| 5a7ad1f | Rich Salz | 20 August 2016, 23:06:43 UTC | Move BIO index lock creation Reviewed-by: Richard Levitte <levitte@openssl.org> | 21 August 2016, 18:18:09 UTC |
| 6b1f413 | Dr. Stephen Henson | 20 August 2016, 12:07:57 UTC | update ordinals Reviewed-by: Viktor Dukhovni <viktor@openssl.org> | 21 August 2016, 17:25:23 UTC |
| 0b7347e | Dr. Stephen Henson | 20 August 2016, 12:02:09 UTC | Add X509_getm_notBefore, X509_getm_notAfter Add mutable versions of X509_get0_notBefore and X509_get0_notAfter. Rename X509_SIG_get0_mutable to X509_SIG_getm. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> | 21 August 2016, 17:25:23 UTC |
| bf932fb | FdaSilvaYY | 20 August 2016, 16:47:55 UTC | Duplicate includes Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1475) | 20 August 2016, 17:31:12 UTC |
| a73be79 | Kurt Roeckx | 06 August 2016, 17:16:00 UTC | Fix off by 1 in ASN1_STRING_set() Reviewed-by: Rich Salz <rsalz@openssl.org> MR: #3176 | 20 August 2016, 16:53:56 UTC |
| 8b8d963 | Rich Salz | 20 August 2016, 01:04:41 UTC | Add BIO_get_new_index() Reviewed-by: Dr. Stephen Henson <steve@openssl.org> | 20 August 2016, 01:04:41 UTC |
| 9e31356 | Dr. Stephen Henson | 19 August 2016, 18:32:19 UTC | fix warning about trailing comma Reviewed-by: Rich Salz <rsalz@openssl.org> | 19 August 2016, 18:32:19 UTC |
| bb1c5bb | Dr. Stephen Henson | 19 August 2016, 15:51:07 UTC | make update Reviewed-by: Rich Salz <rsalz@openssl.org> | 19 August 2016, 17:40:55 UTC |
| 2729f62 | Dr. Stephen Henson | 19 August 2016, 14:30:13 UTC | rename ordinals Reviewed-by: Rich Salz <rsalz@openssl.org> | 19 August 2016, 17:40:55 UTC |
| 568ce3a | Dr. Stephen Henson | 19 August 2016, 11:39:57 UTC | Constify certificate and CRL time routines. Update certificate and CRL time routines to match new standard. Reviewed-by: Rich Salz <rsalz@openssl.org> | 19 August 2016, 17:40:55 UTC |
| c4fbed6 | Viktor Dukhovni | 19 August 2016, 15:59:47 UTC | Add -dane_ee_no_namechecks s_client(1) option The DANE API supports a DANE_FLAG_NO_DANE_EE_NAMECHECKS option, but there was no way to exercise/enable it via s_client. This commit addresses that gap. Reviewed-by: Rich Salz <rsalz@openssl.org> | 19 August 2016, 16:18:49 UTC |
| dc047d3 | Dr. Stephen Henson | 19 August 2016, 15:21:21 UTC | Set certificate times in one function. Reviewed-by: Rich Salz <rsalz@openssl.org> | 19 August 2016, 15:52:58 UTC |
| 3a60d6f | Dr. Stephen Henson | 19 August 2016, 15:12:31 UTC | Avoid duplicated code. The certificate and CRL time setting functions used similar code, combine into a single utility function. Reviewed-by: Rich Salz <rsalz@openssl.org> | 19 August 2016, 15:52:58 UTC |
| 2a9afa4 | Rich Salz | 13 August 2016, 14:47:50 UTC | RT3940: For now, just document the issue. Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 15:45:07 UTC |
| 0556f2a | Richard Levitte | 19 August 2016, 15:14:26 UTC | MEMPACKET is typedef'd in ssltestlib.h, don't do so again in ssltestlib.c Reviewed-by: Rich Salz <rsalz@openssl.org> | 19 August 2016, 15:17:20 UTC |
| e597260 | FdaSilvaYY | 18 August 2016, 06:44:43 UTC | Allow to run all speed test when async_jobs active ... without any interruption. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1468) | 19 August 2016, 14:52:13 UTC |
| d5d9636 | Dr. Stephen Henson | 19 August 2016, 11:59:55 UTC | make update Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 14:46:19 UTC |
| 28da145 | Matt Caswell | 13 August 2016, 11:07:42 UTC | Convert PKCS12* functions to use const getters Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org> | 19 August 2016, 14:46:19 UTC |
| 7f35b7d | Matt Caswell | 19 August 2016, 12:50:01 UTC | Update function error code A function error code needed updating due to merge issues. Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 12:52:40 UTC |
| 52a03d2 | Matt Caswell | 19 July 2016, 10:34:21 UTC | Fix some clang warnings Clang was complaining about some unused functions. Moving the stack declaration to the header seems to sort it. Also the certstatus variable in dtlstest needed to be declared static. Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 12:52:40 UTC |
| 1fb9fdc | Matt Caswell | 01 July 2016, 14:20:33 UTC | Fix DTLS replay protection The DTLS implementation provides some protection against replay attacks in accordance with RFC6347 section 4.1.2.6. A sliding "window" of valid record sequence numbers is maintained with the "right" hand edge of the window set to the highest sequence number we have received so far. Records that arrive that are off the "left" hand edge of the window are rejected. Records within the window are checked against a list of records received so far. If we already received it then we also reject the new record. If we have not already received the record, or the sequence number is off the right hand edge of the window then we verify the MAC of the record. If MAC verification fails then we discard the record. Otherwise we mark the record as received. If the sequence number was off the right hand edge of the window, then we slide the window along so that the right hand edge is in line with the newly received sequence number. Records may arrive for future epochs, i.e. a record from after a CCS being sent, can arrive before the CCS does if the packets get re-ordered. As we have not yet received the CCS we are not yet in a position to decrypt or validate the MAC of those records. OpenSSL places those records on an unprocessed records queue. It additionally updates the window immediately, even though we have not yet verified the MAC. This will only occur if currently in a handshake/renegotiation. This could be exploited by an attacker by sending a record for the next epoch (which does not have to decrypt or have a valid MAC), with a very large sequence number. This means the right hand edge of the window is moved very far to the right, and all subsequent legitimate packets are dropped causing a denial of service. A similar effect can be achieved during the initial handshake. In this case there is no MAC key negotiated yet. Therefore an attacker can send a message for the current epoch with a very large sequence number. The code will process the record as normal. If the hanshake message sequence number (as opposed to the record sequence number that we have been talking about so far) is in the future then the injected message is bufferred to be handled later, but the window is still updated. Therefore all subsequent legitimate handshake records are dropped. This aspect is not considered a security issue because there are many ways for an attacker to disrupt the initial handshake and prevent it from completing successfully (e.g. injection of a handshake message will cause the Finished MAC to fail and the handshake to be aborted). This issue comes about as a result of trying to do replay protection, but having no integrity mechanism in place yet. Does it even make sense to have replay protection in epoch 0? That issue isn't addressed here though. This addressed an OCAP Audit issue. CVE-2016-2181 Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 12:52:40 UTC |
| ac9fc67 | Matt Caswell | 05 July 2016, 08:50:55 UTC | Add DTLS replay protection test Injects a record from epoch 1 during epoch 0 handshake, with a record sequence number in the future, to test that the record replay protection feature works as expected. This is described more fully in the next commit. Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 12:52:40 UTC |
| 738ad94 | Matt Caswell | 05 July 2016, 08:51:08 UTC | Fix DTLS unprocessed records bug During a DTLS handshake we may get records destined for the next epoch arrive before we have processed the CCS. In that case we can't decrypt or verify the record yet, so we buffer it for later use. When we do receive the CCS we work through the queue of unprocessed records and process them. Unfortunately the act of processing wipes out any existing packet data that we were still working through. This includes any records from the new epoch that were in the same packet as the CCS. We should only process the buffered records if we've not got any data left. Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 12:52:40 UTC |
| 6fc1748 | Matt Caswell | 04 July 2016, 13:59:06 UTC | Add a DTLS unprocesed records test Add a test to inject a record from the next epoch during the handshake and make sure it doesn't get processed immediately. Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 12:52:40 UTC |
| b498212 | Matt Caswell | 04 July 2016, 13:55:50 UTC | Split create_ssl_connection() Split the create_ssl_connection() helper function into two steps: one to create the SSL objects, and one to actually create the connection. This provides the ability to make changes to the SSL object before the connection is actually made. Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 12:52:40 UTC |
| d82dec4 | Matt Caswell | 04 July 2016, 13:53:28 UTC | Add a DTLS packet mem BIO This adds a BIO similar to a normal mem BIO but with datagram awareness. It also has the capability to inject additional packets at arbitrary locations into the BIO, for testing purposes. Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 12:52:40 UTC |
| d9a2e90 | Matt Caswell | 04 July 2016, 13:51:56 UTC | Add a (D)TLS dumper BIO Dump out the records passed over the BIO. Only works for DTLS at the moment but could easily be extended to TLS. Reviewed-by: Richard Levitte <levitte@openssl.org> | 19 August 2016, 12:52:40 UTC |
| 15269e5 | Emilia Kasper | 19 August 2016, 12:19:32 UTC | Add more details on how to add a new SSL test Reviewed-by: Stephen Henson <steve@openssl.org> | 19 August 2016, 12:50:25 UTC |
| 45dcb5c | Dr. Stephen Henson | 18 August 2016, 14:26:47 UTC | make update Reviewed-by: Matt Caswell <matt@openssl.org> | 19 August 2016, 11:47:31 UTC |
| 68c12bf | Dr. Stephen Henson | 18 August 2016, 14:16:31 UTC | Add X509_get0_serialNumber() and constify OCSP_cert_to_id() Reviewed-by: Matt Caswell <matt@openssl.org> | 19 August 2016, 11:47:31 UTC |
| 1122248 | Dr. Stephen Henson | 18 August 2016, 14:13:00 UTC | constify X509_REQ_get0_signature() Reviewed-by: Matt Caswell <matt@openssl.org> | 19 August 2016, 11:47:31 UTC |
| 60c2587 | Dr. Stephen Henson | 18 August 2016, 12:59:32 UTC | constify i2o_ECPublicKey Reviewed-by: Matt Caswell <matt@openssl.org> | 19 August 2016, 11:44:18 UTC |
| a9c27fe | Benjamin Kaduk | 18 August 2016, 20:47:04 UTC | Sort %disabled in Configure @disablables is sorted, but these were just added at the end of %disabled in commits c2e27310 and 22e3dcb7. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 19 August 2016, 09:51:21 UTC |
| bc87fb6 | Viktor Dukhovni | 18 August 2016, 20:57:55 UTC | Fix missing dane_tlsa_rrdata option error message The error message said "dane_tlsa_rrset" instead of "dane_tlsa_rrdata". Reviewed-by: Rich Salz <rsalz@openssl.org> | 18 August 2016, 21:04:45 UTC |
| 095d2f0 | Dr. Stephen Henson | 18 August 2016, 15:48:33 UTC | Constify i2a* Reviewed-by: Rich Salz <rsalz@openssl.org> | 18 August 2016, 16:20:36 UTC |
| a3a0b41 | Richard Levitte | 18 August 2016, 11:24:27 UTC | Simplify indentation of DECLARE_ and IMPLEMENT_ lines There's no reason we should enumerate every type of IMPLEMENT_ and DECLARE_ line (and forget the ones we add a little now and then). They all start with the same first word, let's just take'm all. Reviewed-by: Rich Salz <rsalz@openssl.org> | 18 August 2016, 12:40:37 UTC |
| a230b26 | Emilia Kasper | 05 August 2016, 17:03:17 UTC | Indent ssl/ Run util/openssl-format-source on ssl/ Some comments and hand-formatted tables were fixed up manually by disabling auto-formatting. Reviewed-by: Rich Salz <rsalz@openssl.org> | 18 August 2016, 12:02:29 UTC |
| 604f6ef | Matt Caswell | 15 August 2016, 11:41:25 UTC | Convert X509_REVOKED* functions to use const getters Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org> | 18 August 2016, 10:59:39 UTC |
| dd8e5a5 | Emilia Kasper | 12 August 2016, 12:29:24 UTC | Test that the peers send at most one fatal alert Duplicate alerts have happened, see 70c22888c1648fe8652e77107f3c74bf2212de36 Reviewed-by: Rich Salz <rsalz@openssl.org> | 18 August 2016, 10:49:32 UTC |
| 6dc9974 | Emilia Kasper | 16 August 2016, 13:11:08 UTC | Port multi-buffer tests Make maximum fragment length configurable and add various fragmentation tests, in addition to the existing multi-buffer tests. Reviewed-by: Rich Salz <rsalz@openssl.org> | 18 August 2016, 10:46:00 UTC |
| 9d8c2df | Rich Salz | 17 August 2016, 20:38:08 UTC | Fix some doc nits. Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 23:41:47 UTC |
| 8d00e30 | Richard Levitte | 17 August 2016, 13:06:23 UTC | Don't try to init dasync internally Since dasync isn't installed, and is only ever used as a dynamic engine, there's no reason to consider it for initialization when building static engines. Reviewed-by: Ben Laurie <ben@openssl.org> | 17 August 2016, 19:34:42 UTC |
| 67a014b | Dr. Stephen Henson | 17 August 2016, 16:29:18 UTC | make update Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 16:48:44 UTC |
| 59b4da0 | Dr. Stephen Henson | 17 August 2016, 16:27:05 UTC | Constify X509_SIG. Constify X509_SIG_get0() and order arguments to mactch new standard. Add X509_SIG_get0_mutable() to support modification or initialisation of an X509_SIG structure. Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 16:48:43 UTC |
| d6073e2 | FdaSilvaYY | 07 August 2016, 10:04:26 UTC | Small nits and cleanups using util/openssl-format-source on s_derver, s_client, ca.c, speed.c only... Fix/merge some #ifndef Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 16:09:19 UTC |
| cc69629 | FdaSilvaYY | 04 August 2016, 21:52:22 UTC | Constify char* input parameters in apps code Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 16:09:19 UTC |
| e7917e3 | FdaSilvaYY | 04 August 2016, 22:19:36 UTC | Simplify and add help about OPT_PVK* options Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 16:09:19 UTC |
| cfd451d | FdaSilvaYY | 03 August 2016, 22:23:39 UTC | Improve error message Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 16:09:19 UTC |
| 54463e4 | FdaSilvaYY | 03 August 2016, 20:49:25 UTC | Relocalise some globals variables Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 16:09:19 UTC |
| 2e5ead8 | Dr. Stephen Henson | 17 August 2016, 14:49:36 UTC | Constify ssl_cert_type() Reviewed-by: Richard Levitte <levitte@openssl.org> | 17 August 2016, 14:49:44 UTC |
| 5ebd2fc | Dr. Stephen Henson | 17 August 2016, 13:58:56 UTC | Constify X509_certificate_type() Reviewed-by: Richard Levitte <levitte@openssl.org> | 17 August 2016, 13:59:54 UTC |
| 8adc1cb | Dr. Stephen Henson | 17 August 2016, 13:10:52 UTC | Constify X509_get0_signature() Reviewed-by: Richard Levitte <levitte@openssl.org> | 17 August 2016, 13:12:55 UTC |
| 8900f3e | Dr. Stephen Henson | 17 August 2016, 12:50:48 UTC | Convert X509* functions to use const getters Reviewed-by: Richard Levitte <levitte@openssl.org> | 17 August 2016, 12:59:04 UTC |
| 5e6089f | Matt Caswell | 13 August 2016, 13:44:07 UTC | Convert X509_CRL* functions to use const getters Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org> | 17 August 2016, 12:38:03 UTC |
| 6eabcc8 | Matt Caswell | 15 August 2016, 09:07:30 UTC | Make X509_NAME_get0_der() conform to OpenSSL style Put the main object first in the params list. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org> | 17 August 2016, 12:03:04 UTC |
| a075408 | Dr. Stephen Henson | 17 August 2016, 11:34:22 UTC | Corrupt signature in place. Reviewed-by: Richard Levitte <levitte@openssl.org> | 17 August 2016, 11:34:22 UTC |
| 79613ea | Matt Caswell | 12 August 2016, 20:37:55 UTC | Convert OCSP* functions to use const getters Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org> | 17 August 2016, 11:29:03 UTC |
| 245c6bc | Dr. Stephen Henson | 16 August 2016, 23:21:55 UTC | Constify private key decode. Reviewed-by: Richard Levitte <levitte@openssl.org> | 17 August 2016, 11:01:29 UTC |
| ac4e257 | Dr. Stephen Henson | 16 August 2016, 19:18:04 UTC | constify X509_ALGOR_get0() Reviewed-by: Richard Levitte <levitte@openssl.org> | 17 August 2016, 11:01:29 UTC |
| 0c80064 | Dr. Stephen Henson | 16 August 2016, 19:14:02 UTC | Constify ASN1_item_unpack(). Reviewed-by: Richard Levitte <levitte@openssl.org> | 17 August 2016, 11:01:29 UTC |
| fddfc0a | Remi Gacogne | 06 August 2016, 10:54:29 UTC | Add missing session id and tlsext_status accessors * SSL_SESSION_set1_id() * SSL_SESSION_get0_id_context() * SSL_CTX_get_tlsext_status_cb() * SSL_CTX_get_tlsext_status_arg() Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 09:38:20 UTC |
| 46117d3 | Richard Levitte | 17 August 2016, 08:45:03 UTC | dasync is an internal testing engine, so don't install it Unfortunately, it means that the VMS IVP gets a bit crippled. This will be fixed later on. Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 08:50:31 UTC |
| 2238119 | Richard Levitte | 17 August 2016, 08:39:11 UTC | VMS: no ENDIF on one line IF statements, in config.com Correct small error from last config.com change Reviewed-by: Matt Caswell <matt@openssl.org> | 17 August 2016, 08:48:43 UTC |
| 48593cb | Matt Caswell | 13 August 2016, 13:29:41 UTC | Convert SSL_SESSION* functions to use const getters Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org> | 16 August 2016, 22:36:28 UTC |
| b2e57e0 | Matt Caswell | 13 August 2016, 12:40:05 UTC | Convert PKCS8* functions to use const getters Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org> | 16 August 2016, 22:36:27 UTC |
| bb2f62b | Matt Caswell | 13 August 2016, 13:32:17 UTC | Convert TS_STATUS_INFO* functions to use const getters Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org> | 16 August 2016, 22:36:27 UTC |
| 69b86d4 | FdaSilvaYY | 11 August 2016, 22:29:27 UTC | two typo fixes Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1461) | 16 August 2016, 19:51:58 UTC |
| 1bb7310 | Gergely Nagy | 16 August 2016, 12:46:13 UTC | Fix compilation when using MASM on x86 The generated asm code from x86cpuid.pl contains CMOVE instructions which are only available on i686 and later CPUs. Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1459) | 16 August 2016, 18:46:55 UTC |
| 2ecb9f2 | Matt Caswell | 16 August 2016, 12:28:14 UTC | Provide compat macros for SSL_CTX_set_ecdh_auto() and SSL_set_ecdh_auto() These functions are no longer relevant to 1.1.0 (we always have auto ecdh on) - but no reason to break old code that tries to call it. The macros will only return a dummy "success" result if the app was trying to enable ecdh. Disabling can't be done in quite this way any more. Fixes Github Issue #1437 Reviewed-by: Viktor Dukhovni <viktor@openssl.org> | 16 August 2016, 16:11:43 UTC |
| f9cf774 | Matt Caswell | 16 August 2016, 13:07:29 UTC | Ensure we unpad in constant time for read pipelining The read pipelining code broke constant time unpadding. See GitHub issue #1438 Reviewed-by: Rich Salz <rsalz@openssl.org> | 16 August 2016, 15:53:17 UTC |
| 0f022f5 | Dr. Stephen Henson | 16 August 2016, 14:19:55 UTC | Corrupt signature earlier. If -badsig is selected corrupt the signature before printing out any details so the output reflects the modified signature. Reviewed-by: Rich Salz <rsalz@openssl.org> | 16 August 2016, 15:05:36 UTC |
| 34d4d74 | Dr. Stephen Henson | 16 August 2016, 14:08:06 UTC | make update Reviewed-by: Rich Salz <rsalz@openssl.org> | 16 August 2016, 15:05:36 UTC |
| 17ebf85 | Dr. Stephen Henson | 16 August 2016, 13:06:48 UTC | Add ASN1_STRING_get0_data(), deprecate ASN1_STRING_data(). Deprecate the function ASN1_STRING_data() and replace with a new function ASN1_STRING_get0_data() which returns a constant pointer. Update library to use new function. Reviewed-by: Rich Salz <rsalz@openssl.org> | 16 August 2016, 15:05:35 UTC |
| 1940aa6 | Richard Levitte | 16 August 2016, 12:08:54 UTC | Remove duplicate ordinals Reviewed-by: Rich Salz <rsalz@openssl.org> | 16 August 2016, 12:16:53 UTC |
| 05ef4d1 | Andy Polyakov | 14 August 2016, 20:37:58 UTC | ARMv8 assembly pack: add Samsung Mongoose results. Reviewed-by: Tim Hudson <tjh@openssl.org> | 16 August 2016, 10:47:49 UTC |
| 9d46752 | Andy Polyakov | 14 August 2016, 15:24:10 UTC | Configure: recognize -static as link option and disable incompatible options. Reviewed-by: Rich Salz <rsalz@openssl.org> | 16 August 2016, 10:45:51 UTC |
| f494173 | Andy Polyakov | 12 August 2016, 14:25:33 UTC | test/ssl_test.tmpl: make it work with elderly perl. Reviewed-by: Rich Salz <rsalz@openssl.org> | 16 August 2016, 10:43:44 UTC |
| 31c34a3 | David Woodhouse | 05 August 2016, 09:58:52 UTC | Fix satsub64be() to unconditionally use 64-bit integers Now we support (u)int64_t this can be very much simpler. Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 16 August 2016, 09:24:57 UTC |
| e0421bd | Emilia Kasper | 11 August 2016, 18:51:57 UTC | SSL tests: send some application data Reviewed-by: Rich Salz <rsalz@openssl.org> | 16 August 2016, 09:00:15 UTC |
| ffb261f | Richard Levitte | 15 August 2016, 16:46:39 UTC | Add a "config" for verbosity and use it with Travis Modify VMS config.com to match Reviewed-by: Emilia Käsper <emilia@openssl.org> | 16 August 2016, 08:38:45 UTC |
| a4ffbbe | Richard Levitte | 15 August 2016, 16:45:22 UTC | Make "make" less verbose in Travis, except for the build only case Reviewed-by: Emilia Käsper <emilia@openssl.org> | 16 August 2016, 08:38:45 UTC |
| 66bcba1 | Dr. Stephen Henson | 15 August 2016, 15:52:21 UTC | Limit reads in do_b2i_bio() Apply a limit to the maximum blob length which can be read in do_d2i_bio() to avoid excessive allocation. Thanks to Shi Lei for reporting this. Reviewed-by: Rich Salz <rsalz@openssl.org> | 15 August 2016, 23:27:10 UTC |
| 8b9afbc | Dr. Stephen Henson | 05 August 2016, 13:33:03 UTC | Check for errors in a2d_ASN1_OBJECT() Check for error return in BN_div_word(). Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 August 2016, 23:19:19 UTC |
| 07bed46 | Dr. Stephen Henson | 05 August 2016, 13:26:03 UTC | Check for errors in BN_bn2dec() If an oversize BIGNUM is presented to BN_bn2dec() it can cause BN_div_word() to fail and not reduce the value of 't' resulting in OOB writes to the bn_data buffer and eventually crashing. Fix by checking return value of BN_div_word() and checking writes don't overflow buffer. Thanks to Shi Lei for reporting this bug. CVE-2016-2182 Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 August 2016, 23:19:19 UTC |
| 40c60b0 | Tomas Mraz | 15 August 2016, 10:02:06 UTC | Avoid truncating the pointer on x32 platform. The 64 bit pointer must not be cast to 32bit unsigned long on x32 platform. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 15 August 2016, 22:30:45 UTC |
| e7e5d60 | Tomas Mraz | 10 August 2016, 13:21:32 UTC | Add a comment for the added cast with explanation. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 15 August 2016, 22:30:45 UTC |
| 3f8d121 | Tomas Mraz | 09 August 2016, 10:50:13 UTC | Fix af_alg engine failure on 32 bit architectures. Add extra cast to unsigned long to avoid sign extension when converting pointer to 64 bit data. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 15 August 2016, 22:30:45 UTC |
| bb982ce | Matt Caswell | 04 August 2016, 10:31:57 UTC | Remove a stray unneeded line in 70-test_sslrecords.t Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 August 2016, 22:14:30 UTC |
| 78fcddb | Matt Caswell | 03 August 2016, 12:03:25 UTC | Address feedback on SSLv2 ClientHello processing Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 August 2016, 22:14:30 UTC |
| a2a0c86 | Matt Caswell | 02 August 2016, 16:24:54 UTC | Add some SSLv2 ClientHello tests Test that we handle a TLS ClientHello in an SSLv2 record correctly. Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 August 2016, 22:14:30 UTC |
| a01c86a | Matt Caswell | 02 August 2016, 16:43:32 UTC | Send an alert if we get a non-initial record with the wrong version If we receive a non-initial record but the version number isn't right then we should send an alert. Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 August 2016, 22:14:30 UTC |
| 44efb88 | Matt Caswell | 01 August 2016, 16:15:13 UTC | Address feedback on SSLv2 ClientHello processing Feedback on the previous SSLv2 ClientHello processing fix was that it breaks layering by reading init_num in the record layer. It also does not detect if there was a previous non-fatal warning. This is an alternative approach that directly tracks in the record layer whether this is the first record. GitHub Issue #1298 Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 August 2016, 22:14:30 UTC |
| c35d339 | Rob Percival | 15 August 2016, 15:46:22 UTC | Replaces CT_POLICY_EVAL_CTX_set0 entries with new setters in libcrypto.num Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1408) | 15 August 2016, 16:57:00 UTC |
| 11c68ce | Rob Percival | 15 August 2016, 13:47:02 UTC | Make CT_POLICY_EVAL_CTX_set1_{cert,issuer} into boolean functions They may fail if they cannot increment the reference count of the certificate they are storing a pointer for. They should return 0 if this occurs. Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1408) | 15 August 2016, 16:56:47 UTC |
