Skip to main content
sort by:
RevisionAuthorDateMessageCommit Date
f7835e1 Andy Polyakov11 September 2014, 22:06:00 UTCperlasm/x86_64-xlate.pl: handle inter-bank movd. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 902b30df193afc3417a96ba72a81ed390bd50de3)21 September 2014, 22:07:44 UTC
11d8abb Andy Polyakov30 August 2014, 17:22:51 UTCConfigure: add configuration for crypto/ec/asm extensions. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 6019cdd327526beb25a4c31c1ef63e72f5f8a4b0) Resolved conflicts: Configure Makefile.org TABLE21 September 2014, 22:07:44 UTC
320d949 Tim Hudson21 September 2014, 11:54:31 UTCFixed error introduced in commit f2be92b94dad3c6cbdf79d99a324804094cf1617 that fixed PR#3450 where an existing cast masked an issue when i was changed from int to long in that commit Picked up on z/linux (s390) where sizeof(int)!=sizeof(long) Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit b5ff559ff90124c6fd53bbb49dae5edb4e821e0a)21 September 2014, 20:35:57 UTC
dfb5de6 Andy Polyakov20 September 2014, 08:18:19 UTCHarmonize Tru64 and Linux make rules. RT: 3333,3165 Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit d475b2a3bfde8d4aceefb41b21acc3711893d2a8)20 September 2014, 08:22:13 UTC
5015a93 Jake Goulding05 September 2014, 15:13:23 UTCRT2301: GetDIBits, not GetBitmapBits in rand_win GetDIBits has been around since Windows2000 and BitBitmapBits is an old Win16 compatibility function that is much slower. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 99b00fd99330afb0be46265c3e28f25f938d3221)18 September 2014, 20:42:07 UTC
478b347 Rich Salz11 September 2014, 17:08:30 UTCRT2772 update: c_rehash was broken Move the readdir() lines out of the if statement, so that flist is available globally. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 6f46c3c3b007f1aed77bbb4d1657fab8521e2e08)11 September 2014, 17:09:56 UTC
3258429 Rich Salz10 September 2014, 19:05:38 UTCRT3271 update; extra; semi-colon; confuses; some; Reviewed-by: Kurt Roeckx <kurt@openssl.org> (cherry picked from commit cb4bb56bae9404572571e8ce573ba9e48d6f7717)10 September 2014, 19:09:53 UTC
a9d928a Rich Salz10 September 2014, 15:43:45 UTCRT2560: missing NULL check in ocsp_req_find_signer If we don't find a signer in the internal list, then fall through and look at the internal list; don't just return NULL. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit b2aa38a980e9fbf158aafe487fb729c492b241fb)10 September 2014, 16:20:15 UTC
3aa2d2d Rich Salz09 September 2014, 21:41:46 UTCRT2196: Clear up some README wording Say where to email bug reports. Mention general RT tracker info in a separate paragraph. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 468ab1c20d1f3a43a63d0516fed6c9fefb3ccf71)09 September 2014, 21:49:04 UTC
f33ce36 Matt Caswell09 September 2014, 20:50:06 UTCRT3192: spurious error in DSA verify This is funny; Ben commented in the source, Matt opend a ticket, and Rich is doing the submit. Need more code-review? :) Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit eb63bce040d1cc6147d256f516b59552c018e29b)09 September 2014, 21:10:57 UTC
e61c648 Rich Salz09 September 2014, 17:53:16 UTCRT3271: Don't use "if !" in shell lines For portability don't use "if ! expr" Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit b999f66e34d19ae4d81263bc96b8b8d548d2e13c)09 September 2014, 21:05:50 UTC
8c0d19d Geoff Keating09 September 2014, 18:28:54 UTCRT1909: Omit version for v1 certificates When calling X509_set_version to set v1 certificate, that should mean that the version number field is omitted. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 1f18f50c4b0711ebe4a20038d324c0de5dce4512)09 September 2014, 19:16:42 UTC
283a8fd Kurt Cancemi09 September 2014, 17:48:00 UTCRT3506: typo's in ssltest Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 4eadd11cd97ad359a2207e8e554d9fc84fce1110)09 September 2014, 17:58:33 UTC
b8d687b Paul Suhler08 September 2014, 22:34:48 UTCRT2841: Extra return in check_issued Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 4cd1119df38b095b6981dfee993195f18ed3c619)08 September 2014, 22:50:40 UTC
57c932d Kurt Roeckx08 September 2014, 21:14:36 UTCRT2626: Change default_bits from 1K to 2K This is a more comprehensive fix. It changes all keygen apps to use 2K keys. It also changes the default to use SHA256 not SHA1. This is from Kurt's upstream Debian changes. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Kurt Roeckx <kurt@openssl.org> (cherry picked from commit 44e0c2bae4bfd87d770480902618dbccde84fd81)08 September 2014, 21:23:37 UTC
ef720a6 Matthias Andree07 September 2014, 22:45:02 UTCRT2272: Add old-style hash to c_rehash In addition to Matthias's change, I also added -n to not remove links. And updated the manpage. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit a787c2590e468585a1a19738e0c7f481ec91b762)08 September 2014, 15:35:25 UTC
f28c48d Rich Salz03 September 2014, 16:02:13 UTCRT468: SSL_CTX_sess_set_cache_size wrong The documentation is wrong about what happens when the session cache fills up. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit e9edfc419674f20b482a9beff9c246519f9c503e)08 September 2014, 15:26:19 UTC
ff89be8 Erik Auerswald27 August 2014, 02:50:34 UTCRT3301: Discard too-long heartbeat requests Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit af4c6e348e4bad6303e7d214cdcf2536487aabe4)08 September 2014, 15:23:02 UTC
61a44b7 Scott Schaefer13 August 2014, 18:42:23 UTCRT2518: fix pod2man errors pod2man now complains when item tags are not sequential. Also complains about missing =back and other tags. Silence the warnings; most were already done. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit fe7573042fa7f406fedb78d959659b39a7a1dcfb)08 September 2014, 15:18:58 UTC
45236ed Rich Salz04 September 2014, 21:15:42 UTCRT3108: OPENSSL_NO_SOCK should imply OPENSSL_NO_DGRAM Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit be0bd11d698677bb7dde14cde73af098da94da18)08 September 2014, 15:08:01 UTC
240635c Robin Lee04 September 2014, 16:36:41 UTCRT3031: Need to #undef some names for win32 Copy the ifdef/undef stanza from x509.h to x509v3.h Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 83e4e03eeb22d2fbaec516a466330f2ccab22864)08 September 2014, 15:06:07 UTC
610ac05 Martin Olsson04 September 2014, 16:45:05 UTCRT2843: Remove another spurious close-comment token Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 683cd7c9485009efcd5b522357519f0c7e1d4c47)08 September 2014, 14:52:19 UTC
9c096d0 Martin Olsson04 September 2014, 16:42:34 UTCRT2842: Remove spurious close-comment marker. Also, I (rsalz) changed "#ifdef undef" to "#if 0" Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 6b0dc6eff1a59274730802db923d55802378d011)08 September 2014, 14:50:33 UTC
1915744 Rich Salz08 September 2014, 14:46:38 UTCMerge branch 'OpenSSL_1_0_2-stable' of git.openssl.org:openssl into OpenSSL_1_0_2-stable another empty merge??? Reviewed-by: Dr. Stephen Henson <steve@openssl.org>08 September 2014, 14:47:03 UTC
c387f7d Rich Salz08 September 2014, 14:44:04 UTCEmpty merge Merge branch 'OpenSSL_1_0_2-stable' of git.openssl.org:openssl into OpenSSL_1_0_2-stable Reviewed-by: Dr. Stephen Henson <steve@openssl.org>08 September 2014, 14:45:53 UTC
eee95fc Rich Salz08 September 2014, 14:44:04 UTCEmpty merge Merge branch 'OpenSSL_1_0_2-stable' of git.openssl.org:openssl into OpenSSL_1_0_2-stable Reviewed-by: Dr. Stephen Henson <steve@openssl.org>08 September 2014, 14:45:31 UTC
dd3c21b Rich Salz05 September 2014, 22:01:31 UTCRT1834: Fix PKCS7_verify return value The function returns 0 or 1, only. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit b0e659cfaca9ff4a481cc63b7f6b6e97303ad8fe)08 September 2014, 14:43:32 UTC
dd13aad Rich Salz05 September 2014, 22:01:31 UTCRT1832: Fix PKCS7_verify return value The function returns 0 or 1, only. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit b0e659cfaca9ff4a481cc63b7f6b6e97303ad8fe)08 September 2014, 14:39:12 UTC
2a49fef Alon Bar-Lev05 September 2014, 14:53:51 UTCRT1771: Add string.h include. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 8842987e5a76535597b9795b0408565baabf18d1)08 September 2014, 14:38:08 UTC
c56be26 Viktor Dkhovni07 September 2014, 22:22:33 UTCRT1325,2973: Add more extensions to c_rehash Regexp was bracketed wrong. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 5a8addc432503d99dba39474892b07345a619641)07 September 2014, 22:25:59 UTC
2102c53 Dr. Stephen Henson05 September 2014, 12:39:39 UTCAdd CHANGES entry for SCT viewer code. Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit b2774f6e17d4204f19a4c009cef9db58821c4456)05 September 2014, 12:45:45 UTC
e12e875 Adam Langley20 June 2014, 19:00:00 UTCpsk_client_callback, 128-byte id bug. Fix a bug in handling of 128 byte long PSK identity in psk_client_callback. OpenSSL supports PSK identities of up to (and including) 128 bytes in length. PSK identity is obtained via the psk_client_callback, implementors of which are expected to provide a NULL-terminated identity. However, the callback is invoked with only 128 bytes of storage thus making it impossible to return a 128 byte long identity and the required additional NULL byte. This CL fixes the issue by passing in a 129 byte long buffer into the psk_client_callback. As a safety precaution, this CL also zeroes out the buffer before passing it into the callback, uses strnlen for obtaining the length of the identity returned by the callback, and aborts the handshake if the identity (without the NULL terminator) is longer than 128 bytes. (Original patch amended to achieve strnlen in a different way.) Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit be0d851732bad7370640702bc9c4a33189ede287)05 September 2014, 10:22:33 UTC
0600a5c Adam Langley23 April 2013, 16:13:51 UTCEnsure that x**0 mod 1 = 0. (cherry picked from commit 2b0180c37fa6ffc48ee40caa831ca398b828e680) Reviewed-by: Ben Laurie <ben@openssl.org>04 September 2014, 14:05:57 UTC
a91b73f Richard Levitte14 August 2014, 23:24:34 UTCFollowup on RT3334 fix: make sure that a directory that's the empty string returns 0 with errno = ENOENT. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 360928b7d0f16dde70e26841bbf9e1af727e8b8f)03 September 2014, 20:23:34 UTC
02c38e3 Phil Mesnier14 August 2014, 17:35:07 UTCRT3334: Fix crypto/LPdir_win.c Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 6a14fe7576e7a14a46ba14df8be8fe478536b4fb)03 September 2014, 20:23:34 UTC
fa2ae04 Clang via Jeffrey Walton02 September 2014, 21:04:53 UTCRT3140: Possibly-unit variable in pem_lib.c Can't really happen, but the flow of control isn't obvious. Add an initializer. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 0ff3687eab8b0915198ad84d83da5998860b11b3)03 September 2014, 03:38:15 UTC
27739e9 Emilia Kasper28 August 2014, 17:45:55 UTCMake the inline const-time functions static. "inline" without static is not correct as the compiler may choose to ignore it and will then either emit an external definition, or expect one. Reviewed-by: Geoff Thorpe <geoff@openssl.org> (cherry picked from commit 86f50b36e63275a916b147f9d8764e3c0c060fdb)02 September 2014, 13:24:54 UTC
157c345 Adam Williamson31 August 2014, 22:22:09 UTCRT3511: doc fix; req default serial is random RT842, closed back in 2004, changed the default serial number to be a random number rather than zero. Finally time to update the doc Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 3aba132d61baeecffb9a6f8da7d0809352cbfb2d)01 September 2014, 03:41:51 UTC
770b98d Richard Levitte31 August 2014, 15:02:25 UTCAdd t1_ext and ssl_utst to the VMS build as well. Reviewed-by: Dr Stephen Henson <steve@openssl.org>31 August 2014, 16:22:02 UTC
8475416 TANABE Hiroyasu30 August 2014, 21:56:31 UTCRT1325,2973: Add more extensions to c_rehash Add .crt/.cer/.crl to the filenames parsed. I also updated the podpage (since it didn't exist when this ticket was first created, nor when it was re-created seven years later). Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 80ec8d4e3ee212786dc3092b1c97305b871827f0)31 August 2014, 04:37:54 UTC
30b7d5e Andy Polyakov30 August 2014, 17:17:09 UTCmd5-x86_64.pl: work around warning. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 4d86e8df6be69ed13abb73fd564f1f894eea0a98)30 August 2014, 17:18:12 UTC
9dd6240 Andy Polyakov30 August 2014, 17:13:49 UTCx86[_64] assembly pack: add Silvermont performance data. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit b59f92e75d334c9281082a02faa6c68afb614fd2)30 August 2014, 17:14:49 UTC
63eacab Rich Salz30 August 2014, 14:18:51 UTCRT2820: case-insensitive filenames on Darwin Andy pointed out there is also darwin64, so tweak the pattern. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 457f7b14ecce885dce0b1a16bcd0723f1d7a2792)30 August 2014, 14:20:28 UTC
0996ccc Rich Salz14 July 2014, 15:27:16 UTCAdd tags/TAGS Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 9d6253cfd3395dfe7147dae134579c6b16544c53)30 August 2014, 14:09:01 UTC
6aa9dba Rich Salz28 August 2014, 23:11:42 UTCRT2119,3407: Updated to dgst.pod Re-order algorithm list. Be consistent in command synopsis. Add content about signing. Add EXAMPLE section Add some missing options: -r, -fips-fingerprint -non-fips-allow Various other fixes. Reviewed-by: Andy Polyakov <appro@openssl.org>30 August 2014, 14:05:19 UTC
c1071ab James Westby14 August 2014, 14:14:35 UTCRT1941: c_rehash.pod is missing Add the file written by James Westby, graciously contributed under the terms of the OpenSSL license. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit cf2239b3b397174a8a6b1cc84ff68aba34ed5941)30 August 2014, 13:51:36 UTC
5decce4 Rich Salz18 August 2014, 17:00:51 UTCRT2379: Bug in BIO_set_accept_port.pod The doc says that port can be "*" to mean any port. That's wrong. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 07e3b31fae98b985d3d2aad7066144b11833f688)29 August 2014, 20:46:16 UTC
12dabfc Jim Reid29 August 2014, 16:07:42 UTCRT2880: HFS is case-insensitive filenames Add Darwin to list of case-insensitive filenames when installing manapges. When doing this, I noticed that we weren't setting "filecase" for the HTML doc install. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 82d9185ae53f6ba93953ae0e484179be89c8508a)29 August 2014, 20:39:38 UTC
39d64e9 Dr. Stephen Henson28 August 2014, 17:24:14 UTCupdate ordinals Reviewed-by: Tim Hudson <tjh@openssl.org>28 August 2014, 17:24:14 UTC
f9784ba Dr. Stephen Henson26 August 2014, 00:20:26 UTCFix comments, add new test. Fix comments in ssltest.c: return value of 0 now means extension is omitted and add_cb is not called for servers if the corresponding extension is absent in ClientHello. Test add_cb is not called if extension is not received. Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit f47e203975133ddbae3cde20c8c3c0516f62066c)28 August 2014, 17:10:21 UTC
8fb57b2 Dr. Stephen Henson18 August 2014, 01:56:13 UTCCustom extension documentation. Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit f3f56c2a87951e115a7f82d06826e72c9e13987f)28 August 2014, 17:10:21 UTC
cf8d6c1 Dr. Stephen Henson19 August 2014, 13:02:50 UTCRename some callbacks, fix alignment. Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit 0cfefe4b6dcc6947c236b0f10a7f9e2f02273075)28 August 2014, 17:10:21 UTC
4164d63 Dr. Stephen Henson19 August 2014, 12:54:38 UTCUse consistent function naming. Instead of SSL_CTX_set_custom_cli_ext and SSL_CTX_set_custom_srv_ext use SSL_CTX_add_client_custom_ext and SSL_CTX_add_server_custom_ext. Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit 8cafe9e8bfcc99d12adf083c61411955995668c4)28 August 2014, 17:10:21 UTC
46a1b9e Dr. Stephen Henson19 August 2014, 12:33:51 UTCNew function SSL_extension_supported(). Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit c846a5f5678a7149bc6cbd37dbdae886a5108364)28 August 2014, 17:10:21 UTC
6db2239 Dr. Stephen Henson16 August 2014, 17:16:26 UTCNew extension callback features. Support separate parse and add callback arguments. Add new callback so an application can free extension data. Change return value for send functions so < 0 is an error 0 omits extension and > 0 includes it. This is more consistent with the behaviour of other functions in OpenSSL. Modify parse_cb handling so <= 0 is an error. Make SSL_CTX_set_custom_cli_ext and SSL_CTX_set_custom_cli_ext argument order consistent. NOTE: these changes WILL break existing code. Remove (now inaccurate) in line documentation. Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit 33f653adf3bff5b0795e22de1f54b7c5472252d0)28 August 2014, 17:10:21 UTC
423ceb8 Dr. Stephen Henson14 August 2014, 12:25:50 UTCCallback revision. Use "parse" and "add" for function and callback names instead of "first" and "second". Change arguments to callback so the extension type is unsigned int and the buffer length is size_t. Note: this *will* break existing code. Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit de2a9e38f39eacc2e052d694f5b5fa5b7e734abc)28 August 2014, 17:10:21 UTC
cd2e170 Dr. Stephen Henson12 August 2014, 15:18:55 UTCRemove serverinfo checks. Since sanity checks are performed for all custom extensions the serverinfo checks are no longer needed. Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit 707b026d7871eb12c23671c975e6a15a8c331785) Conflicts: ssl/ssl3.h ssl/t1_lib.c28 August 2014, 17:09:59 UTC
9346c75 Dr. Stephen Henson12 August 2014, 13:25:49 UTCAdd custom extension sanity checks. Reject attempts to use extensions handled internally. Add flags to each extension structure to indicate if an extension has been sent or received. Enforce RFC5246 compliance by rejecting duplicate extensions and unsolicited extensions and only send a server extension if we have sent the corresponding client extension. Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit 28ea0a0c6a5e4e217c405340fa22a8503c7a17db)28 August 2014, 17:09:39 UTC
0a4fe37 Dr. Stephen Henson10 August 2014, 11:08:08 UTCCustom extension revision. Use the same structure for client and server custom extensions. Add utility functions in new file t1_ext.c. Use new utility functions to handle custom server and client extensions and remove a lot of code duplication. Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit ecf4d660902dcef6e0afc51d52926f00d409ee6b) Conflicts: ssl/ssl_lib.c ssl/ssl_locl.h ssl/t1_lib.c28 August 2014, 17:09:05 UTC
da67a0a Dr. Stephen Henson05 August 2014, 14:21:36 UTCRevision of custom extension code. Move custom extension structures from SSL_CTX to CERT structure. This change means the form can be revised in future without binary compatibility issues. Also since CERT is part of SSL structures so per-SSL custom extensions could be supported in future as well as per SSL_CTX. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit b83294fe3022b9d5d525ccdcfeb53d39c25b05bd) Conflicts: ssl/ssl.h ssl/ssl_cert.c ssl/ssl_locl.h28 August 2014, 16:06:50 UTC
9a9b0c0 Emilia Kasper28 August 2014, 13:33:34 UTCConstant-time utilities Pull constant-time methods out to a separate header, add tests. Reviewed-by: Bodo Moeller <bodo@openssl.org> (cherry picked from commit 5a3d21c0585064292bde5cd34089e120487ab687) Conflicts: ssl/s3_cbc.c test/Makefile28 August 2014, 14:26:01 UTC
b85d461 Raphael Spreitzer28 August 2014, 02:53:10 UTCRT2400: ASN1_STRING_to_UTF8 missing initializer Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit f9fb43e176ad2a914108cd2b403425dc1ebc7262)28 August 2014, 02:59:40 UTC
089f10e Rich Salz28 August 2014, 01:43:25 UTCRT2308: Add extern "C" { ... } wrapper Add the wrapper to all public header files (Configure generates one). Don't bother for those that are just lists of #define's that do renaming. Reviewed-by: Tim Hudson <tjh@openssl.org> Cherry-pick of commit 17e80c6bd05de7406a65116f34ed59665607d8d528 August 2014, 01:45:09 UTC
7f7c05c Emilia Kasper25 August 2014, 10:38:16 UTCExplicitly check for empty ASN.1 strings in d2i_ECPrivateKey The old code implicitly relies on the ASN.1 code returning a \0-prefixed buffer when the buffer length is 0. Change this to verify explicitly that the ASN.1 string has positive length. Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit 82dc08de54ce443c2a9ac478faffe79e76157795)27 August 2014, 17:50:15 UTC
2083f7c Matt Caswell22 August 2014, 16:04:19 UTCRT3065: automatically generate a missing EC public key When d2i_ECPrivateKey reads a private key with a missing (optional) public key, generate one automatically from the group and private key. Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit ed383f847156940e93f256fed78599873a4a9b28)27 August 2014, 17:50:15 UTC
1f2b943 Adam Langley23 April 2013, 19:12:36 UTCRT3065: ec_private_key_dont_crash This change saves several EC routines from crashing when an EC_KEY is missing a public key. The public key is optional in the EC private key format and, without this patch, running the following through `openssl ec` causes a crash: -----BEGIN EC PRIVATE KEY----- MBkCAQEECAECAwQFBgcIoAoGCCqGSM49AwEH -----END EC PRIVATE KEY----- Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit b391570bdeb386d4fd325917c248d593d3c43930)27 August 2014, 17:50:15 UTC
dc5c3d7 Mihai Militaru26 August 2014, 16:35:54 UTCRT2210: Add missing EVP_cleanup to example I also removed some trailing whitespace and cleaned up the "see also" list. Reviewed-by: Emilia Kasper <emilia@openssl.org> (cherry picked from commit 7b3e11c54466f1da8b707c932e308d345fd61101)27 August 2014, 17:25:36 UTC
383f0e3 John Fitzgibbon18 August 2014, 21:55:19 UTCRT2724: Remove extra declaration Extra SSL_get_selected_srtp_profile() declaration in ssl/srtp.h causes -Werror builds to fail. Cherry-picked from 3609b02305c3678525930ff9bacb566c0122ea2a Reviewed-by: Tim Hudson <tjh@openssl.org>26 August 2014, 20:55:54 UTC
0a64a86 David Gatwood26 August 2014, 17:02:03 UTCRT1744: SSL_CTX_set_dump_dh() doc feedback The description of when the server creates a DH key is confusing. This cleans it up. (rsalz: also removed trailing whitespace.) Reviewed-by: Viktor Dukhovni <viktor@openssl.org>26 August 2014, 17:38:27 UTC
dec1283 Jan Schaumann15 August 2014, 03:00:44 UTCRT1804: fix EXAMPLE in EVP_EncryptInit.pod The EXAMPLE that used FILE and RC2 doesn't compile due to a few minor errors. Tweak to use IDEA and AES-128. Remove examples about RC2 and RC5. Reviewed-by: Emilia Kasper <emilia@openssl.org>25 August 2014, 14:26:17 UTC
1d4f214 Matt Caswell24 July 2014, 05:00:11 UTCTypo fixes to evp documentation. This patch was submitted by user "Kox" via the wiki Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 2dd8cb3b9593f528d9537aa6a003d5c93df1e3c5)24 August 2014, 20:26:02 UTC
3aac17a Adam Langley19 August 2014, 15:57:53 UTCRT3060: Limit the number of empty records. Limit the number of empty records that will be processed consecutively in order to prevent ssl3_get_record from never returning. Reported by "oftc_must_be_destroyed" and George Kadianakis. Reviewed-by: Bodo Moeller <bodo@openssl.org>22 August 2014, 13:36:06 UTC
e19c938 Adam Langley21 February 2013, 22:11:55 UTCRT3061: Don't SEGFAULT when trying to export a public DSA key as a private key. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org>22 August 2014, 13:21:12 UTC
108e907 Emilia Kasper22 August 2014, 11:16:55 UTCImprove EVP_PKEY_sign documentation Clarify the intended use of EVP_PKEY_sign. Make the code example compile. Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit d64c533a207f7b6d86c3bc8ffb053e5f4d0c1ca0)22 August 2014, 13:05:55 UTC
8958be3 Emilia Kasper19 August 2014, 11:18:07 UTCdefine inline for Visual Studio In Visual Studio, inline is available in C++ only, however __inline is available for C, see http://msdn.microsoft.com/en-us/library/z8y1yy88.aspx Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit f511b25a7370c775dc9fd6198dbacd1706cf242b)21 August 2014, 14:07:44 UTC
ebf221e Emilia Kasper19 August 2014, 14:28:07 UTCFix build when BSAES_ASM is defined but VPAES_ASM is not Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit da92be4d68bec81030838e3228ef0238c565af85)21 August 2014, 13:48:10 UTC
ef90877 Andy Polyakov20 August 2014, 22:17:45 UTCbn/asm/rsaz-*.pl: allow spaces in Perl path name. RT: 2835 Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 15735e4f0e81d535cda0ad7ab52a0ed64b644cd0)20 August 2014, 22:19:24 UTC
a89adc1 Andy Polyakov20 August 2014, 22:13:55 UTCsha1-mb-x86_64.pl: add commentary. Reviewed-by: Emilia Kasper <emilia@openssl.org> (cherry picked from commit e608273a8094a95a5703c26a428a007497e74392)20 August 2014, 22:16:32 UTC
b698c42 Andy Polyakov20 August 2014, 20:18:14 UTCcrypto/evp/e_aes_cbc_hmac_sha[1|256].c: fix compiler warnings. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 2893a302a9b6a70161d1859d985a52af11b2195d)20 August 2014, 20:20:21 UTC
e99ac8b Andy Polyakov20 August 2014, 20:10:20 UTCsha1-mb-x86_64.pl: fix typo. Reviewed-by: Emilia Kasper <emilia@openssl.org> (cherry picked from commit 55eb14da201cc35fe744a08718f5c2efb97f6155)20 August 2014, 20:12:50 UTC
43312c6 Matt Caswell26 July 2014, 22:47:40 UTCFixed out-of-bounds read errors in ssl3_get_key_exchange. PR#3450 Reviewed-by: Emilia Käsper <emilia@openssl.org>15 August 2014, 22:28:52 UTC
beeb0fa Istvan Noszticzius15 August 2014, 15:43:28 UTCFix use after free bug. Reviewed-by: Stephen Henson <steve@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit 5afa57fb7b17aa51cfba1ffa94e900fc7a5f0e04)15 August 2014, 15:46:14 UTC
267e6f3 Bodo Moeller13 August 2014, 15:37:19 UTCFurther improve/fix ec_GFp_simple_points_make_affine (ecp_smpl.c) and group_order_tests (ectest.c). Also fix the EC_POINTs_mul documentation (ec.h). Reviewed-by: emilia@openssl.org13 August 2014, 15:40:33 UTC
5ed0b6a Dr. Stephen Henson08 August 2014, 10:24:25 UTCFix SRP authentication ciphersuites. The addition of SRP authentication needs to be checked in various places to work properly. Specifically: A certificate is not sent. A certificate request must not be sent. Server key exchange message must not contain a signature. If appropriate SRP authentication ciphersuites should be chosen. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 8f5a8805b82d1ae81168b11b7f1506db9e047dec)08 August 2014, 23:09:14 UTC
90a549d Dr. Stephen Henson08 August 2014, 10:19:39 UTCTest SRP authentication ciphersuites. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 193c1c07165b0042abd217274a084b49459d4443)08 August 2014, 23:09:01 UTC
bc79281 Dr. Stephen Henson07 August 2014, 00:08:14 UTCOnly use FIPS EC methods in FIPS mode. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 1433cac53c93f9f109290389f60b17078a572d3d)07 August 2014, 01:11:53 UTC
bb4c9ff Dr. Stephen Henson01 August 2014, 13:56:56 UTCCheck SRP parameters early. Check SRP parameters when they are received so we can send back an appropriate alert. Reviewed-by: Kurt Roeckx <kurt@openssl.org>06 August 2014, 19:41:53 UTC
5334878 Dr. Stephen Henson31 July 2014, 19:56:22 UTCFix SRP buffer overrun vulnerability. Invalid parameters passed to the SRP code can be overrun an internal buffer. Add sanity check that g, A, B < N to SRP code. Thanks to Sean Devlin and Watson Ladd of Cryptography Services, NCC Group for reporting this issue.06 August 2014, 19:41:24 UTC
f338c2e Dr. Stephen Henson24 July 2014, 23:50:06 UTCFix SRP ciphersuite DoS vulnerability. If a client attempted to use an SRP ciphersuite and it had not been set up correctly it would crash with a null pointer read. A malicious server could exploit this in a DoS attack. Thanks to Joonas Kuorilehto and Riku Hietamäki from Codenomicon for reporting this issue. CVE-2014-2970 Reviewed-by: Tim Hudson <tjh@openssl.org>06 August 2014, 19:41:24 UTC
92aa73b Gabor Tyukasz23 July 2014, 21:42:06 UTCFix race condition in ssl_parse_serverhello_tlsext CVE-2014-3509 Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Dr. Stephen Henson <steve@openssl.org>06 August 2014, 19:41:24 UTC
c01618d Emilia Kasper02 July 2014, 17:02:33 UTCFix OID handling: - Upon parsing, reject OIDs with invalid base-128 encoding. - Always NUL-terminate the destination buffer in OBJ_obj2txt printing function. CVE-2014-3508 Reviewed-by: Dr. Stephen Henson <steve@openssl.org> Reviewed-by: Kurt Roeckx <kurt@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org>06 August 2014, 19:41:24 UTC
1d7d0ed Emilia Käsper24 July 2014, 20:15:29 UTCFix DTLS anonymous EC(DH) denial of service CVE-2014-3510 Reviewed-by: Dr. Stephen Henson <steve@openssl.org>06 August 2014, 19:41:24 UTC
40a2200 David Benjamin23 July 2014, 20:32:21 UTCFix protocol downgrade bug in case of fragmented packets CVE-2014-3511 Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Bodo Möller <bodo@openssl.org>06 August 2014, 19:41:24 UTC
d345a24 Adam Langley06 June 2014, 21:47:07 UTCRemove some duplicate DTLS code. In a couple of functions, a sequence number would be calculated twice. Additionally, in |dtls1_process_out_of_seq_message|, we know that |frag_len| <= |msg_hdr->msg_len| so the later tests for |frag_len < msg_hdr->msg_len| can be more clearly written as |frag_len != msg_hdr->msg_len|, since that's the only remaining case. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org>06 August 2014, 19:41:24 UTC
3d5dcea Matt Caswell24 July 2014, 22:54:28 UTCApplying same fix as in dtls1_process_out_of_seq_message. A truncated DTLS fragment would cause *ok to be clear, but the return value would still be the number of bytes read. Problem identified by Emilia Käsper, based on previous issue/patch by Adam Langley. Reviewed-by: Emilia Käsper <emilia@openssl.org>06 August 2014, 19:41:23 UTC
aad61c0 Adam Langley06 June 2014, 21:44:20 UTCFix return code for truncated DTLS fragment. Previously, a truncated DTLS fragment in |dtls1_process_out_of_seq_message| would cause *ok to be cleared, but the return value would still be the number of bytes read. This would cause |dtls1_get_message| not to consider it an error and it would continue processing as normal until the calling function noticed that *ok was zero. I can't see an exploit here because |dtls1_get_message| uses |s->init_num| as the length, which will always be zero from what I can see. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org>06 August 2014, 19:41:23 UTC
8ca4c4b Adam Langley06 June 2014, 21:30:33 UTCFix memory leak from zero-length DTLS fragments. The |pqueue_insert| function can fail if one attempts to insert a duplicate sequence number. When handling a fragment of an out of sequence message, |dtls1_process_out_of_seq_message| would not call |dtls1_reassemble_fragment| if the fragment's length was zero. It would then allocate a fresh fragment and attempt to insert it, but ignore the return value, leaking the fragment. This allows an attacker to exhaust the memory of a DTLS peer. Fixes CVE-2014-3507 Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org>06 August 2014, 19:41:23 UTC
0598468 Matt Caswell06 June 2014, 21:25:52 UTCFix DTLS handshake message size checks. In |dtls1_reassemble_fragment|, the value of |msg_hdr->frag_off+frag_len| was being checked against the maximum handshake message size, but then |msg_len| bytes were allocated for the fragment buffer. This means that so long as the fragment was within the allowed size, the pending handshake message could consume 16MB + 2MB (for the reassembly bitmap). Approx 10 outstanding handshake messages are allowed, meaning that an attacker could consume ~180MB per DTLS connection. In the non-fragmented path (in |dtls1_process_out_of_seq_message|), no check was applied. Fixes CVE-2014-3506 Wholly based on patch by Adam Langley with one minor amendment. Reviewed-by: Emilia Käsper <emilia@openssl.org>06 August 2014, 19:41:23 UTC
ea7cb53 Matt Caswell24 July 2014, 22:33:34 UTCAdded comment for the frag->reassembly == NULL case as per feedback from Emilia Reviewed-by: Emilia Käsper <emilia@openssl.org>06 August 2014, 19:41:23 UTC
4985007 Adam Langley06 June 2014, 21:19:21 UTCAvoid double free when processing DTLS packets. The |item| variable, in both of these cases, may contain a pointer to a |pitem| structure within |s->d1->buffered_messages|. It was being freed in the error case while still being in |buffered_messages|. When the error later caused the |SSL*| to be destroyed, the item would be double freed. Thanks to Wah-Teh Chang for spotting that the fix in 1632ef74 was inconsistent with the other error paths (but correct). Fixes CVE-2014-3505 Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org>06 August 2014, 19:41:23 UTC
back to top