Skip to main content
swh:1:snp:dc2a5002442a00b1c0eda7c65d04ea7455e166cd
sort by:
RevisionAuthorDateMessageCommit Date
d1c28d7 Matt Caswell20 November 2018, 13:35:35 UTCPrepare for 1.1.1a release Reviewed-by: Richard Levitte <levitte@openssl.org>20 November 2018, 13:35:35 UTC
7c6d372 Matt Caswell20 November 2018, 13:20:01 UTCUpdate copyright year Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7669)20 November 2018, 13:27:36 UTC
d90d853 Matt Caswell20 November 2018, 10:52:53 UTCUpdate CHANGES and NEWS for new release Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com> (Merged from https://github.com/openssl/openssl/pull/7664)20 November 2018, 11:54:46 UTC
cc330c7 Richard Levitte15 November 2018, 23:28:00 UTCConfiguration: only include shared_sources in dirinfo in shared config Without this precaution, we end up having directory targets depend on shlib object files for which there are no rules. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/7645)19 November 2018, 17:26:03 UTC
610ea18 Richard Levitte19 November 2018, 09:21:49 UTCUnix build: for mingw and cygwin, create the right location for DLLs Mingw and Cygwin builds install the DLLs in the application directory, not the library directory, so ensure that one is created for them when installing the DLLs. Fixes #7653 Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7654) (cherry picked from commit 9694ebf753e571a55935a63b4df8016e7bd3248d)19 November 2018, 09:56:38 UTC
7a6d71c Andy Polyakov15 November 2018, 14:47:46 UTCsha/asm/sha512p8-ppc.pl: optimize epilogue. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7643) (cherry picked from commit 6b956fe77b8aeb899ef7bdfa147a00bda51b804a)16 November 2018, 08:26:29 UTC
0e2ad95 Andy Polyakov15 November 2018, 14:42:02 UTCsha/asm/sha512p8-ppc.pl: fix typo in prologue. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7643) (cherry picked from commit 79d7fb990cd28bbe2888ed8f9051ab54c9f986b0)16 November 2018, 08:26:28 UTC
b339340 Richard Levitte15 November 2018, 12:45:31 UTCtest/siphash_internal_test.c: ensure the SIPHASH structure is zeroed Fixes #7641 [extended tests] Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7642) (cherry picked from commit c7af8b0a267981c25cc42643493289a01ffe1bbd)15 November 2018, 14:35:49 UTC
42acb69 Vitezslav Cizek25 October 2018, 11:53:26 UTCDSA: Check for sanity of input parameters dsa_builtin_paramgen2 expects the L parameter to be greater than N, otherwise the generation will get stuck in an infinite loop. Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (cherry picked from commit 3afd38b277a806b901e039c6ad281c5e5c97ef67) (Merged from https://github.com/openssl/openssl/pull/7493)14 November 2018, 12:07:54 UTC
eaa32f3 Matt Caswell12 November 2018, 14:23:07 UTCFix no-ec and no-tls1_2 Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7620) (cherry picked from commit 65d2c16cbe0da8efed2f285f59930297326fb435)14 November 2018, 11:33:24 UTC
e0e5241 Richard Levitte13 November 2018, 16:57:45 UTCFix typo in util/perl/OpenSSL/Test.pm Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/7633) (cherry picked from commit 2dc37bc2b4c678462a24d2904604e58c0c5ac1cb)13 November 2018, 23:54:29 UTC
c8bcea9 Richard Levitte13 November 2018, 17:28:41 UTCtest/recipes/90-test_shlibload.t needs $target{shared_extension} We therefore must add defaults. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7626) (cherry picked from commit 45cdae1c7c93fe7ef2a981da4c36c3b8cb09e855)13 November 2018, 23:42:58 UTC
8673631 Richard Levitte12 November 2018, 23:16:55 UTCFix rpath-related Linux "test_shlibload" failure. When libssl and libcrypto are compiled on Linux with "-rpath", but not "--enable-new-dtags", the RPATH takes precedence over LD_LIBRARY_PATH, and we end up running with the wrong libraries. This is resolved by using full (or at least relative, rather than just the filename to be found on LD_LIBRARY_PATH) paths to the shared objects. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7626) (cherry picked from commit 18289399743da6c3db462f37fc8797738e8acf7c)13 November 2018, 23:42:57 UTC
0c594cc Richard Levitte13 November 2018, 17:49:21 UTCConfiguration: make sure the shared_sources table doesn't contain empty elements Fixes #7634 Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7635)13 November 2018, 17:49:37 UTC
45f2472 Viktor Dukhovni10 November 2018, 06:53:56 UTCAdded missing signature algorithm reflection functions SSL_get_signature_nid() -- local signature algorithm SSL_get_signature_type_nid() -- local signature algorithm key type SSL_get_peer_tmp_key() -- Peer key-exchange public key SSL_get_tmp_key -- local key exchange public key Aliased pre-existing SSL_get_server_tmp_key(), which was formerly just for clients, to SSL_get_peer_tmp_key(). Changed internal calls to use the new name. Reviewed-by: Matt Caswell <matt@openssl.org>12 November 2018, 21:53:32 UTC
44197e9 Matt Caswell01 November 2018, 11:53:49 UTCMerge the CA list documentation for clarity Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7503) (cherry picked from commit 6e68dae85a8f91944370125561c7ec0d5da46c20)12 November 2018, 14:38:47 UTC
3513065 Matt Caswell26 October 2018, 17:23:48 UTCAdd a test for SSL_CTX_set0_CA_list()/SSL_CTX_set_client_CA_list() Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7503) (cherry picked from commit fb8c83599e869516552f7c27bdc4dd26947fe657)12 November 2018, 14:38:47 UTC
b4970e8 Matt Caswell26 October 2018, 10:43:19 UTCSeparate ca_names handling for client and server SSL(_CTX)?_set_client_CA_list() was a server side only function in 1.1.0. If it was called on the client side then it was ignored. In 1.1.1 it now makes sense to have a CA list defined for both client and server (the client now sends it the the TLSv1.3 certificate_authorities extension). Unfortunately some applications were using the same SSL_CTX for both clients and servers and this resulted in some client ClientHellos being excessively large due to the number of certificate authorities being sent. This commit seperates out the CA list updated by SSL(_CTX)?_set_client_CA_list() and the more generic SSL(_CTX)?_set0_CA_list(). This means that SSL(_CTX)?_set_client_CA_list() still has no effect on the client side. If both CA lists are set then SSL(_CTX)?_set_client_CA_list() takes priority. Fixes #7411 Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7503) (cherry picked from commit 98732979001dbb59320803713c4c91ba40234250)12 November 2018, 14:38:47 UTC
02d3c6a Richard Levitte01 November 2018, 12:55:32 UTCConfigure: ensure empty arrays aren't created inadvertently Just refering to a hash table element as an array reference will automatically create that element. Avoid that by defaulting to a separate empty array reference. Fixes #7543 Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7544) (cherry picked from commit 3bed01a09071fb289484dfd265f0a8a991537282)12 November 2018, 11:40:24 UTC
7bd5405 Matt Caswell24 October 2018, 13:48:44 UTCTest use of a brainpool ECDSA certificate Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7442) (cherry picked from commit 24ae00388fb9e25af8f94d36b7c191ae90061586)12 November 2018, 11:19:58 UTC
b3b9049 Matt Caswell24 October 2018, 11:15:56 UTCAdd some test brainpool certificates Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7442) (cherry picked from commit 83c81eebed52aa84b6b34d26e984c859158ca1c0)12 November 2018, 11:19:58 UTC
6f54ae7 Matt Caswell19 October 2018, 13:01:22 UTCDon't negotiate TLSv1.3 if our EC cert isn't TLSv1.3 capable TLSv1.3 is more restrictive about the curve used. There must be a matching sig alg defined for that curve. Therefore if we are using some other curve in our certificate then we should not negotiate TLSv1.3. Fixes #7435 Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7442) (cherry picked from commit de4dc598024fd0a9c2b7a466fd5323755d369522)12 November 2018, 11:19:58 UTC
61e78e7 Richard Levitte11 November 2018, 11:23:26 UTCFix SipHash init order. Setting the SipHash hash size and setting its key is done with two independent functions... and yet, the internals depend on both. Unfortunately, the function to change the size wasn't adapted for the possibility that the key was set first, with a different hash size. This changes the hash setting function to fix the internal values (which is easy, fortunately) according to the hash size. evpmac.txt value for digestsize:8 is also corrected. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7613) (cherry picked from commit 425036130dfb3cfbef5937772f7526ce60133264)12 November 2018, 06:16:58 UTC
e37b701 Tomas Mraz12 October 2018, 15:24:14 UTCUnbreak SECLEVEL 3 regression causing it to not accept any ciphers. Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Richard Levitte <levitte@openssl.org> GH: #7391 (cherry picked from commit 75b68c9e4e8591a4ebe083cb207aeb121baf549f)10 November 2018, 20:30:27 UTC
98f6297 Mansour Ahmadi17 October 2018, 22:13:57 UTCCheck return value of EVP_PKEY_new Reviewed-by: Paul Yang <yang.yang@baishancloud.com> Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7427) (cherry picked from commit d896b79b0994a35ecfd1c8e729d348d67236150e)10 November 2018, 02:42:29 UTC
6f17215 Billy Brumley09 November 2018, 07:25:43 UTC[crypto/bn] swap BN_FLG_FIXED_TOP too Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com> (Merged from https://github.com/openssl/openssl/pull/7599) (cherry picked from commit dd41956d80686638d74fd203bd67060f90966280)10 November 2018, 02:14:11 UTC
bdb8897 Bernd Edlinger07 November 2018, 20:53:30 UTCFix issues with do_rand_init/rand_cleanup_int Fixes #7022 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7588) (cherry picked from commit e2d227bb4a25bb75354a40816439630a8162f073)09 November 2018, 12:37:38 UTC
37044f4 Richard Levitte09 November 2018, 11:23:53 UTCVMS build: colon after target must be separated with a space ... otherwise, it's taken to be part of a device name. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7602) (cherry picked from commit e9994901f835420764d020968d4588fc09ec74c3)09 November 2018, 11:30:11 UTC
201a33f Richard Levitte07 November 2018, 15:13:57 UTCHave install targets depend on more precise build targets We only had the main 'install' target depend on 'all'. This changes the dependencies so targets like install_dev, install_runtime_libs, install_engines and install_programs depend on build targets that are correspond to them more specifically. This increases the parallel possibilities. Fixes #7466 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7583) (cherry picked from commit e8d01a608705e4320082a11a3870aa7e19c7290f)09 November 2018, 05:20:52 UTC
d582f15 Richard Levitte25 October 2018, 07:09:20 UTCAllow parallel install When trying 'make -j{n} install', you may occasionally run into trouble because to sub-targets (install_dev and install_runtime) try to install the same shared libraries. That makes parallel install difficult. This is solved by dividing install_runtime into two parts, one for libraries and one for programs, and have install_dev depend on install_runtime_libs instead of installing the shared runtime libraries itself. Fixes #7466 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7583) (cherry picked from commit c1123d9f7efb005a109aeccaba82c40bf9bd4c1d)09 November 2018, 05:20:51 UTC
0178459 Paul Yang01 November 2018, 15:27:31 UTCFix a doc-nit in EVP_PKEY_CTX_ctrl.pod [skip-ci] Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7546) (cherry picked from commit e5a8712d03334c4b7cb9f29d6d1daee399c1223e)09 November 2018, 04:54:18 UTC
abf58ed Dr. Matthias St. Pierre18 October 2018, 11:27:14 UTCrand_unix.c: open random devices on first use only Commit c7504aeb640a (pr #6432) fixed a regression for applications in chroot environments, which compensated the fact that the new OpenSSL CSPRNG (based on the NIST DRBG) now reseeds periodically, which the previous one didn't. Now the reseeding could fail in the chroot environment if the DEVRANDOM devices were not present anymore and no other entropy source (e.g. getrandom()) was available. The solution was to keep the file handles for the DEVRANDOM devices open by default. In fact, the fix did more than this, it opened the DEVRANDOM devices early and unconditionally in rand_pool_init(), which had the unwanted side effect that the devices were opened (and kept open) even in cases when they were not used at all, for example when the getrandom() system call was available. Due to a bug (issue #7419) this even happened when the feature was disabled by the application. This commit removes the unconditional opening of all DEVRANDOM devices. They will now only be opened (and kept open) on first use. In particular, if getrandom() is available, the handles will not be opened unnecessarily. This change does not introduce a regression for applications compiled for libcrypto 1.1.0, because the SSLEAY RNG also seeds on first use. So in the above constellation the CSPRNG will only be properly seeded if it is happens before the forking and chrooting. Fixes #7419 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7437) (cherry picked from commit 8cfc19716c22dac737ec8cfc5f7d085e7c37f4d8)08 November 2018, 15:41:24 UTC
cdf3350 Dr. Matthias St. Pierre25 October 2018, 23:13:19 UTCTest: enable internal tests for shared Windows builds Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7462) (cherry picked from commit 1901516a4ba909fff12e0e7815aa2d499f4d6d67)08 November 2018, 15:32:35 UTC
c39df74 Dr. Matthias St. Pierre22 October 2018, 16:05:14 UTCTest: link drbgtest statically against libcrypto and remove duplicate rand_drbg_seedlen() implementation again. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7462) (cherry picked from commit 1c615e4ce97715ae3af9255bc57be32a49687966)08 November 2018, 15:32:30 UTC
efd67e0 Matt Caswell26 October 2018, 14:29:15 UTCGive a better error if an attempt is made to set a zero length groups list Previously we indicated this as a malloc failure which isn't very helpful. Reviewed-by: Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/7479) (cherry picked from commit 680bd131b69d57e891888ab70d300176a5a16617)08 November 2018, 11:31:22 UTC
f306b9e Matt Caswell24 October 2018, 09:11:00 UTCIgnore disabled ciphers when deciding if we are using ECC use_ecc() was always returning 1 because there are default (TLSv1.3) ciphersuites that use ECC - even if those ciphersuites are disabled by other options. Fixes #7471 Reviewed-by: Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/7479) (cherry picked from commit 589b6227a85ea0133fe91d744b16dd72edee929a)08 November 2018, 11:31:22 UTC
f725848 Pauli07 November 2018, 21:22:01 UTCAdd missing RAND initialisation call. Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/7587) (cherry picked from commit ac765685d4b08a48cefffc71c434760045154dad)07 November 2018, 22:13:16 UTC
294941a Bernd Edlinger05 November 2018, 22:13:11 UTCRename the rand_drbg_st data member "pool" to "seed_pool" ... to make the intended use more clear and differentiate it from the data member "adin_pool". Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7575) (cherry picked from commit 31f32abb8eb2a3ebd8500e6e0460b4a6791e5ed7)07 November 2018, 14:23:39 UTC
9bc987f Bernd Edlinger30 October 2018, 22:09:56 UTCInitialize reseed_gen_counter to 1, like it is done in master Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7532)07 November 2018, 14:16:19 UTC
4274ef9 Richard Levitte01 November 2018, 13:02:21 UTCutil/add-depends.pl: go through shared_sources too Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7545) (cherry picked from commit 3866b2247fb7904a4e660593a16365147f479415)07 November 2018, 13:40:02 UTC
7b7fdf8 Bernd Edlinger30 October 2018, 21:21:34 UTCFix a race condition in drbgtest.c Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7531) (cherry picked from commit 2bb1b5ddd12c23bbfa7fb60ee3296612ca943fef)05 November 2018, 22:00:57 UTC
939ef2e Bernd Edlinger27 October 2018, 09:31:21 UTCAvoid two memory allocations in each RAND_DRBG_bytes Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7518)05 November 2018, 21:52:24 UTC
c40c1ef Bernd Edlinger02 November 2018, 10:46:38 UTCFix error handling in RAND_DRBG_uninstantiate Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7519)05 November 2018, 21:46:21 UTC
fd59e42 Bernd Edlinger30 October 2018, 20:02:22 UTCFix error handling in drbgtest.c Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7519)05 November 2018, 21:46:20 UTC
ee5a791 Bernd Edlinger30 October 2018, 19:57:53 UTCFix error handling in rand_drbg_new Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7519)05 November 2018, 21:46:20 UTC
f98a893 Bernd Edlinger29 October 2018, 12:48:53 UTCFix error handling in RAND_DRBG_set Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7519)05 November 2018, 21:46:20 UTC
0f316a0 Pauli05 November 2018, 21:06:25 UTCFix return formatting. Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/7564) (cherry picked from commit 2087028612027368e9508e1b253aab715a5a35d6)05 November 2018, 21:09:00 UTC
030da74 Pauli05 November 2018, 01:04:23 UTCCleanse the key log buffer. Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/7564) (cherry picked from commit e931f370aa38d8645b35fb8d6260cb44d37b6b61)05 November 2018, 21:08:30 UTC
33a37a6 Benjamin Kaduk22 October 2018, 16:54:20 UTCRestore sensible "sess_accept" counter tracking Commit 9ef9088c1585e13b9727796f15f77da64dbbe623 switched the SSL/SSL_CTX statistics counters to using Thread-Sanitizer-friendly primitives. However, it erroneously converted an addition of -1 (for s->session_ctx->stats.sess_accept) to an addition of +1, since that is the only counter API provided by the internal tsan_assist.h header until the previous commit. This means that for each accepted (initial) connection, the session_ctx's counter would get doubly incremented, and the (switched) ctx's counter would also get incremented. Restore the counter decrement so that each accepted connection increments exactly one counter exactly once (in net effect). Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7464) (cherry picked from commit 2aaa0b146b967397a6e61fa8df969e7847f82086)04 November 2018, 04:27:12 UTC
a649b52 Benjamin Kaduk22 October 2018, 16:51:35 UTCAdd tsan_decr() API, counterpart of tsan_counter() The existing tsan_counter() API increments a reference counter. Provide a new API, tsan_decr(), to decrement such a reference counter. This can be used, for example, when a reference is added to the session_ctx's sess_accept stats but should more properly be tracked in the regular ctx's statistics. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7464) (cherry picked from commit 95658c32436017aeeef3d8598957071baf6769a9)04 November 2018, 04:27:11 UTC
cd01707 Richard Levitte02 November 2018, 09:24:24 UTCcrypto/engine/eng_devcrypto.c: ensure we don't leak resources If engine building fails for some reason, we must make sure to close the /dev/crypto handle. Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/7506) (cherry picked from commit 681e8cacdbdc44ac00af29b6656fc52745a9baa2)02 November 2018, 19:24:08 UTC
120fc33 Richard Levitte31 October 2018, 18:23:44 UTCcrypto/engine/eng_devcrypto.c: open /dev/crypto only once We opened /dev/crypto once for each session, which is quite unnecessary. With this change, we open /dev/crypto once at engine init, and close it on unload. Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/7506) (cherry picked from commit 458c7dad9e3f59490fb0908c1a27ca39e4cf38dd)02 November 2018, 19:24:00 UTC
dcbbcf0 Richard Levitte27 October 2018, 07:26:22 UTCcrypto/engine/eng_devcrypto.c: new compilers are strict on prototypes Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/7506) (cherry picked from commit 28ac1bd9a97d9725273956e26d89ccfa5b4de67b)02 November 2018, 19:23:53 UTC
3dcca12 Richard Levitte27 October 2018, 07:15:04 UTCcrypto/engine/eng_devcrypto.c: add digest copy Copying an EVP_MD_CTX, including the implementation local bits, is a necessary operation. In this case, though, it's the same as initializing the local bits to be "copied to". Fixes #7495 Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/7506) (cherry picked from commit 36af124bfb209b49cb92a5fb9fab627d9cd4a44b)02 November 2018, 19:23:47 UTC
b33e769 Richard Levitte18 October 2018, 22:36:04 UTCapps: Stop pretending to care about Netscape keys The documentation says some commands care, but the code says differently. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7440) (cherry picked from commit d91d443f0d26262148d1dc9d29f9fdf025b958ca)02 November 2018, 09:59:17 UTC
6039651 Pauli31 October 2018, 22:44:11 UTCAdd a constant time flag to one of the bignums to avoid a timing leak. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7549) (cherry picked from commit 00496b6423605391864fbbd1693f23631a1c5239)01 November 2018, 22:14:35 UTC
222b0a8 Richard Levitte21 October 2018, 09:11:04 UTCConfiguration: when building the dirinfo structure, include shared_sources This makes sure that any resulting directory target in the build files also depend on object files meant for shared libraries. As a side effect, we move the production of the dirinfo structure from common.tmpl to Configure, to make it easier to check the result. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7452) (cherry picked from commit b6e660754c2e799cffe4906269fcace0e07c73bc)31 October 2018, 14:47:56 UTC
3b1928f Andy Polyakov19 October 2018, 20:24:30 UTCConfigurations/15-android.conf: detect NDK llvm-ar. This excluses user from additional PATH adjustments in case NDK has llvm-ar. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7443) (cherry picked from commit ddf2e8c8ccad49cff0d6a0a0b26ca892ec4ce33a)31 October 2018, 14:45:03 UTC
3453dbd Andy Polyakov19 October 2018, 14:03:28 UTCConfigurations/15-android.conf: fix implicit __ANDROID_API__ handling. 03ad7c009e16a233c733098db3169c560142ccd3 failed if one didn't pass explicit -D__ANDROID_API__=N :-( Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7443) (cherry picked from commit 71f2b3171e8b94b0fbdc7fab2d7ca4ea66edec2b)31 October 2018, 14:45:03 UTC
faca6bf Bernd Edlinger29 October 2018, 12:48:53 UTCFix a race condition in drbg_add Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7523) (cherry picked from commit 4011bab1f85d4429bad1e9388bed90a8d0da5639)30 October 2018, 22:28:12 UTC
de8848a Matt Caswell16 October 2018, 11:42:59 UTCAdd a client_cert_cb test Reviewed-by: Ben Kaduk <kaduk@mit.edu> (Merged from https://github.com/openssl/openssl/pull/7413) (cherry picked from commit 6e46c065b9b97212d63ef1f321b08fb7fa6b320d)30 October 2018, 12:18:55 UTC
a2388b5 Matt Caswell11 October 2018, 16:01:06 UTCDon't call the client_cert_cb immediately in TLSv1.3 In TLSv1.2 and below a CertificateRequest is sent after the Certificate from the server. This means that by the time the client_cert_cb is called on receipt of the CertificateRequest a call to SSL_get_peer_certificate() will return the server certificate as expected. In TLSv1.3 a CertificateRequest is sent before a Certificate message so calling SSL_get_peer_certificate() returns NULL. To workaround this we delay calling the client_cert_cb until after we have processed the CertificateVerify message, when we are doing TLSv1.3. Fixes #7384 Reviewed-by: Ben Kaduk <kaduk@mit.edu> (Merged from https://github.com/openssl/openssl/pull/7413) (cherry picked from commit e45620140fce22c3251440063bc17440289d730c)30 October 2018, 12:18:55 UTC
5cf0f0e Dr. Matthias St. Pierre29 October 2018, 21:27:42 UTCrand_drbg.h: include <openssl/obj_mac.h> The RAND_DRBG_TYPE preprocessor define depends on a NID, so we have to include obj_mac.h to make the header selfcontained. Fixes #7521 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7524) (cherry picked from commit cf3d6ef7af7d6c47f5ccd4ce58d822972018b21c)30 October 2018, 07:03:06 UTC
189b56b Chocobo119 October 2018, 14:05:49 UTCFix MSVC warning C4819 CLA: trivial Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7444) (cherry picked from commit cf4eea12046445fc418507d2d5e14956b4353495)30 October 2018, 03:52:27 UTC
d308458 Richard Levitte26 October 2018, 11:42:40 UTCtest/evp_test.c: don't misuse pkey_test_ctrl() in mac_test_run() pkey_test_ctrl() was designed for parsing values, not for using in test runs. Relying on its returned value when it returned 1 even for control errors made it particularly useless for mac_test_run(). Here, it gets replaced with a MAC specific control function, that parses values the same way but is designed for use in a _run() rather than a _parse() function. This uncovers a SipHash test with an invalid control that wasn't caught properly. After all, that stanza is supposed to test that invalid control values do generate an error. Now we catch that. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7500) (cherry picked from commit ce5d64c79c4d809ece8fe28a5b62915467a1c0e1)29 October 2018, 16:32:27 UTC
86743ef Matt Caswell26 October 2018, 11:45:27 UTCAdd a test where we reuse the EVP_PKEY_CTX for two HKDF test runs Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7501) (cherry picked from commit 10d5b415f9e973f44f18eeaf2713868ec813e1d7)29 October 2018, 14:11:40 UTC
070ce40 Matt Caswell26 October 2018, 11:19:43 UTCReset the HKDF state between operations Fixes #7497 Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7501) (cherry picked from commit ca55d70be031746daddd8bd0611db54ed81f1737)29 October 2018, 14:11:40 UTC
7e01266 Richard Levitte23 October 2018, 08:35:48 UTCWindows build: build foo.d after foo.obj We made the build of foo.obj depend on foo.d, meaning the latter gets built first. Unfortunately, the way the compiler works, we are forced to redirect all output to foo.d, meaning that if the source contains an error, the build fails without showing those errors. We therefore remove the dependency and force the build of foo.d to always happen after build of foo.obj. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7469) (cherry picked from commit ecc347f5f53a9f2edc2805d50cba07db64267e8a)29 October 2018, 13:28:40 UTC
7ccfce8 Richard Levitte12 September 2018, 00:31:10 UTCssl/statem: Don't compare size_t with less than zero Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7194) (cherry picked from commit 60690b5b8396d7d5234cd067206190fb8aca78d2)29 October 2018, 13:25:45 UTC
a862a1d Richard Levitte12 September 2018, 00:30:25 UTCVMS & cryptoerr.h: include symhacks.h Needed to clear a clash between ERR_load_CRYPTO_strings and ERR_load_crypto_strings Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7194) (cherry picked from commit cc3a2e4f51679d99507a979f9a920f6068473aa2)29 October 2018, 13:25:45 UTC
bbc1c56 Richard Levitte12 September 2018, 00:28:35 UTCapps/rehash.c: Convert ISO-8859-1 to UTF-8 Believe it or not, the VMS C compiler is remarking on this Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7194) (cherry picked from commit 4602cc85aff35b7aa5e27dc57ead89f0867637f9)29 October 2018, 13:25:45 UTC
6101850 Bernd Edlinger26 October 2018, 19:06:14 UTCRework and simplify resource flow in drbg_add Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7504) (cherry picked from commit f9e43929c46b38667f67e02765fe0f1c0d3061d6)29 October 2018, 11:31:21 UTC
c7a7ed3 Dr. Matthias St. Pierre28 October 2018, 12:32:11 UTCrandfile.c: fix a Coverity warning Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7510) (cherry picked from commit 040a03470c7c5bf95fe8e6143db7bef357a22833)28 October 2018, 22:39:13 UTC
b1d6d55 Pauli26 October 2018, 00:54:58 UTCTiming vulnerability in ECDSA signature generation (CVE-2018-0735) Preallocate an extra limb for some of the big numbers to avoid a reallocation that can potentially provide a side channel. Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/7486) (cherry picked from commit 99540ec79491f59ed8b46b4edf130e17dc907f52)28 October 2018, 21:59:23 UTC
8abfe72 Pauli23 October 2018, 21:42:46 UTCTiming vulnerability in DSA signature generation (CVE-2018-0734). Avoid a timing attack that leaks information via a side channel that triggers when a BN is resized. Increasing the size of the BNs prior to doing anything with them suppresses the attack. Thanks due to Samuel Weiser for finding and locating this. Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/7486) (cherry picked from commit a9cfb8c2aa7254a4aa6a1716909e3f8cb78049b6)28 October 2018, 21:58:42 UTC
f1b12b8 Pauli28 October 2018, 20:50:51 UTCDSA mod inverse fix There is a side channel attack against the division used to calculate one of the modulo inverses in the DSA algorithm. This change takes advantage of the primality of the modulo and Fermat's little theorem to calculate the inverse without leaking information. Thanks to Samuel Weiser for finding and reporting this. Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/7487) (cherry picked from commit 415c33563528667868c3c653a612e6fc8736fd79)28 October 2018, 20:51:55 UTC
d2953e5 Dr. Matthias St. Pierre28 October 2018, 12:46:35 UTCdrbg_lib: avoid NULL pointer dereference in drbg_add Found by Coverity Scan Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7511) (cherry picked from commit 59f90557dd6e35cf72ac72016609d759ac78fcb9)28 October 2018, 18:21:12 UTC
54dea92 Richard Levitte15 October 2018, 16:37:18 UTCiOS config targets: disable "async" by default This also gave enough reason to collect the stuff that's common for all iOS config targets into the template "ios-common". Fixes #7318 Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7403) (cherry picked from commit 04e3f9a114c2c142356ef1639d68397a72e0c7f8)28 October 2018, 16:20:39 UTC
a14174a Dr. Matthias St. Pierre28 October 2018, 11:38:49 UTCConfigure: Improve warning if no random seed source was configured The new Configure summary box (41349b5e6db) now hides the warning about the missing seed source (2805ee1e095) too much. To make it more visible again, add warning markers. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7509) (cherry picked from commit caa8595276c60f009c8621ad466338d2ae39fb86)28 October 2018, 13:50:07 UTC
1f98527 Bernd Edlinger14 October 2018, 10:35:19 UTCFix data race in RAND_DRBG_generate Fixes #7394 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7399) (cherry picked from commit a83dc59afa2e0207180d7218efed19b20d48de95)27 October 2018, 11:04:55 UTC
d597a9a Dr. Matthias St. Pierre21 October 2018, 13:45:34 UTCRAND_add()/RAND_seed(): fix failure on short input or low entropy Commit 5b4cb385c18a (#7382) introduced a bug which had the effect that RAND_add()/RAND_seed() failed for buffer sizes less than 32 bytes. The reason was that now the added random data was used exlusively as entropy source for reseeding. When the random input was too short or contained not enough entropy, the DRBG failed without querying the available entropy sources. This commit makes drbg_add() act smarter: it checks the entropy requirements explicitely. If the random input fails this check, it won't be added as entropy input, but only as additional data. More precisely, the behaviour depends on whether an os entropy source was configured (which is the default on most os): - If an os entropy source is avaible then we declare the buffer content as additional data by setting randomness to zero and trigger a regular reseeding. - If no os entropy source is available, a reseeding will fail inevitably. So drbg_add() uses a trick to mix the buffer contents into the DRBG state without forcing a reseeding: it generates a dummy random byte, using the buffer content as additional data. Related-to: #7449 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7456) (cherry picked from commit 8817215d5c52a76f2b184b624bde4df8556dee6d)27 October 2018, 11:03:35 UTC
35a3450 Dr. Matthias St. Pierre26 October 2018, 20:10:27 UTCBackport some DRBG renamings and typo fixes In commit 8bf366519661 some renamings andd typo fixes were made while adding back the DRBG-HMAC and DRBG-HASH implementation. Since the commit could not be backported, a lot of unnecessary differences between master and 1.1.1 were introduced. These differences result in tiresome merge conflicts when cherry-picking. To minimize these merge-conflicts, this patch ports all 'non-feature' changes of commit 8bf366519661 (e.g., renamings of private variables, fixes of typographical errors, comment changes) manually back to 1.1.1. The commits a83dc59afa2e (#7399) and 8817215d5c52 (#7456) failed to cherry-pick previously to 1.1.1, with this patch they both cherry-pick without conflicts. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/7505)26 October 2018, 21:04:23 UTC
0b3f5ea Matt Caswell16 October 2018, 16:03:39 UTCAdd a test for duplicated DTLS records Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7414) (cherry picked from commit f1358634af5b84be22cb20fff3dcb613f5f8c978)26 October 2018, 13:28:18 UTC
86fe421 Matt Caswell16 October 2018, 16:08:11 UTCProperly handle duplicated messages from the next epoch Since 1fb9fdc30 we may attempt to buffer a record from the next epoch that has already been buffered. Prior to that this never occurred. We simply ignore a failure to buffer a duplicated record. Fixes #6902 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7414) (cherry picked from commit 840facc3ccab481e1a0bc2cb6e7740e362df7422)26 October 2018, 13:28:18 UTC
f3f7f1a Bernd Edlinger23 October 2018, 14:30:20 UTCFix a possible crash in rand_drbg_get_entropy Reviewed-by: Paul Yang <yang.yang@baishancloud.com> Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7474) (cherry picked from commit 21311777ad8b8c2f2fb8eb7a4f9618ceae1e043d)26 October 2018, 13:26:21 UTC
8017970 Dr. Matthias St. Pierre25 October 2018, 21:31:24 UTCConfigure: Reword the summary output In commit 820e414d2830 (pr #5247) the summary output of the Configure command was optimized towards instructing people how to create issue reports. It turned out that the wording of this message can confuse new OpenSSL users and make them think that they are seeing an error message. This commit makes the summary output start with a success to prevent a misunderstanding. Also it gives more hints to new OpenSSL users. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7499) (cherry picked from commit 41349b5e6dbd72bfbeaf3cf189d64914240628e3)26 October 2018, 10:47:05 UTC
1d0671b Dr. Matthias St. Pierre21 October 2018, 16:49:19 UTCRAND_load_file(): avoid adding small chunks to RAND_add() Increase the load buffer size such that it exceeds the chunk size by a comfortable amount. This is done to avoid calling RAND_add() with a small final chunk. Instead, such a small final chunk will be added together with the previous chunk (unless it's the only one). Related-to: #7449 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7456)26 October 2018, 06:50:26 UTC
13ce862 Dr. Matthias St. Pierre20 October 2018, 14:53:57 UTCRAND_load_file(): return error if reseeding failed The failure of RAND_load_file was only noticed because of the heap corruption which was reported in #7499 and fixed in commit 5b4cb385c18a. To prevent this in the future, RAND_load_file() now explicitly checks RAND_status() and reports an error if it fails. Related-to: #7449 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7456)26 October 2018, 06:50:26 UTC
8529945 Richard Levitte25 October 2018, 13:55:15 UTCWindows: Produce a static version of the public libraries, always When building shared libraries on Windows, we had a clash between 'libcrypto.lib' the static routine library and 'libcrypto.lib' the import library. We now change it so the static versions of our libraries get '_static' appended to their names. These will never get installed, but can still be used for our internal purposes, such as internal tests. When building non-shared, the renaming mechanism doesn't come into play. In that case, the static libraries 'libcrypto.lib' and 'libssl.lib' are installed, just as always. Fixes #7492 Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7496) (cherry picked from commit b3023ced6b6a4aece6f4d4ec1f6a93b1c03712b6)25 October 2018, 21:30:52 UTC
28361a0 Richard Levitte23 October 2018, 08:15:12 UTCRAND: ensure INT32_MAX is defined This value is used to set DRBG_MAX_LENGTH Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/7467) (cherry picked from commit f81b043ad856d8b9af5239a4978f8bd4b965dab9)23 October 2018, 08:56:59 UTC
ece482f Dr. Matthias St. Pierre20 October 2018, 14:53:09 UTCRAND_add(): fix heap corruption in error path This bug was introduced by #7382 which enhanced RAND_add() to accept large buffer sizes. As a consequence, RAND_add() now fails for buffer sizes less than 32 bytes (i.e. less than 256 bits). In addition, rand_drbg_get_entropy() forgets to reset the attached drbg->pool in the case of an error, which leads to the heap corruption. The problem occurred with RAND_load_file(), which reads the file in chunks of 1024 bytes each. If the size of the final chunk is less than 32 bytes, then RAND_add() fails, whence RAND_load_file() fails silently for buffer sizes n = k * 1024 + r with r = 1,...,31. This commit fixes the heap corruption only. The other issues will be addressed in a separate pull request. Thanks to Gisle Vanem for reporting this issue. Fixes #7449 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7455) (cherry picked from commit 5b4cb385c18a5bb4e118e300f1c746bf7c2a5628)22 October 2018, 12:57:04 UTC
132fd51 Richard Levitte21 October 2018, 09:03:02 UTCbuild file templates: have targets for all shared library names We only had targets for the "simple" shared library names (libfoo.so and not libfoo.so.x.y on Unix, import library libfoo.lib but not libfoo.dll on Windows). This has created some confusion why it wasn't possible to rebuild the less "simple" name directly (just as an example, someone who mistook the import library on Windows for a static library, removed the DLL and then found it was difficult to rebuild directly), so we change the target to include all possible names. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7451) (cherry picked from commit d8cac50b023be249cdaba054f43acecf17025ce4)21 October 2018, 13:49:48 UTC
8c6371f Matt Caswell18 October 2018, 13:45:59 UTCDon't complain and fail about unknown TLSv1.3 PSK identities in s_server An unknown PSK identity could be because its actually a session resumption attempt. Sessions resumptions and external PSKs are indistinguishable so the callbacks need to fail gracefully if they don't recognise the identity. Fixes #7433 Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7434) (cherry picked from commit 2d015189b97c60b67e10aed320230357bf6b200f)19 October 2018, 14:24:14 UTC
d1bfd80 Matt Caswell09 October 2018, 09:22:06 UTCBuffer a ClientHello with a cookie received via DTLSv1_listen Previously when a ClientHello arrives with a valid cookie using DTLSv1_listen() we only "peeked" at the message and left it on the underlying fd. This works fine for single threaded applications but for multi-threaded apps this does not work since the fd is typically reused for the server thread, while a new fd is created and connected for the client. By "peeking" we leave the message on the server fd, and consequently we think we've received another valid ClientHello and so we create yet another fd for the client, and so on until we run out of fds. In this new approach we remove the ClientHello and buffer it in the SSL object. Fixes #6934 Reviewed-by: Ben Kaduk <kaduk@mit.edu> (Merged from https://github.com/openssl/openssl/pull/7375) (cherry picked from commit 079ef6bd534d2f708d8013cfcd8ea0d2f600c788)19 October 2018, 13:29:52 UTC
585e691 Matt Caswell08 October 2018, 14:46:51 UTCUse the read and write buffers in DTLSv1_listen() Rather than using init_buf we use the record layer read and write buffers in DTLSv1_listen(). These seem more appropriate anyway and will help with the next commit. Reviewed-by: Ben Kaduk <kaduk@mit.edu> (Merged from https://github.com/openssl/openssl/pull/7375) (cherry picked from commit 2fc4c77c3f06443f4c476f6f58d83e5e108d1dce)19 October 2018, 13:29:52 UTC
6c52987 Matt Caswell18 October 2018, 09:12:20 UTCTest DTLS cookie generation and verification Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7431) (cherry picked from commit edcd29efd32c51f298ad5ab438e2d4cc5411e9a9)19 October 2018, 13:19:22 UTC
a6a8382 Matt Caswell18 October 2018, 09:12:07 UTCFix a DTLS memory leak Fixes #7428 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7431) (cherry picked from commit 01666a8c1db3ecfb999e1a8f2c5436d114f95681)19 October 2018, 13:19:22 UTC
a66c361 Andy Polyakov14 October 2018, 13:19:41 UTCConfigurations/15-android.conf: add support for "standalone toolchain". Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7400) (cherry picked from commit 03ad7c009e16a233c733098db3169c560142ccd3)19 October 2018, 08:36:48 UTC
fc762e7 Andy Polyakov17 October 2018, 08:09:33 UTCarch/async_posix.h: improve portability. {make|swap|get|set}context are removed in POSIX.1-2008, but glibc apparently keeps providing it. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/7420) (cherry picked from commit 9d71a24ebf57e7157888af1ca587eafe914bf96f)19 October 2018, 08:31:04 UTC
aa51985 armfazh18 October 2018, 22:26:58 UTCFix tls_cbc_digest_record is slow using SHA-384 and short messages The formula used for this is now kVarianceBlocks = ((255 + 1 + md_size + md_block_size - 1) / md_block_size) + 1 Notice that md_block_size=64 for SHA256, which results on the magic constant kVarianceBlocks = 6. However, md_block_size=128 for SHA384 leading to kVarianceBlocks = 4. CLA:trivial Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/7342) (cherry picked from commit cb8164b05e3bad5586c2a109bbdbab1ad65a1a6f)18 October 2018, 22:32:44 UTC
back to top