| 8202802 | Richard Levitte | 24 September 2014, 20:59:37 UTC | Include "constant_time_locl.h" rather than "../constant_time_locl.h". The different -I compiler parameters will take care of the rest... Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 October 2014, 08:49:35 UTC |
| f79bb32 | Richard Levitte | 16 June 2014, 11:24:04 UTC | Spaces were added in some strings for better readability. However, those spaces do not belong in file names, so when picking out the individual parts, remove the spaces Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 October 2014, 08:49:24 UTC |
| 7a3809f | Richard Levitte | 06 August 2014, 02:37:27 UTC | Adjust VMS build to Unix build. Most of all, make it so the disabled algorithms MD2 and RC5 don't get built. Also, disable building the test apps in crypto/des and crypto/pkcs7, as they have no support at all. Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 October 2014, 08:49:08 UTC |
| f13a149 | Richard Levitte | 18 June 2014, 11:41:54 UTC | Make sure test/tests.com exit gracefully, even when openssl.exe wasn't properly built. Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 October 2014, 08:48:55 UTC |
| fc586d2 | Richard Levitte | 06 August 2014, 01:54:57 UTC | Update the VMS build according to the latest unixly build. Partly provided by Zoltan Arpadffy <arpadffy@polarhome.com> Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 October 2014, 08:48:32 UTC |
| 17d45de | Richard Levitte | 14 June 2014, 13:13:44 UTC | Make sure that disabling the MAYLOSEDATA3 warning is only done when the compiler supports it. Otherwise, there are warnings about it lacking everywhere, which is quite tedious to read through while trying to check for other warnings. Reviewed-by: Tim Hudson <tjh@openssl.org> | 15 October 2014, 08:47:12 UTC |
| 6bfe553 | Bodo Moeller | 15 October 2014, 02:05:42 UTC | Support TLS_FALLBACK_SCSV. Reviewed-by: Rich Salz <rsalz@openssl.org> | 15 October 2014, 02:05:42 UTC |
| 4e05aed | Dr. Stephen Henson | 10 October 2014, 12:18:09 UTC | Preserve digests for SNI. SSL_set_SSL_CTX is normally called for SNI after ClientHello has received and the digest to use for each certificate has been decided. The original ssl->cert contains the negotiated digests and is now copied to the new ssl->cert. PR: 3560 Reviewed-by: Tim Hudson <tjh@openssl.org> | 10 October 2014, 22:21:14 UTC |
| bf3e200 | Matt Caswell | 03 October 2014, 22:48:49 UTC | Removed duplicate definition of PKCS7_type_is_encrypted Patch supplied by Matthieu Patou <mat@matws.net>, and modified to also remove duplicate definition of PKCS7_type_is_digest. PR#3551 Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit e0fdea3e49e7454aa76bd5ecf3a3747641354c68) | 06 October 2014, 22:46:25 UTC |
| 55614f8 | Dr. Stephen Henson | 25 September 2014, 22:28:48 UTC | Add additional DigestInfo checks. Reencode DigestInto in DER and check against the original: this will reject any improperly encoded DigestInfo structures. Note: this is a precautionary measure, there is no known attack which can exploit this. Thanks to Brian Smith for reporting this issue. Reviewed-by: Tim Hudson <tjh@openssl.org> | 29 September 2014, 11:22:32 UTC |
| b162044 | Emilia Kasper | 25 September 2014, 11:39:21 UTC | Add missing tests Accidentally omitted from commit 455b65dfab0de51c9f67b3c909311770f2b3f801 Reviewed-by: Kurt Roeckx <kurt@openssl.org> (cherry picked from commit fdc35a9d3e8cf4cfd9330d5df9883f42cf5648ad) | 25 September 2014, 11:47:16 UTC |
| 4ed98b6 | Dr. Stephen Henson | 20 September 2014, 00:00:55 UTC | Use correct function name: CMS_add1_signer() Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 5886354dcca4f8445ed35b6995a035b75409590c) | 24 September 2014, 23:06:59 UTC |
| 3a33923 | Andy Polyakov | 24 September 2014, 22:42:26 UTC | crypto/bn/bn_nist.c: work around MSC ARM compiler bug. RT: 3541 Reviewed-by: Emilia Kasper <emilia@openssl.org> (cherry picked from commit 8b07c005fe006044d0e4a795421447deca3c9f2c) | 24 September 2014, 22:47:18 UTC |
| f2df488 | Emilia Kasper | 05 September 2014, 12:47:33 UTC | RT3425: constant-time evp_enc Do the final padding check in EVP_DecryptFinal_ex in constant time to avoid a timing leak from padding failure. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 4aac102f75b517bdb56b1bcfd0a856052d559f6e) Conflicts: crypto/evp/evp_enc.c (cherry picked from commit 738911cde68b2b3706e502cf8daf5b14738f2f42) | 24 September 2014, 14:25:54 UTC |
| 8d507ae | Emilia Kasper | 04 September 2014, 11:04:42 UTC | RT3067: simplify patch (Original commit adb46dbc6dd7347750df2468c93e8c34bcb93a4b) Use the new constant-time methods consistently in s3_srvr.c Reviewed-by: Kurt Roeckx <kurt@openssl.org> (cherry picked from commit 455b65dfab0de51c9f67b3c909311770f2b3f801) | 24 September 2014, 13:52:41 UTC |
| 1331456 | Adam Langley | 24 April 2013, 18:45:44 UTC | This change alters the processing of invalid, RSA pre-master secrets so that bad encryptions are treated like random session keys in constant time. (cherry picked from commit adb46dbc6dd7347750df2468c93e8c34bcb93a4b) Reviewed-by: Rich Salz <rsalz@openssl.org> | 24 September 2014, 13:46:26 UTC |
| 0f04b00 | Emilia Kasper | 28 August 2014, 17:43:49 UTC | RT3066: rewrite RSA padding checks to be slightly more constant time. Also tweak s3_cbc.c to use new constant-time methods. Also fix memory leaks from internal errors in RSA_padding_check_PKCS1_OAEP_mgf1 This patch is based on the original RT submission by Adam Langley <agl@chromium.org>, as well as code from BoringSSL and OpenSSL. Reviewed-by: Kurt Roeckx <kurt@openssl.org> Conflicts: crypto/rsa/rsa_oaep.c | 24 September 2014, 12:17:41 UTC |
| 81e3a60 | Tim Hudson | 21 September 2014, 11:54:31 UTC | Fixed error introduced in commit f2be92b94dad3c6cbdf79d99a324804094cf1617 that fixed PR#3450 where an existing cast masked an issue when i was changed from int to long in that commit Picked up on z/linux (s390) where sizeof(int)!=sizeof(long) Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit b5ff559ff90124c6fd53bbb49dae5edb4e821e0a) | 21 September 2014, 20:34:25 UTC |
| bea9a17 | Rich Salz | 10 September 2014, 15:43:45 UTC | RT2560: missing NULL check in ocsp_req_find_signer If we don't find a signer in the internal list, then fall through and look at the internal list; don't just return NULL. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit b2aa38a980e9fbf158aafe487fb729c492b241fb) | 10 September 2014, 16:20:25 UTC |
| b537ea9 | Erik Auerswald | 27 August 2014, 02:50:34 UTC | RT3301: Discard too-long heartbeat requests Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit af4c6e348e4bad6303e7d214cdcf2536487aabe4) | 08 September 2014, 15:23:10 UTC |
| 13ce52b | Adam Langley | 20 June 2014, 19:00:00 UTC | psk_client_callback, 128-byte id bug. Fix a bug in handling of 128 byte long PSK identity in psk_client_callback. OpenSSL supports PSK identities of up to (and including) 128 bytes in length. PSK identity is obtained via the psk_client_callback, implementors of which are expected to provide a NULL-terminated identity. However, the callback is invoked with only 128 bytes of storage thus making it impossible to return a 128 byte long identity and the required additional NULL byte. This CL fixes the issue by passing in a 129 byte long buffer into the psk_client_callback. As a safety precaution, this CL also zeroes out the buffer before passing it into the callback, uses strnlen for obtaining the length of the identity returned by the callback, and aborts the handshake if the identity (without the NULL terminator) is longer than 128 bytes. (Original patch amended to achieve strnlen in a different way.) Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit be0d851732bad7370640702bc9c4a33189ede287) | 05 September 2014, 10:22:50 UTC |
| 11853c5 | Adam Langley | 23 April 2013, 16:13:51 UTC | Ensure that x**0 mod 1 = 0. (cherry picked from commit 2b0180c37fa6ffc48ee40caa831ca398b828e680) Reviewed-by: Ben Laurie <ben@openssl.org> | 04 September 2014, 14:06:51 UTC |
| a60aa7e | Richard Levitte | 14 August 2014, 23:24:34 UTC | Followup on RT3334 fix: make sure that a directory that's the empty string returns 0 with errno = ENOENT. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 360928b7d0f16dde70e26841bbf9e1af727e8b8f) | 03 September 2014, 20:26:05 UTC |
| a49256a | Phil Mesnier | 14 August 2014, 17:35:07 UTC | RT3334: Fix crypto/LPdir_win.c Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 6a14fe7576e7a14a46ba14df8be8fe478536b4fb) | 03 September 2014, 20:26:05 UTC |
| e517dfd | Emilia Kasper | 28 August 2014, 17:45:55 UTC | Make the inline const-time functions static. "inline" without static is not correct as the compiler may choose to ignore it and will then either emit an external definition, or expect one. Reviewed-by: Geoff Thorpe <geoff@openssl.org> (cherry picked from commit 86f50b36e63275a916b147f9d8764e3c0c060fdb) | 02 September 2014, 13:24:59 UTC |
| 74687f5 | Andy Polyakov | 30 August 2014, 17:17:09 UTC | md5-x86_64.pl: work around warning. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 4d86e8df6be69ed13abb73fd564f1f894eea0a98) | 30 August 2014, 17:19:01 UTC |
| 8dc6617 | Rich Salz | 14 July 2014, 15:27:16 UTC | Add tags/TAGS Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 9d6253cfd3395dfe7147dae134579c6b16544c53) | 30 August 2014, 14:09:30 UTC |
| c211921 | Rich Salz | 28 August 2014, 23:11:42 UTC | RT2119,3407: Updated to dgst.pod Re-order algorithm list. Be consistent in command synopsis. Add content about signing. Add EXAMPLE section Add some missing options: -r, -fips-fingerprint -non-fips-allow Various other fixes. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 6aa9dbab0f9b90060b7ee609b8c3c726ce4faf21) | 30 August 2014, 14:06:07 UTC |
| 22387f0 | James Westby | 14 August 2014, 14:14:35 UTC | RT1941: c_rehash.pod is missing Add the file written by James Westby, graciously contributed under the terms of the OpenSSL license. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit cf2239b3b397174a8a6b1cc84ff68aba34ed5941) | 30 August 2014, 13:51:56 UTC |
| 4d16915 | Rich Salz | 18 August 2014, 17:00:51 UTC | RT2379: Bug in BIO_set_accept_port.pod The doc says that port can be "*" to mean any port. That's wrong. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 07e3b31fae98b985d3d2aad7066144b11833f688) | 29 August 2014, 20:46:28 UTC |
| e7169a5 | Emilia Kasper | 28 August 2014, 13:33:34 UTC | Constant-time utilities Pull constant-time methods out to a separate header, add tests. Reviewed-by: Bodo Moeller <bodo@openssl.org> (cherry picked from commit 9a9b0c0401cae443f115ff19921d347b20aa396b) Conflicts: test/Makefile | 28 August 2014, 15:07:07 UTC |
| abc2dfb | Raphael Spreitzer | 28 August 2014, 02:53:10 UTC | RT2400: ASN1_STRING_to_UTF8 missing initializer Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit f9fb43e176ad2a914108cd2b403425dc1ebc7262) | 28 August 2014, 02:59:52 UTC |
| 23ea9f6 | Rich Salz | 28 August 2014, 01:47:12 UTC | RT2308: Add extern "C" { ... } wrapper Add the wrapper to all public header files (Configure generates one). Don't bother for those that are just lists of #define's that do renaming. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 089f10e69ece75ce31540501fe0898b15e898552) | 28 August 2014, 01:47:12 UTC |
| 3e5df37 | Emilia Kasper | 25 August 2014, 10:38:16 UTC | Explicitly check for empty ASN.1 strings in d2i_ECPrivateKey The old code implicitly relies on the ASN.1 code returning a \0-prefixed buffer when the buffer length is 0. Change this to verify explicitly that the ASN.1 string has positive length. Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit 82dc08de54ce443c2a9ac478faffe79e76157795) | 27 August 2014, 17:50:36 UTC |
| 4e5f9f8 | Matt Caswell | 22 August 2014, 16:04:19 UTC | RT3065: automatically generate a missing EC public key When d2i_ECPrivateKey reads a private key with a missing (optional) public key, generate one automatically from the group and private key. Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit ed383f847156940e93f256fed78599873a4a9b28) Conflicts: doc/crypto/EC_KEY_new.pod | 27 August 2014, 17:50:36 UTC |
| 9446ecf | Adam Langley | 23 April 2013, 19:12:36 UTC | RT3065: ec_private_key_dont_crash This change saves several EC routines from crashing when an EC_KEY is missing a public key. The public key is optional in the EC private key format and, without this patch, running the following through `openssl ec` causes a crash: -----BEGIN EC PRIVATE KEY----- MBkCAQEECAECAwQFBgcIoAoGCCqGSM49AwEH -----END EC PRIVATE KEY----- Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit b391570bdeb386d4fd325917c248d593d3c43930) | 27 August 2014, 17:50:36 UTC |
| 48ecdec | Mihai Militaru | 26 August 2014, 16:35:54 UTC | RT2210: Add missing EVP_cleanup to example I also removed some trailing whitespace and cleaned up the "see also" list. Reviewed-by: Emilia Kasper <emilia@openssl.org> (cherry picked from commit 7b3e11c54466f1da8b707c932e308d345fd61101) | 27 August 2014, 17:27:06 UTC |
| 8f5f782 | David Gatwood | 26 August 2014, 17:02:03 UTC | RT1744: SSL_CTX_set_dump_dh() doc feedback The description of when the server creates a DH key is confusing. This cleans it up. (rsalz: also removed trailing whitespace.) Reviewed-by: Viktor Dukhovni <viktor@openssl.org> | 26 August 2014, 17:40:45 UTC |
| 228a77a | Jan Schaumann | 15 August 2014, 03:00:44 UTC | RT1804: fix EXAMPLE in EVP_EncryptInit.pod The EXAMPLE that used FILE and RC2 doesn't compile due to a few minor errors. Tweak to use IDEA and AES-128. Remove examples about RC2 and RC5. Reviewed-by: Emilia Kasper <emilia@openssl.org> | 25 August 2014, 14:26:57 UTC |
| 03b17a5 | Matt Caswell | 24 July 2014, 05:00:11 UTC | Typo fixes to evp documentation. This patch was submitted by user "Kox" via the wiki Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 2dd8cb3b9593f528d9537aa6a003d5c93df1e3c5) | 24 August 2014, 20:26:40 UTC |
| 391f3b5 | Adam Langley | 19 August 2014, 15:57:53 UTC | RT3060: Limit the number of empty records. Limit the number of empty records that will be processed consecutively in order to prevent ssl3_get_record from never returning. Reported by "oftc_must_be_destroyed" and George Kadianakis. Reviewed-by: Bodo Moeller <bodo@openssl.org> (cherry picked from commit 3aac17a82fbaf2bc23ee62f24611e5883d3e7b97) | 22 August 2014, 13:53:14 UTC |
| fe9b9a8 | Adam Langley | 21 February 2013, 22:11:55 UTC | RT3061: Don't SEGFAULT when trying to export a public DSA key as a private key. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit e19c93811f0db499c98d2888f1c0c0ab65e6238a) | 22 August 2014, 13:25:18 UTC |
| 9f96ea4 | Emilia Kasper | 22 August 2014, 11:16:55 UTC | Improve EVP_PKEY_sign documentation Clarify the intended use of EVP_PKEY_sign. Make the code example compile. Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit d64c533a207f7b6d86c3bc8ffb053e5f4d0c1ca0) | 22 August 2014, 13:06:09 UTC |
| 41a7651 | Emilia Kasper | 19 August 2014, 11:18:07 UTC | define inline for Visual Studio In Visual Studio, inline is available in C++ only, however __inline is available for C, see http://msdn.microsoft.com/en-us/library/z8y1yy88.aspx Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit f511b25a7370c775dc9fd6198dbacd1706cf242b) | 21 August 2014, 14:07:55 UTC |
| bcdd904 | Emilia Kasper | 19 August 2014, 14:28:07 UTC | Fix build when BSAES_ASM is defined but VPAES_ASM is not Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit da92be4d68bec81030838e3228ef0238c565af85) | 21 August 2014, 13:48:23 UTC |
| a90b1e3 | Adam Langley | 03 June 2013, 19:45:11 UTC | Add volatile qualifications to two blocks of inline asm to stop GCC from eliminating them as dead code. Both volatile and "memory" are used because of some concern that the compiler may still cache values across the asm block without it, and because this was such a painful debugging session that I wanted to ensure that it's never repeated. (cherry picked from commit 7753a3a68431aa81b82beea4c3f5374b41454679) Conflicts: crypto/bn/asm/x86_64-gcc.c Reviewed-by: Rich Salz <rsalz@openssl.org> | 19 August 2014, 15:09:27 UTC |
| 0ed8e95 | Matt Caswell | 26 July 2014, 22:47:40 UTC | Fixed out-of-bounds read errors in ssl3_get_key_exchange. PR#3450 Conflicts: ssl/s3_clnt.c Reviewed-by: Emilia Käsper <emilia@openssl.org> | 15 August 2014, 22:29:28 UTC |
| 6b5b85f | Bodo Moeller | 13 August 2014, 15:37:19 UTC | Further improve/fix ec_GFp_simple_points_make_affine (ecp_smpl.c) and group_order_tests (ectest.c). Also fix the EC_POINTs_mul documentation (ec.h). Reviewed-by: emilia@openssl.org | 13 August 2014, 15:44:53 UTC |
| 03ebf85 | Dr. Stephen Henson | 12 August 2014, 17:33:00 UTC | Fix SRP ciphersuites. Add patch missed from backport of SRP ciphersuite fix. PR#3490 Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 12 August 2014, 19:42:27 UTC |
| 30fbe92 | Dr. Stephen Henson | 08 August 2014, 10:24:25 UTC | Fix SRP authentication ciphersuites. The addition of SRP authentication needs to be checked in various places to work properly. Specifically: A certificate is not sent. A certificate request must not be sent. Server key exchange message must not contain a signature. If appropriate SRP authentication ciphersuites should be chosen. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 8f5a8805b82d1ae81168b11b7f1506db9e047dec) Conflicts: ssl/s3_clnt.c ssl/s3_lib.c | 08 August 2014, 23:13:27 UTC |
| 1241e77 | Dr. Stephen Henson | 08 August 2014, 10:19:39 UTC | Test SRP authentication ciphersuites. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 193c1c07165b0042abd217274a084b49459d4443) | 08 August 2014, 23:10:26 UTC |
| 1433cac | Dr. Stephen Henson | 07 August 2014, 00:08:14 UTC | Only use FIPS EC methods in FIPS mode. Reviewed-by: Tim Hudson <tjh@openssl.org> | 07 August 2014, 00:08:14 UTC |
| 204fb36 | Matt Caswell | 06 August 2014, 21:19:10 UTC | Prepare for 1.0.1j-dev Reviewed-by: Stephen Henson <steve@openssl.org> | 06 August 2014, 21:19:10 UTC |
| 2b45603 | Matt Caswell | 06 August 2014, 21:18:45 UTC | Prepare for 1.0.1i release Reviewed-by: Stephen Henson <steve@openssl.org> | 06 August 2014, 21:18:45 UTC |
| d70c0be | Matt Caswell | 06 August 2014, 21:18:45 UTC | make update Reviewed-by: Stephen Henson <steve@openssl.org> | 06 August 2014, 21:18:45 UTC |
| 9b649d9 | Dr. Stephen Henson | 06 August 2014, 13:47:50 UTC | update NEWS Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 06 August 2014, 19:33:25 UTC |
| abbd585 | Dr. Stephen Henson | 06 August 2014, 13:09:51 UTC | update CHANGES Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 06 August 2014, 19:33:25 UTC |
| d15d17b | Dr. Stephen Henson | 01 August 2014, 13:56:56 UTC | Check SRP parameters early. Check SRP parameters when they are received so we can send back an appropriate alert. Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 06 August 2014, 19:27:51 UTC |
| 966fe81 | Dr. Stephen Henson | 31 July 2014, 19:56:22 UTC | Fix SRP buffer overrun vulnerability. Invalid parameters passed to the SRP code can be overrun an internal buffer. Add sanity check that g, A, B < N to SRP code. Thanks to Sean Devlin and Watson Ladd of Cryptography Services, NCC Group for reporting this issue. Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 06 August 2014, 19:27:51 UTC |
| 83764a9 | Dr. Stephen Henson | 29 July 2014, 20:23:30 UTC | Fix SRP ciphersuite DoS vulnerability. If a client attempted to use an SRP ciphersuite and it had not been set up correctly it would crash with a null pointer read. A malicious server could exploit this in a DoS attack. Thanks to Joonas Kuorilehto and Riku Hietamäki from Codenomicon for reporting this issue. CVE-2014-5139 Reviewed-by: Tim Hudson <tjh@openssl.org> | 06 August 2014, 19:27:51 UTC |
| 86788e1 | Gabor Tyukasz | 23 July 2014, 21:42:06 UTC | Fix race condition in ssl_parse_serverhello_tlsext CVE-2014-3509 Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Dr. Stephen Henson <steve@openssl.org> | 06 August 2014, 19:27:51 UTC |
| 03b04dd | Emilia Kasper | 02 July 2014, 17:02:33 UTC | Fix OID handling: - Upon parsing, reject OIDs with invalid base-128 encoding. - Always NUL-terminate the destination buffer in OBJ_obj2txt printing function. CVE-2014-3508 Reviewed-by: Dr. Stephen Henson <steve@openssl.org> Reviewed-by: Kurt Roeckx <kurt@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> | 06 August 2014, 19:27:51 UTC |
| 88ae012 | Emilia Käsper | 24 July 2014, 20:15:29 UTC | Fix DTLS anonymous EC(DH) denial of service CVE-2014-3510 Reviewed-by: Dr. Stephen Henson <steve@openssl.org> | 06 August 2014, 19:27:51 UTC |
| fc4f4cd | David Benjamin | 23 July 2014, 20:32:21 UTC | Fix protocol downgrade bug in case of fragmented packets CVE-2014-3511 Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Bodo Möller <bodo@openssl.org> | 06 August 2014, 19:27:51 UTC |
| 4e0fbdc | Adam Langley | 06 June 2014, 21:47:07 UTC | Remove some duplicate DTLS code. In a couple of functions, a sequence number would be calculated twice. Additionally, in |dtls1_process_out_of_seq_message|, we know that |frag_len| <= |msg_hdr->msg_len| so the later tests for |frag_len < msg_hdr->msg_len| can be more clearly written as |frag_len != msg_hdr->msg_len|, since that's the only remaining case. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org> | 06 August 2014, 19:27:51 UTC |
| 0c37aed | Matt Caswell | 24 July 2014, 22:54:28 UTC | Applying same fix as in dtls1_process_out_of_seq_message. A truncated DTLS fragment would cause *ok to be clear, but the return value would still be the number of bytes read. Problem identified by Emilia Käsper, based on previous issue/patch by Adam Langley. Reviewed-by: Emilia Käsper <emilia@openssl.org> | 06 August 2014, 19:27:51 UTC |
| 099ccdb | Adam Langley | 06 June 2014, 21:44:20 UTC | Fix return code for truncated DTLS fragment. Previously, a truncated DTLS fragment in |dtls1_process_out_of_seq_message| would cause *ok to be cleared, but the return value would still be the number of bytes read. This would cause |dtls1_get_message| not to consider it an error and it would continue processing as normal until the calling function noticed that *ok was zero. I can't see an exploit here because |dtls1_get_message| uses |s->init_num| as the length, which will always be zero from what I can see. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org> | 06 August 2014, 19:27:51 UTC |
| 9871417 | Adam Langley | 06 June 2014, 21:30:33 UTC | Fix memory leak from zero-length DTLS fragments. The |pqueue_insert| function can fail if one attempts to insert a duplicate sequence number. When handling a fragment of an out of sequence message, |dtls1_process_out_of_seq_message| would not call |dtls1_reassemble_fragment| if the fragment's length was zero. It would then allocate a fresh fragment and attempt to insert it, but ignore the return value, leaking the fragment. This allows an attacker to exhaust the memory of a DTLS peer. Fixes CVE-2014-3507 Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org> | 06 August 2014, 19:27:51 UTC |
| fc7804e | Matt Caswell | 06 June 2014, 21:25:52 UTC | Fix DTLS handshake message size checks. In |dtls1_reassemble_fragment|, the value of |msg_hdr->frag_off+frag_len| was being checked against the maximum handshake message size, but then |msg_len| bytes were allocated for the fragment buffer. This means that so long as the fragment was within the allowed size, the pending handshake message could consume 16MB + 2MB (for the reassembly bitmap). Approx 10 outstanding handshake messages are allowed, meaning that an attacker could consume ~180MB per DTLS connection. In the non-fragmented path (in |dtls1_process_out_of_seq_message|), no check was applied. Fixes CVE-2014-3506 Wholly based on patch by Adam Langley with one minor amendment. Reviewed-by: Emilia Käsper <emilia@openssl.org> | 06 August 2014, 19:27:51 UTC |
| e7b9d9b | Matt Caswell | 24 July 2014, 22:33:34 UTC | Added comment for the frag->reassembly == NULL case as per feedback from Emilia Reviewed-by: Emilia Käsper <emilia@openssl.org> | 06 August 2014, 19:27:51 UTC |
| 2172d4f | Adam Langley | 06 June 2014, 21:19:21 UTC | Avoid double free when processing DTLS packets. The |item| variable, in both of these cases, may contain a pointer to a |pitem| structure within |s->d1->buffered_messages|. It was being freed in the error case while still being in |buffered_messages|. When the error later caused the |SSL*| to be destroyed, the item would be double freed. Thanks to Wah-Teh Chang for spotting that the fix in 1632ef74 was inconsistent with the other error paths (but correct). Fixes CVE-2014-3505 Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org> | 06 August 2014, 19:27:51 UTC |
| c34091d | Dr. Stephen Henson | 01 August 2014, 19:44:37 UTC | make update Reviewed-by: Tim Hudson <tjh@openssl.org> | 01 August 2014, 20:23:49 UTC |
| a9f4ebd | Dr. Stephen Henson | 31 July 2014, 20:22:23 UTC | Fix error discrepancy. We can't rename ssleay_rand_bytes to md_rand_bytes_lock as this will cause an error code discrepancy. Instead keep ssleay_rand_bytes and add an extra parameter: since ssleay_rand_bytes is not part of the public API this wont cause any binary compatibility issues. Reviewed-by: Kurt Roeckx <kurt@openssl.org > (cherry picked from commit 8068a675a7d1a657c54546f24e673e59e6707f03) | 01 August 2014, 17:42:40 UTC |
| 604c994 | Bodo Moeller | 01 August 2014, 17:07:57 UTC | Update $default_depflags to match current defaults. | 01 August 2014, 17:07:57 UTC |
| 281720c | Bodo Moeller | 01 August 2014, 15:18:14 UTC | Simplify and fix ec_GFp_simple_points_make_affine (which didn't always handle value 0 correctly). Reviewed-by: emilia@openssl.org Conflicts: CHANGES | 01 August 2014, 15:50:26 UTC |
| 2a9023f | Dr. Stephen Henson | 30 July 2014, 14:13:08 UTC | Avoid multiple lock using FIPS DRBG. Don't use multiple locks when SP800-90 DRBG is used outside FIPS mode. PR#3176 Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit a3efe1b6e9d2aa2ce5661e4d4b97262eae743fa7) | 30 July 2014, 20:09:20 UTC |
| 36e8c39 | Dr. Stephen Henson | 23 July 2014, 12:18:06 UTC | Add conditional unit testing interface. Don't call internal functions directly call them through SSL_test_functions(). This also makes unit testing work on Windows and platforms that don't export internal functions from shared libraries. By default unit testing is not enabled: it requires the compile time option "enable-unit-test". Reviewed-by: Geoff Thorpe <geoff@openssl.org> (cherry picked from commit e0fc7961c4fbd27577fb519d9aea2dc788742715) Conflicts: ssl/Makefile util/mkdef.pl | 24 July 2014, 18:43:25 UTC |
| e3f009c | Billy Brumley | 21 July 2014, 21:08:23 UTC | "EC_POINT_invert" was checking "dbl" function pointer instead of "invert". PR#2569 Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit cba11f57ce161fd301a72194827327128191de7e) | 21 July 2014, 21:28:40 UTC |
| fbe3baa | Tim Hudson | 21 July 2014, 19:26:17 UTC | Remove old unused and unmaintained demonstration code. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> (cherry picked from commit 62352b8138018775a4c085a105fccd9cdcb6323f) | 21 July 2014, 21:26:35 UTC |
| 690998f | Tim Hudson | 21 July 2014, 10:03:50 UTC | Minor documentation update removing "really" and a statement of opinion rather than a fact. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit c8d133e4b6f1ed1b7ad3c1a6d2c62f460e26c050) | 21 July 2014, 10:24:47 UTC |
| 3221da8 | Dr. Stephen Henson | 19 July 2014, 13:20:05 UTC | Fix documentation for RSA_set_method(3) PR#1675 Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 197400c3f0d617d71ad8167b52fb73046d334320) | 19 July 2014, 17:26:12 UTC |
| 9aeb410 | Jeffrey Walton | 17 July 2014, 10:25:02 UTC | Fix typo, add reference. PR#3456 Reviewed-by: Stephen Henson <steve@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit d48e78f0cf22aaddb563f4bcfccf25b1a45ac8a4) | 17 July 2014, 11:08:52 UTC |
| bf4519c | Matt Caswell | 13 July 2014, 22:28:13 UTC | Disabled XTS mode in enc utility as it is not supported PR#3442 Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 2097a17c576f2395a10b05f14490688bc5f45a07) | 16 July 2014, 20:05:10 UTC |
| e967b94 | Matt Caswell | 15 July 2014, 21:47:29 UTC | Add Matt Caswell's fingerprint, and general update on the fingerprints file to bring it up to date Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 3bd548192a03142c80cf8bc68659d79dea20a738) | 15 July 2014, 22:24:26 UTC |
| 2316286 | Dr. Stephen Henson | 15 July 2014, 19:22:39 UTC | Clarify -Verify and PSK. PR#3452 (cherry picked from commit ca2015a617842fed3d36ed4dcbbf8d5e27bc5216) | 15 July 2014, 19:23:35 UTC |
| 67bde7d | Dr. Stephen Henson | 15 July 2014, 17:21:59 UTC | Fix DTLS certificate requesting code. Use same logic when determining when to expect a client certificate for both TLS and DTLS. PR#3452 (cherry picked from commit c8d710dc5f83d69d802f941a4cc5895eb5fe3d65) | 15 July 2014, 17:23:44 UTC |
| cd63f94 | Dr. Stephen Henson | 15 July 2014, 11:22:49 UTC | Don't allow -www etc options with DTLS. The options which emulate a web server don't make sense when doing DTLS. Exit with an error if an attempt is made to use them. PR#3453 (cherry picked from commit 58a2aaeade8bdecd0f9f0df41927f7cff3012547) | 15 July 2014, 11:25:39 UTC |
| 2054eb7 | Dr. Stephen Henson | 15 July 2014, 11:20:30 UTC | Add ECC extensions with DTLS. PR#3449 | 15 July 2014, 11:20:30 UTC |
| ea0ceb1 | Dr. Stephen Henson | 14 July 2014, 22:59:13 UTC | Use case insensitive compare for servername. PR#3445 (cherry picked from commit 1c3e9a7c67ccdc5e770829fe951e5832e600d377) | 14 July 2014, 23:00:03 UTC |
| 00579b9 | Hubert Kario | 06 June 2014, 14:48:43 UTC | document -nextprotoneg option in man pages Add description of the option to advertise support of Next Protocol Negotiation extension (-nextprotoneg) to man pages of s_client and s_server. PR#3444 (cherry picked from commit 7efd0e777e65eaa6c60d85b1cc5c889f872f8fc4) Conflicts: doc/apps/s_server.pod | 14 July 2014, 22:43:58 UTC |
| ee5a8d3 | Dr. Stephen Henson | 14 July 2014, 14:05:50 UTC | Use more common name for GOST key exchange. (cherry picked from commit 7aabd9c92fe6f0ea2a82869e5171dcc4518cee85) | 14 July 2014, 17:31:54 UTC |
| 7237016 | Matt Caswell | 10 July 2014, 22:47:31 UTC | Fixed valgrind complaint due to BN_consttime_swap reading uninitialised data. This is actually ok for this function, but initialised to zero anyway if PURIFY defined. This does have the impact of masking any *real* unitialised data reads in bn though. Patch based on approach suggested by Rich Salz. PR#3415 (cherry picked from commit 77747e2d9a5573b1dbc15e247ce18c03374c760c) | 13 July 2014, 21:23:10 UTC |
| 704422c | Peter Mosmans | 13 July 2014, 17:30:07 UTC | Add names of GOST algorithms. PR#3440 (cherry picked from commit 924e5eda2c82d737cc5a1b9c37918aa6e34825da) | 13 July 2014, 17:31:36 UTC |
| 8e8d7e1 | Richard Levitte | 13 July 2014, 17:11:29 UTC | * crypto/ui/ui_lib.c: misplaced brace in switch statement. Detected by dcruette@qualitesys.com (cherry picked from commit 8b5dd340919e511137696792279f595a70ae2762) | 13 July 2014, 17:15:30 UTC |
| 3ed6327 | Ben Laurie | 10 July 2014, 16:47:48 UTC | Don't clean up uninitialised EVP_CIPHER_CTX on error (CID 483259). (cherry picked from commit c1d1b0114e9d370c30649e46182393dbfc00e20c) | 10 July 2014, 16:52:37 UTC |
| efd4f1d | Matt Caswell | 09 July 2014, 22:29:17 UTC | Fix memory leak in BIO_free if there is no destroy function. Based on an original patch by Neitrino Photonov <neitrinoph@gmail.com> PR#3439 (cherry picked from commit 66816c53bea0ecddb9448da7ea9a51a334496127) | 09 July 2014, 22:34:35 UTC |
| 00032b0 | David Lloyd | 07 July 2014, 12:11:48 UTC | Prevent infinite loop loading config files. PR#2985 (cherry picked from commit 9d23f422a32cb333a5e803199ae230706b1bf9f5) | 07 July 2014, 12:50:00 UTC |
| a07f514 | Dr. Stephen Henson | 06 July 2014, 21:33:35 UTC | Usage for -hack and -prexit -verify_return_error (cherry picked from commit ee724df75d9ad67fd954253ac514fddb46f1e3c6) | 06 July 2014, 21:48:57 UTC |
| b197c77 | Dr. Stephen Henson | 06 July 2014, 21:16:21 UTC | Document certificate status request options. (cherry picked from commit cba3f1c739f012aaadb85aaefaf8de424d2695e2) Conflicts: doc/apps/s_client.pod doc/apps/s_server.pod | 06 July 2014, 21:48:52 UTC |
| b7c9762 | Dr. Stephen Henson | 06 July 2014, 21:23:01 UTC | s_server usage for certificate status requests (cherry picked from commit a44f219c009798054d6741e919cba5b2e656dbf4) | 06 July 2014, 21:45:44 UTC |
