bfe07df | Matt Caswell | 03 December 2015, 14:44:31 UTC | Prepare for 1.0.2e release Reviewed-by: Richard Levitte <levitte@openssl.org> | 03 December 2015, 14:44:31 UTC |
33223e7 | Matt Caswell | 03 December 2015, 14:44:31 UTC | make update Reviewed-by: Richard Levitte <levitte@openssl.org> | 03 December 2015, 14:44:31 UTC |
9330fbd | Matt Caswell | 01 December 2015, 14:39:47 UTC | Update CHANGES and NEWS Update the CHANGES and NEWS files for the new release. Reviewed-by: Richard Levitte <levitte@openssl.org> | 03 December 2015, 14:32:05 UTC |
00456fd | Dr. Stephen Henson | 04 November 2015, 13:30:03 UTC | Add test for CVE-2015-3194 Reviewed-by: Richard Levitte <levitte@openssl.org> | 03 December 2015, 14:32:05 UTC |
c394a48 | Dr. Stephen Henson | 02 October 2015, 11:35:19 UTC | Add PSS parameter check. Avoid seg fault by checking mgf1 parameter is not NULL. This can be triggered during certificate verification so could be a DoS attack against a client or a server enabling client authentication. Thanks to Loïc Jonas Etienne (Qnective AG) for discovering this bug. CVE-2015-3194 Reviewed-by: Richard Levitte <levitte@openssl.org> | 03 December 2015, 14:32:05 UTC |
d73cc25 | Andy Polyakov | 01 December 2015, 08:00:32 UTC | bn/asm/x86_64-mont5.pl: fix carry propagating bug (CVE-2015-3193). Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit e7c078db57908cbf16074c68034977565ffaf107) | 03 December 2015, 14:32:05 UTC |
cc598f3 | Dr. Stephen Henson | 10 November 2015, 19:03:07 UTC | Fix leak with ASN.1 combine. When parsing a combined structure pass a flag to the decode routine so on error a pointer to the parent structure is not zeroed as this will leak any additional components in the parent. This can leak memory in any application parsing PKCS#7 or CMS structures. CVE-2015-3195. Thanks to Adam Langley (Google/BoringSSL) for discovering this bug using libFuzzer. PR#4131 Reviewed-by: Richard Levitte <levitte@openssl.org> | 03 December 2015, 14:32:05 UTC |
fb4f467 | Richard Levitte | 03 December 2015, 14:20:10 UTC | Add cleanup of *.s Reviewed-by: Matt Caswell <matt@openssl.org> | 03 December 2015, 14:20:10 UTC |
babe434 | Andy Polyakov | 02 December 2015, 13:32:08 UTC | perlasm/ppc-xlate.pl: comply with ABIs that specify vrsave as reserved. RT#4162 Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit b5516cfbd65de9331d827012fc5bdace1953613e) | 03 December 2015, 12:31:36 UTC |
87bc193 | Richard Levitte | 02 December 2015, 17:18:03 UTC | _BSD_SOURCE is deprecated, use _DEFAULT_SOURCE instead The feature_test_macros(7) manual tells us that _BSD_SOURCE is deprecated since glibc 2.20 and that the compiler will warn about it being used, unless _DEFAULT_SOURCE is defined as well. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit f9fd35248c9a3b1125d9ab82ffb19d62e86533ac) | 02 December 2015, 17:49:28 UTC |
15c62b0 | Andy Polyakov | 01 December 2015, 11:21:08 UTC | crypto/sparcv9cap.c: add SIGILL-free feature detection for Solaris. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 2238e0e45d03ec9ba15e9547f7739cc6987a8f57) | 02 December 2015, 09:56:27 UTC |
94f98a9 | Matt Caswell | 30 November 2015, 10:38:54 UTC | Remove cookie validation return value trick In the DTLS ClientHello processing the return value is stored in |ret| which by default is -1. |ret| is only updated to a positive value once we are past all points where we could hit an error. We wish to return 1 on success or 2 on success *and* we have validated the DTLS cookie. Previously on successful validation of the cookie we were setting |ret| to -2, and then once we were past all error points we set |ret = -ret|. This is non-obvious behaviour and could be error prone. This commit tries to make this a bit more intuitive. Reviewed-by: Andy Polyakov <appro@openssl.org> | 01 December 2015, 15:23:42 UTC |
301a6dc | Andy Polyakov | 21 November 2015, 10:32:05 UTC | x86_64 assembly pack: tune clang version detection. RT#4142 Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 76eba0d94bb418325be6409b272eac5e2bd4a0a9) Resolved conflicts: crypto/bn/asm/x86_64-mont.pl crypto/bn/asm/x86_64-mont5.pl Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 30 November 2015, 12:37:39 UTC |
ed02493 | Kurt Roeckx | 24 November 2015, 22:21:06 UTC | Use both sun and __sun Reviewed-by: Andy Polyakov <appro@openssl.org> | 24 November 2015, 22:44:05 UTC |
296f7bd | Marcus Meissner | 24 November 2015, 21:03:58 UTC | mark openssl configuration as loaded at end of OPENSSL_config Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Rich Salz <rsalz@akamai.com> GH: #466 (cherry picked from commit 434b58457c8cca4d09f77a1774d6d2c446604bae) | 24 November 2015, 21:05:10 UTC |
a5b63f8 | Pascal Cuoq | 22 November 2015, 23:13:15 UTC | ssl3_free(): Return if it wasn't created If somewhere in SSL_new() there is a memory allocation failure, ssl3_free() can get called with s->s3 still being NULL. Patch also provided by Willy Tarreau <wtarreau@haproxy.com> Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Viktor Dukhovni <openssl-users@dukhovni.org> (cherry picked from commit 3e7bd2ce0b16f8611298175d6dc7cb35ee06ea6d) | 24 November 2015, 20:56:33 UTC |
3a9328e | Kurt Roeckx | 22 November 2015, 23:07:28 UTC | Set reference count earlier Backport of 0e04674e964b905e67e3d215bcf888932c92765f Reviewed-by: Steve Henson <steve@openssl.org> RT #4047, #4110, MR #1356 | 24 November 2015, 20:54:38 UTC |
943c4ca | Dr. Stephen Henson | 24 November 2015, 16:37:52 UTC | Fix uninitialised p error. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 63eb10a07ee29a312e50a227f5b3a290b1ad22b4) | 24 November 2015, 16:55:34 UTC |
d88ef40 | Dr. Stephen Henson | 03 September 2015, 13:27:19 UTC | Limit depth of ASN1 parse printing. Thanks to Guido Vranken <guidovranken@gmail.com> for reporting this issue. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 158e5207a794603f5d64ffa95e0247c7808ab445) Conflicts: crypto/asn1/asn1_par.c | 24 November 2015, 15:29:05 UTC |
9252d71 | Andy Polyakov | 21 November 2015, 10:28:05 UTC | Makefile.org: add LC_ALL=C to unify error [and other] messages. RT#4138 Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 193ed2d74b1a643b5f32bd46bf50a858fcdd2da4) | 23 November 2015, 15:03:15 UTC |
fb92839 | Kurt Roeckx | 22 November 2015, 09:31:35 UTC | Use defined(__sun) instead of defined(sun) Strict ISO confirming C compilers only define __sun Reviewed-by: Viktor Dukhovni <openssl-users@dukhovni.org> RT #4144, MR #1353 (cherry picked from commit 3d32218812e87221344f2985512e42e4aaa88745) | 22 November 2015, 11:21:13 UTC |
6d31885 | Alessandro Ghedini | 28 October 2015, 20:11:37 UTC | Add initial AppVeyor configuration Original patch by Frank Morgner. Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Rich Salz <rsalz@akamai.com> GH: #456 (cherry picked from commit 68db80e2d1accdd4c4a6b4763559c6cfe9663820) | 21 November 2015, 19:15:36 UTC |
03bf712 | Viktor Dukhovni | 21 November 2015, 05:59:07 UTC | Good hygiene with size_t output argument. Though the callers check the function return value and ignore the size_t output argument on failure, it is still often not ideal to store -1 in a size_t on error. That might signal an unduly large buffer. Instead set the size_t to 0, to indicate no space. Reviewed-by: Richard Levitte <levitte@openssl.org> | 21 November 2015, 10:23:20 UTC |
56d9134 | Matt Caswell | 06 November 2015, 16:31:21 UTC | Ensure all EVP calls have their returns checked where appropriate There are lots of calls to EVP functions from within libssl There were various places where we should probably check the return value but don't. This adds these checks. Reviewed-by: Richard Levitte <levitte@openssl.org> | 20 November 2015, 15:47:44 UTC |
cb70eed | Rich Salz | 19 November 2015, 15:19:55 UTC | Fix README version typo Reviewed-by: Steve Marquess <marquess@openssl.com> | 19 November 2015, 15:20:21 UTC |
01d625e | Rich Salz | 18 November 2015, 22:00:02 UTC | Fix release in README Reviewed-by: Steve Marquess <marquess@openssl.com> | 18 November 2015, 22:00:02 UTC |
bc2ab6e | Andy Polyakov | 13 November 2015, 22:52:13 UTC | aes/asm/vpaes-ppc.pl: eliminate overhung stores in misaligned cases. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit ce24d2ed232a095349886aecc8cb959d5dda8342) | 18 November 2015, 10:57:45 UTC |
bef7693 | Andy Polyakov | 13 November 2015, 22:44:23 UTC | bn/asm/ppc64-mont.pl: adapt for little-endian. The problem remained unnoticed so far, because it's never called by default. You have to craft OPENSSL_ppccap environment variable to trigger the problem. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit e4693b4e2a0c3f6241d4d3e61460c34c7e0013f6) | 16 November 2015, 12:41:58 UTC |
c6a5fdd | Andy Polyakov | 10 November 2015, 20:11:24 UTC | bn/asm/s390x.S: improve performance on z196 and z13 by up to 26%. [even z10 is couple percent faster]. Triggered by RT#4128, but solves the problem by real modulo-scheduling. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 9d0e4dc6351df7d0c08400c4b4cf17c017022e50) | 16 November 2015, 12:11:27 UTC |
817ddb9 | Andy Polyakov | 04 November 2015, 22:57:06 UTC | aesni-sha256-x86_64.pl: fix crash on AMD Jaguar. It was also found that stich performs suboptimally on AMD Jaguar, hence execution is limited to XOP-capable and Intel processors. Reviewed-by: Kurt Roeckx <kurt@openssl.org> (cherry picked from commit a5fd24d19bbb586b1c6d235c2021e9bead22c9f5) | 16 November 2015, 12:07:33 UTC |
f236ef2 | Graeme Perrow | 13 November 2015, 21:56:18 UTC | RT32671: wrong multiple errs TS_check_status_info Manual cherry-pick of 0704343f138a38d3882d5af2a4ebe8821e9a8f3a. Signed-off-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> | 13 November 2015, 21:57:08 UTC |
4800800 | Andy Polyakov | 10 November 2015, 20:57:22 UTC | modes/asm/ghash-armv4.pl: make it compile by clang. RT#3989 Reviewed-by: Matt Caswell <matt@openssl.org> | 11 November 2015, 21:12:28 UTC |
d40ec4a | Matt Caswell | 10 November 2015, 15:17:42 UTC | Stop DTLS servers asking for unsafe legacy renegotiation If a DTLS client that does not support secure renegotiation connects to an OpenSSL DTLS server then, by default, renegotiation is disabled. If a server application attempts to initiate a renegotiation then OpenSSL is supposed to prevent this. However due to a discrepancy between the TLS and DTLS code, the server sends a HelloRequest anyway in DTLS. This is not a security concern because the handshake will still fail later in the process when the client responds with a ClientHello. Reviewed-by: Tim Hudson <tjh@openssl.org> | 10 November 2015, 19:24:20 UTC |
15a7164 | Matt Caswell | 03 November 2015, 15:49:08 UTC | Only call ssl3_init_finished_mac once for DTLS In DTLS if an IO retry occurs during writing of a fragmented ClientHello then we can end up reseting the finish mac variables on the retry, which causes a handshake failure. We should only reset on the first attempt not on retries. Thanks to BoringSSL for reporting this issue. RT#4119 Reviewed-by: Tim Hudson <tjh@openssl.org> | 10 November 2015, 18:44:56 UTC |
822d265 | Matt Caswell | 09 November 2015, 16:37:33 UTC | Remove redundant check from tls1_get_curvelist The function tls1_get_curvelist() has an explicit check to see if s->cert is NULL or not. However the check appears *after* calling the tls1_suiteb macro which derefs s->cert. In reality s->cert can never be NULL because it is created in SSL_new(). If the malloc fails then the SSL_new call fails and no SSL object is created. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 6329b6092b28b656be8a1e4a8363d2e3bcc32053) Conflicts: ssl/t1_lib.c | 09 November 2015, 23:10:31 UTC |
903738a | Matt Caswell | 04 November 2015, 15:51:02 UTC | Fix missing malloc return value checks During work on a larger change in master a number of locations were identified where return value checks were missing. This backports the relevant fixes. Reviewed-by: Richard Levitte <levitte@openssl.org> | 09 November 2015, 22:54:19 UTC |
a89dda8 | Richard Levitte | 09 November 2015, 08:50:56 UTC | Make the match for previous cflags a bit more strict ./Configure [target] --strict-warnings -Wno-pedantic-ms-format would not add '-pedantic' because it matches '-Wno-pedantic-ms-format', which was added first. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 6703c4ea87b30554283deaa5df1f8d68725d3ee4) | 09 November 2015, 11:15:42 UTC |
fdbe4a3 | Dr. Stephen Henson | 08 November 2015, 13:47:53 UTC | Reject TLS 1.2 ciphersuites if not allowed. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> | 08 November 2015, 13:47:53 UTC |
0c0f136 | Matt Caswell | 04 November 2015, 14:46:03 UTC | Ensure the dtls1_get_*_methods work with DTLS_ANY_VERSION The various dtls1_get*_methods did not handle the DTLS_ANY_VERSION case, so this needed to be added. Reviewed-by: Tim Hudson <tjh@openssl.org> | 04 November 2015, 14:46:03 UTC |
ca3658e | Matt Caswell | 02 November 2015, 15:37:45 UTC | Minor EVP_SignInit_ex doc fix EVP_SignInit_ex was missing from the NAME section of its man page so typing "man EVP_SignInit_ex" failed to load the page. Reviewed-by: Stephen Henson <steve@openssl.org> (cherry picked from commit 3d866ea67e8b19777e88ac2a78ee4188e0983168) | 04 November 2015, 14:39:16 UTC |
8f486d7 | Matt Caswell | 01 November 2015, 14:41:29 UTC | Clarify the preferred way of creating patch files Clarify that git format-patch output is preferred for creating patch files. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit f89ee71bc81017e04ac50f570d8aed87f495bcf2) | 02 November 2015, 14:33:51 UTC |
706c85d | Rich Salz | 01 November 2015, 13:38:42 UTC | Various README and CONTRIBUTING updates Close GH Issue 69 Close GH PR 457/RT4113 Some other updates By Rich Salz, Alessandro Ghedini, Steve Marquess, Collin Anderson (manual cherry-pick of a2aaf8be7e3c22a61ef89f273aa85f482b955336 and b06935f439af7150d3ae566922353c3f210e63ed) Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 01 November 2015, 13:38:42 UTC |
dfb23a5 | Pascal Cuoq | 12 October 2015, 10:19:19 UTC | BN_GF2m_mod_inv(): check bn_wexpand return value Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Rich Salz <rsalz@akamai.com> MR #1276, RT #4107 (cherry picked from commit 94b3664a528258df5ebcaae213d19bf6568cc47d) | 29 October 2015, 19:36:34 UTC |
b62a2f8 | Alessandro Ghedini | 08 October 2015, 20:00:27 UTC | Remove useless code RT#4081 Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 070c23325af4526c9a8532a60d63522c58d5554b) | 23 October 2015, 18:32:59 UTC |
a8bd9f9 | Alessandro Ghedini | 08 October 2015, 12:50:27 UTC | Check memory allocation Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 8cf9d71a3a43d9b98a8a278d47dc08088a954a7b) | 23 October 2015, 18:32:59 UTC |
43679fc | Alessandro Ghedini | 08 October 2015, 12:41:09 UTC | Fix references to various RFCs Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 3240e7cf5f651d9d94814b4d494fbe294e463b72) | 23 October 2015, 18:32:58 UTC |
ec3a7c9 | Alessandro Ghedini | 08 October 2015, 12:40:42 UTC | Fix typos Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit d900a015b5a89ea2018e6122dd2738925e4d68ab) | 23 October 2015, 18:32:58 UTC |
72895f5 | Alessandro Ghedini | 08 October 2015, 12:39:58 UTC | Set salt length after the malloc has succeeded Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit c2319cf9fce87a2e82efb6e58ced11a85190dc3d) | 23 October 2015, 17:59:34 UTC |
e90f1d9 | Alessandro Ghedini | 08 October 2015, 12:38:57 UTC | Fix memory leaks and other mistakes on errors Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 3f6c7691870d1cd2ad0e0c83638cef3f35a0b548) | 23 October 2015, 17:58:54 UTC |
5a1e6b1 | Alessandro Ghedini | 08 October 2015, 12:37:21 UTC | Replace malloc+strlcpy with strdup Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 8acaabec429b39f9436f6a88006384d72d292539) | 23 October 2015, 17:58:48 UTC |
51a1cc4 | Alessandro Ghedini | 02 October 2015, 13:16:08 UTC | Do not treat 0 return value from BIO_get_fd() as error 0 is a valid file descriptor. RT#4068 Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 4428c7dba8f6f407d915c1226f4e0f673e8be241) | 23 October 2015, 17:57:53 UTC |
8d43c00 | Adam Eijdenberg | 19 October 2015, 18:16:25 UTC | Clarify return values for EVP_DigestVerifyFinal. Previous language was unclear. New language isn't pretty but I believe it is more accurate. Signed-off-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Ben Laurie <ben@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 8cbb048c3ea416f2bd8a3706d027f3aa26ef08d9) | 22 October 2015, 22:28:38 UTC |
e272f8e | Dr. Stephen Henson | 05 August 2015, 02:21:40 UTC | Fix self signed handling. Don't mark a certificate as self signed if keyUsage is present and certificate signing not asserted. PR#3979 Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit f51e5ed6b4b91d12228da873db72aa28109d1797) | 15 October 2015, 14:37:55 UTC |
c97c7f8 | Emilia Kasper | 09 October 2015, 18:00:53 UTC | make depend: prefer clang over makedepend Reviewed-by: Rich Salz <rsalz@openssl.org> | 14 October 2015, 17:08:54 UTC |
a20d942 | Dr. Stephen Henson | 12 October 2015, 20:14:04 UTC | RFC5753 compliance. RFC5753 requires that we omit parameters for AES key wrap and set them to NULL for 3DES wrap. OpenSSL decrypt uses the received algorithm parameters so can transparently handle either form. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 4ec36aff2a3c221b640dafa56ac838312e6724f4) | 13 October 2015, 22:02:44 UTC |
bf9d61d | Peter Mosmans | 27 May 2014, 22:26:11 UTC | RT3346: Fix test_bn regexp for Windows using MSYS. (cherry picked from commit 028bac0670c167f154438742eb4d0fbed73df209) Signed-off-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Andy Polyakov <appro@openssl.org> | 13 October 2015, 20:09:42 UTC |
6868346 | Dr. Stephen Henson | 10 October 2015, 23:06:56 UTC | Typo. PR#4079 Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit c69ce9351336f5b4a8b33890756b3fd185528210) | 10 October 2015, 23:28:20 UTC |
985abd1 | Matt Caswell | 08 October 2015, 12:36:10 UTC | Don't treat a bare OCTETSTRING as DigestInfo in int_rsa_verify The function int_rsa_verify is an internal function used for verifying an RSA signature. It takes an argument |dtype| which indicates the digest type that was used. Dependant on that digest type the processing of the signature data will vary. In particular if |dtype == NID_mdc2| and the signature data is a bare OCTETSTRING then it is treated differently to the default case where the signature data is treated as a DigestInfo (X509_SIG). Due to a missing "else" keyword the logic actually correctly processes the OCTETSTRING format signature first, and then attempts to continue and process it as DigestInfo. This will invariably fail because we already know that it is a bare OCTETSTRING. This failure doesn't actualy make a real difference because it ends up at the |err| label regardless and still returns a "success" result. This patch just cleans things up to make it look a bit more sane. RT#4076 Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit dffe51091f412dcbc18f6641132f0b4f0def6bce) | 08 October 2015, 13:11:59 UTC |
b004247 | Richard Levitte | 08 October 2015, 09:53:07 UTC | When ENGINE_add finds that id or name is missing, actually return Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 5850cc75ea0c1581a9034390f1ca77cadc596238) | 08 October 2015, 10:41:12 UTC |
bb7b893 | Alessandro Ghedini | 07 October 2015, 20:40:37 UTC | Fix travis 1.0.2 builds Disable -Wshadow error when building with GCC Add support for linu-x86_64-clang debug; this is needed for Travis CI. Disable linux-clang and mingw debug builds on Travis CI; not supported. Fix Travis email notifications config Signed-off-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Andy Polyakov <appro@openssl.org> | 07 October 2015, 20:42:42 UTC |
cc1cdc5 | Pascal Cuoq | 05 May 2015, 09:20:39 UTC | Move BN_CTX_start() call so the error case can always call BN_CTX_end(). Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Rich Salz <rsalz@openssl.org> MR #1231 (cherry picked from commit 99c203337574d967c86ffbfa13f40ace51048485) | 07 October 2015, 18:36:54 UTC |
738b8e6 | Pascal Cuoq | 06 May 2015, 07:55:28 UTC | Properly check return type of DH_compute_key() It returns -1 on error, not 0. Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Rich Salz <rsalz@openssl.org> MR #1231 (cherry picked from commit d6e92c0bd6c36fc68291e79ef5753fd7f0420695) | 07 October 2015, 18:36:46 UTC |
6481be7 | Pascal Cuoq | 06 May 2015, 09:31:27 UTC | Set flags to 0 before calling BN_with_flags() BN_with_flags() will read the dest->flags to keep the BN_FLG_MALLOCED but overwrites everything else. Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Rich Salz <rsalz@openssl.org> MR #1231 (cherry picked from commit f92768e6f5259069bd21dbed2b98b3423c1dfca4) | 07 October 2015, 18:36:34 UTC |
cba8745 | Dr. Stephen Henson | 06 October 2015, 13:15:14 UTC | Don't try and parse boolean type. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit e58c4d3cdde7a0a01df2884bfeec31a2b07be22d) | 06 October 2015, 14:16:05 UTC |
61dfe3a | Matt Caswell | 05 October 2015, 13:12:05 UTC | Change functions to pass in a limit rather than calculate it Some extension handling functions were passing in a pointer to the start of the data, plus the length in order to calculate the end, rather than just passing in the end to start with. This change makes things a little more readable. Reviewed-by: Emilia Käsper <emilia@openssl.org> | 05 October 2015, 13:14:02 UTC |
184718b | Alessandro Ghedini | 02 October 2015, 12:38:30 UTC | Validate ClientHello extension field length RT#4069 Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 05 October 2015, 11:09:20 UTC |
6b247c1 | Kurt Roeckx | 29 September 2015, 17:59:48 UTC | Fix more d2i cases to properly update the input pointer Thanks to David Benjamin <davidben@google.com> for pointing them out. Reviewed-by: Steve Henson <steve@openssl.org> MR #1198 (cherry picked from commit 605236f6a8fe0743af2f63d93239a74c69dae137) | 03 October 2015, 11:29:15 UTC |
d62c64b | Dr. Stephen Henson | 28 September 2015, 13:14:10 UTC | Link in applink with fips_premain_dso PR#4042 Reviewed-by: Tim Hudson <tjh@openssl.org> | 29 September 2015, 17:43:02 UTC |
6f997dc | Ismo Puustinen | 18 September 2015, 20:07:23 UTC | GH367: use random data if seed too short. Signed-off-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org> | 29 September 2015, 16:48:43 UTC |
21b538d | Emilia Kasper | 23 September 2015, 17:29:18 UTC | RT2772: accept empty SessionTicket RFC 5077 section 3.3 says: If the server determines that it does not want to include a ticket after it has included the SessionTicket extension in the ServerHello, then it sends a zero-length ticket in the NewSessionTicket handshake message. Previously the client would fail upon attempting to allocate a zero-length buffer. Now, we have the client ignore the empty ticket and keep the existing session. Reviewed-by: Matt Caswell <matt@openssl.org> | 28 September 2015, 14:07:00 UTC |
92ea6fe | Dr. Stephen Henson | 28 September 2015, 13:31:53 UTC | SRP memory leak fix Reviewed-by: Richard Levitte <levitte@openssl.org> | 28 September 2015, 13:31:53 UTC |
920f7cf | Rich Salz | 25 September 2015, 15:44:28 UTC | Fix typo in previous merge. Reviewed-by: Tim Hudson <tjh@openssl.org> | 25 September 2015, 15:44:28 UTC |
605a54e | Rich Salz | 25 September 2015, 15:38:43 UTC | Change --debug to -d for compat with old releases. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 1d4ddb4e1a088f1333c4bb155c52c7f94e572bca) | 25 September 2015, 15:39:26 UTC |
51ff683 | Emilia Kasper | 17 September 2015, 11:55:09 UTC | Document BUF_strnlen Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 21b0fa91186ff1c1c3d956c0593ef4ac02521695) | 22 September 2015, 18:04:36 UTC |
be250ee | Emilia Kasper | 17 September 2015, 11:50:34 UTC | BUF_strdup and friends: update docs Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 58e3457a82e8940ff36b36949f9c7a60e7614b2c) | 22 September 2015, 18:04:32 UTC |
f5afe9c | Emilia Kasper | 17 September 2015, 11:27:05 UTC | BUF_strndup: tidy Fix comment, add another overflow check, tidy style Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit de8883e11befde31d9b6cfbbd1fc017c365e0bbf) | 22 September 2015, 18:04:01 UTC |
f61216b | Alessandro Ghedini | 16 September 2015, 15:54:05 UTC | Make BUF_strndup() read-safe on arbitrary inputs BUF_strndup was calling strlen through BUF_strlcpy, and ended up reading past the input if the input was not a C string. Make it explicitly part of BUF_strndup's contract to never read more than |siz| input bytes. This augments the standard strndup contract to be safer. The commit also adds a check for siz overflow and some brief documentation for BUF_strndup(). Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 110f7b37de9feecfb64950601cc7cec77cf6130b) | 22 September 2015, 18:03:57 UTC |
c038e6b | Rich Salz | 21 September 2015, 23:54:36 UTC | GH398: Add mingw cross-compile, etc. For all release branches. It adds travis build support. If you don't have a config file it uses the default (because we enabled travis for the project), which uses ruby/rake/rakefiles, and you get confusing "build still failing" messages. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit db9defdfe306e1adf0af7188b187d535eb0268da) | 22 September 2015, 17:46:06 UTC |
0ea050e | David Woodhouse | 09 September 2015, 19:49:01 UTC | RT3479: Add UTF8 support to BIO_read_filename() If we use BIO_new_file(), on Windows it'll jump through hoops to work around their unusual charset/Unicode handling. it'll convert a UTF-8 filename to UCS-16LE and attempt to use _wfopen(). If you use BIO_read_filename(), it doesn't do this. Shouldn't it be consistent? It would certainly be nice if SSL_use_certificate_chain_file() worked. Also made BIO_C_SET_FILENAME work (rsalz) Signed-off-by: Rich Salz <rsalz@akamai.com> Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit ff03599a2f518dbdf13bca0bb0208e431b892fe9) | 21 September 2015, 21:31:58 UTC |
d601b9b | Gunnar Kudrjavets | 27 April 2015, 18:14:45 UTC | RT3823: Improve the robustness of event logging There are a couple of minor fixes here: 1) Handle the case when RegisterEventSource() fails (which it may for various reasons) and do the work of logging the event only if it succeeds. 2) Handle the case when ReportEvent() fails and do our best in debug builds to at least attempt somehow indicate that something has gone wrong. The typical situation would be someone running tools like DbMon, DBWin32, DebugView or just having the debugger attached. The intent is to make sure that at least some data will be captured so that we can save hours and days of debugging time. 3) Minor fix to change the MessageBox() flag to MB_ICONERROR. Though the value of MB_ICONERROR is the same value as MB_ICONSTOP, the intent is better conveyed by using MB_ICONERROR. Testing performed: 1) Clean compilation for debug-VC-WIN32 and VC-WIN32. 2) Good test results (nmake -f ms\ntdll.mak test) for debug-VC-WIN32 and VC-WIN32. 3) Stepped through relevant changes using WinDBG and exercised the impacted code paths. Signed-off-by: Rich Salz <rsalz@akamai.com> Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 4cd94416a452c3a3e0df24c297f7d2f0e6d5bb5f) | 21 September 2015, 18:36:26 UTC |
b21b330 | Matt Caswell | 16 September 2015, 09:24:37 UTC | Fix SRP memory leaks There were some memory leaks in the creation of an SRP verifier (both on successful completion and also on some error paths). Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit bf95cde28712cfcad90cb3975cdcb8e5c0f20fde) | 21 September 2015, 09:23:25 UTC |
325bb1a | Dr. Stephen Henson | 13 September 2015, 18:04:58 UTC | Handle SSL_ERROR_WANT_X509_LOOKUP Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit f1c412c9e63f7c9cac2c723bff09cce563dda1b0) | 20 September 2015, 13:21:18 UTC |
2e3a21e | Dr. Stephen Henson | 12 September 2015, 01:37:48 UTC | Make SRP work with -www PR#3817 Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 4e7e623012e1604d985e2ef362c2957d464f3f01) | 20 September 2015, 13:21:17 UTC |
8748519 | Viktor Dukhovni | 19 September 2015, 01:15:42 UTC | Fix indentation Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 4fe1cbdff89768c5d1983988ce1022674a438bbb) | 19 September 2015, 13:09:14 UTC |
6be18a2 | Rich Salz | 18 September 2015, 01:53:43 UTC | This undoes GH367 for non-master Was only approved for master, to avoid compatibility issues on previous releases. Reviewed-by: Emilia Käsper <emilia@openssl.org> | 18 September 2015, 19:56:23 UTC |
197db21 | Matt Caswell | 16 September 2015, 09:47:15 UTC | Make sure OPENSSL_cleanse checks for NULL In master we have the function OPENSSL_clear_free(x,y), which immediately returns if x == NULL. In <=1.0.2 this function does not exist so we have to do: OPENSSL_cleanse(x, y); OPENSSL_free(x); However, previously, OPENSSL_cleanse did not check that if x == NULL, so the real equivalent check would have to be: if (x != NULL) OPENSSL_cleanse(x, y); OPENSSL_free(x); It would be easy to get this wrong during cherry-picking to other branches and therefore, for safety, it is best to just ensure OPENSSL_cleanse also checks for NULL. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 020d8fc83fe1a94232db1ee1166309e2458a8a18) | 17 September 2015, 21:31:24 UTC |
cb71f17 | Emilia Kasper | 17 September 2015, 18:08:48 UTC | base64 decode: check for high bit Previously, the conversion would silently coerce to ASCII. Now, we error out. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit b785504a10310cb2872270eb409b70971be5e76e) | 17 September 2015, 19:45:06 UTC |
37faf11 | Emilia Kasper | 02 September 2015, 13:31:28 UTC | RT3757: base64 encoding bugs Rewrite EVP_DecodeUpdate. In particular: reject extra trailing padding, and padding in the middle of the content. Don't limit line length. Add tests. Previously, the behaviour was ill-defined, and depended on the position of the padding within the input. In addition, this appears to fix a possible two-byte oob read. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Dr Stephen Henson <steve@openssl.org> (cherry picked from commit 3cdd1e94b1d71f2ce3002738f9506da91fe2af45) | 17 September 2015, 18:12:34 UTC |
0711826 | Kurt Roeckx | 15 September 2015, 19:26:32 UTC | Fix return values when adding serverinfo fails. Reviewed-by: Rich Salz <rsalz@openssl.org> MR #1128 (cherry picked from commit fae11ec714ac8e71d95e824d7102ab5b2ec2e256) | 16 September 2015, 19:03:45 UTC |
929f6d6 | Ivo Raisr | 11 September 2015, 16:24:33 UTC | Make no-psk compile without warnings. PR#4035 Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org> | 16 September 2015, 17:09:00 UTC |
beb841c | Rich Salz | 15 September 2015, 16:01:30 UTC | RT4044: Remove .cvsignore files. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 83fcd322f7b398534fba7816ca3c0896f529c7c0) | 15 September 2015, 16:02:17 UTC |
3be39dc | Rich Salz | 15 September 2015, 15:49:42 UTC | RT4044: Remove .cvsignore files. Reviewed-by: Matt Caswell <matt@openssl.org> | 15 September 2015, 15:58:27 UTC |
728bcd5 | Kurt Roeckx | 14 September 2015, 22:07:02 UTC | d2i: don't update input pointer on failure Reviewed-by: Dr. Stephen Henson <steve@openssl.org> MR #1005 (cherry picked from commit a46c9789ce2aecedceef119e9883513c7a49f1ca) | 14 September 2015, 22:07:54 UTC |
5116aee | Dr. Stephen Henson | 12 September 2015, 00:53:52 UTC | Constify ECDSA_METHOD_new. PR#3920. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit aabd49232025807babe995006a46c4c7815ce868) | 12 September 2015, 01:47:40 UTC |
2aa5a2c | Dr. Stephen Henson | 11 September 2015, 23:44:07 UTC | Check for FIPS mode after loading config. PR#3958 Reviewed-by: Rich Salz <rsalz@openssl.org> | 12 September 2015, 00:02:23 UTC |
eac2b83 | John Foley | 11 September 2015, 23:11:23 UTC | Use memmove instead of memcpy. PR#4036 Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org> | 11 September 2015, 23:11:23 UTC |
ce5ae63 | Dr. Stephen Henson | 11 September 2015, 15:13:52 UTC | Use default field separator. If the field separator isn't specified through -nameopt then use XN_FLAG_SEP_CPLUS_SPC instead of printing nothing and returing an error. PR#2397 Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 03706afa30aeb4407287171a9d6f9a765395d0a2) | 11 September 2015, 19:52:17 UTC |
4dcdde1 | Emilia Kasper | 01 September 2015, 14:31:55 UTC | RT3754: check for NULL pointer Fix both the caller to error out on malloc failure, as well as the eventual callee to handle a NULL gracefully. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> | 10 September 2015, 15:23:02 UTC |
7b8a999 | Rich Salz | 08 September 2015, 15:37:05 UTC | Remove bogus CHANGES entries Reviewed-by: Dr. Stephen Henson <steve@openssl.org> | 08 September 2015, 15:37:05 UTC |
2df619b | Dr. Stephen Henson | 03 September 2015, 23:20:34 UTC | Match SUITEB strings at start of cipher list. PR#4009. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 13e228d6845aff7e454eea7c9ddd392ebfbd2868) Conflicts: ssl/ssl_ciph.c | 04 September 2015, 20:32:25 UTC |